Skip to content

Update help site for mobile selection mode actions#87570

Open
MelvinBot wants to merge 1 commit intomainfrom
melvinbot-helpsite-selection-mode-actions
Open

Update help site for mobile selection mode actions#87570
MelvinBot wants to merge 1 commit intomainfrom
melvinbot-helpsite-selection-mode-actions

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates Getting-Started-with-the-Reports-Page.md to document that Submit, Approve, and Pay actions are available in the mobile bulk action menu when all expenses in a report are selected.
  • This corresponds to the feature shipped in Add selection mode Submit/Approve/Pay actions for mobile layout. #85796, which removed the production gate on selection mode report-level actions.

Test plan

  • Verify the updated article renders correctly on the help site
  • Confirm the new note accurately describes the mobile selection mode behavior

…ctions

Add note about report-level actions (Submit, Approve, Pay) being available
in the mobile bulk action menu when all expenses are selected.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

**Note:** The bulk action menu appears after selecting at least one expense.

**Note (Mobile):** When all expenses in a report are selected on mobile, the bulk action menu also includes report-level actions such as **Submit**, **Approve**, or **Pay**, depending on the report status and your role. These work the same as the primary action buttons at the top of the report.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/style violation — prohibited generic label and vague reference:

Two issues on this line:

  1. "Note (Mobile):" uses a prohibited pattern. Per HELP_AUTHORING_GUIDELINES.md Section 2, "Notes" is a forbidden generic heading/label. Per HELPSITE_NAMING_CONVENTIONS.md (Cross-Platform Clarity Rule and Navigation Instruction Standards), platform-specific behavior should use the standard platform label format — e.g., a separate line starting with Mobile: — rather than a parenthetical qualifier on a "Note" prefix.

  2. "the primary action buttons at the top of the report" is vague. Per the Deterministic Writing Rule in HELPSITE_NAMING_CONVENTIONS.md, always reference exact UI labels. Since the buttons are already named in this sentence (Submit, Approve, Pay), you can tighten this. For example:

    **Mobile:** When all expenses in a report are selected, the bulk action menu also includes report-level actions — **Submit**, **Approve**, or **Pay** — depending on the report status and your role. These perform the same actions as the **Submit**, **Approve**, or **Pay** buttons shown in the report header.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single mobile-specific note to the "Available Actions on the Table" section, clarifying that when all expenses are selected on mobile, the bulk action menu surfaces report-level actions (Submit, Approve, Pay). The change is small, well-scoped, and follows the Cross-Platform Clarity Rule by explicitly stating the platform.

Scores Summary

  • Readability: 8/10 - The note is concise and clearly explains the mobile-specific behavior. It logically follows the existing bulk action note, maintaining good flow.
  • AI Readiness: 8/10 - No headings or metadata were changed. The added text uses full feature names (Submit, Approve, Pay) which aids retrieval. No negative impact on existing AI readiness.
  • Style Compliance: 7/10 - Button names are correctly bolded. Platform is explicitly stated per the Cross-Platform Clarity Rule. However, the phrase "primary action buttons at the top of the report" is a soft UI reference rather than an exact UI label, which the Deterministic Writing Rule discourages. Consider referencing the specific button area more precisely (e.g., "the Submit, Approve, or Pay button shown in the report header") to avoid ambiguity.

Key Findings

  • The change correctly follows the convention of bolding UI element names (Submit, Approve, Pay).
  • The explicit platform callout ("on mobile") aligns with the Cross-Platform Clarity Rule in HELPSITE_NAMING_CONVENTIONS.md, which requires explicitly stating the platform when behavior differs.
  • The phrase "These work the same as the primary action buttons at the top of the report" is slightly vague. The Deterministic Writing Rule states: "Be literal. Be exact. Be consistent. Avoid stylistic variation." Pointing to "primary action buttons" without using their exact UI label could be tightened.
  • No heading, metadata, or structural changes were introduced, so no governance violations in those areas.

Recommendations

  1. Consider rephrasing the trailing sentence to be more UI-exact. For example: "These perform the same action as the Submit, Approve, or Pay button displayed in the report header." This removes the generic "primary action buttons" reference.
  2. The change is otherwise clean and ready to merge from a documentation governance standpoint.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Reports-Page.md -- One mobile-specific note added after the bulk action note. No structural or metadata changes.

Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance rules. Assessment covers only the proposed diff, not pre-existing content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants