[Payment due @bernhardoj] Properly determine the feedType to assign to new CSV feeds by Gonals · Pull Request #87603 · Expensify/App

Gonals · 2026-04-10T11:31:19Z

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/622812
#86814
PROPOSAL:

Tests

Go to Workspace -> Company Cards
Click Add cards.
Select United States > Next.
Select Direct feed > Next.
Select Import transactions from file > Next.
Enter Company card layout name and save it.
Click Next.
Upload a valid CSV file.
Map Account number to Card number.
Click Import.
Confirm the cards import properly

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Do the test steps in an Expensifail account (it must be there) and confirm they work properly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-04-10T11:40:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...e/companyCards/addNew/CompanyCardsImportedPage.tsx	`0.00% <0.00%> (ø)`
src/libs/CardUtils.ts	`80.14% <90.47%> (+0.32%)`	⬆️
... and 11 files with indirect coverage changes

melvin-bot · 2026-04-10T14:56:33Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-04-10T16:21:17Z

I guess I need to wait for some BE change first, right?

Gonals · 2026-04-14T07:48:23Z

I guess I need to wait for some BE change first, right?

Nope, you are good to go!

bernhardoj · 2026-04-14T08:10:11Z

@Gonals it still has the same issue as I mentioned here

web.mp4

Gonals · 2026-04-15T14:02:43Z

@Gonals it still has the same issue as I mentioned here

web.mp4

I'm not seeing this behavior anymore. I believe it was caused by a mismatch in feedtype

bernhardoj · 2026-04-16T03:00:57Z

web.mp4

@Gonals I am still experiencing the BE issue.

Here is the payload sent to ImportCSVCompanyCards

policyID 1889C3160F6629F5
settings {"columnMappings":["cardNumber","postedDate","merchant","amount","currency","ignore","ignore","ignore","externalID"],"instanceID":"1776308207517","layoutName":"test","layoutType":"ccupload3"}

But the response from OpenPolicyCompanyCardsFeed always set the cards to empty

domainAccountID   21006192
policyID                   1889C3160F6629F5
feed                         ccupload3

Gonals · 2026-04-16T09:35:35Z

Hmmm. I can't reproduce it in dev but, in any case, we should still fix the fact that we are not setting the right feedtype, so let's move on with this PR while I keep investigating what could be happening in the backend.

bernhardoj · 2026-04-16T11:50:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-16T11:55:53Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-16T11:55:55Z

🎯 @bernhardoj, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/622812.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

OSBotify · 2026-04-16T18:33:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-16T19:21:54Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-16T19:26:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87603.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8dc318b-4ad96fb-d7e6502942a3b2c7ab94abdcde9d23bc5c33707f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8dc318b-4ad96fb-757017b36278f6844850c231164217fa6f5c2e03/index.html

Web 🕸️
https://87603.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Gonals added 2 commits April 10, 2026 12:20

Use new helper function to check existing CSV feeds

3dc33a4

prettier

7b09571

Gonals self-assigned this Apr 10, 2026

Gonals added 2 commits April 10, 2026 16:17

simplify

345f8c6

Merge branch 'main' into alberto-oneImport

0f4d154

Gonals marked this pull request as ready for review April 10, 2026 14:56

Gonals requested review from a team as code owners April 10, 2026 14:56

melvin-bot bot requested review from JmillsExpensify and bernhardoj and removed request for a team and JmillsExpensify April 10, 2026 14:56

melvin-bot bot removed the request for review from a team April 10, 2026 14:56

bernhardoj approved these changes Apr 16, 2026

View reviewed changes

melvin-bot bot requested a review from cristipaval April 16, 2026 11:55

melvin-bot bot changed the title ~~Properly determine the feedType to assign to new CSV feeds~~ [Payment due @bernhardoj] Properly determine the feedType to assign to new CSV feeds Apr 16, 2026

cristipaval approved these changes Apr 16, 2026

View reviewed changes

cristipaval merged commit 8dc318b into main Apr 16, 2026
44 checks passed

cristipaval deleted the alberto-oneImport branch April 16, 2026 18:22

bernhardoj mentioned this pull request Apr 17, 2026

[Payment due @bernhardoj] Properly display CSV feeds before we load the cards #88136

Open

52 tasks

Conversation

Gonals commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 10, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Apr 10, 2026

Uh oh!

bernhardoj commented Apr 10, 2026

Uh oh!

Gonals commented Apr 14, 2026

Uh oh!

bernhardoj commented Apr 14, 2026

Uh oh!

Gonals commented Apr 15, 2026

Uh oh!

bernhardoj commented Apr 16, 2026

Uh oh!

Gonals commented Apr 16, 2026

Uh oh!

bernhardoj commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 16, 2026

Uh oh!

melvin-bot bot commented Apr 16, 2026

Uh oh!

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

github-actions bot commented Apr 16, 2026

Uh oh!

github-actions bot commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gonals commented Apr 10, 2026 •

edited

Loading

codecov bot commented Apr 10, 2026 •

edited by github-actions bot

Loading

bernhardoj commented Apr 16, 2026 •

edited

Loading