[CP Staging] Fix issues with getting started slot#87636
[CP Staging] Fix issues with getting started slot#87636roryabraham merged 3 commits intoExpensify:mainfrom
Conversation
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hi @ZhenjaHorbach, do you need help reviewing this PR? |
Go ahead! |
|
@codex review |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.ts
Outdated
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid_1.mp4android_hybrid_2.mp4Android: mWeb Chromeandroid_mWeb_1.mp4android_mWeb_2.mp4iOS: HybridAppios_hybrid_1.mp4ios_hybrid_2.mp4iOS: mWeb Safariios_mWeb_1.mp4ios_mWeb_2.mp4MacOS: Chrome / Safariweb_chrome_1.mp4web_chrome_2.mp4 |
|
Recording platform videos, will take about 10-15 mins. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Fix issues with getting started slot (cherry picked from commit da69a09) (cherry-picked to staging by roryabraham)
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.58-6 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against the help site articles under No help site changes are required. The PR modifies visibility logic for the "Getting Started" section on Home (hiding it for non-admins, conditionally showing "Set up spend rules" only when rules are enabled). The existing Expensify Home Overview article does not document the "Getting Started" section or its checklist items, and no other help site article references these items either. |
Explanation of Change
Fixed Issues
$ #87607
$ #87621
PROPOSAL:
Tests
Set up spend rulesis not displayedSet up spend rulesis displayedOffline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-04-10.16.15.22.mov