Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 011cb940..29cfa94a 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2533,7 +2533,7 @@ ${amount} für ${merchant} – ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Diese Karte wurde von ',
frozenByAdminNeedsUnfreezeSuffix: ' gesperrt. Bitte kontaktiere einen Admin, um sie zu entsperren.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Diese Karte wurde von ${person} gesperrt. Bitte kontaktiere einen Admin, um sie zu entsperren.`,
- spendRules: 'Ausgaberegeln',
+ spendRules: 'Ausgaberichtlinien',
editSpendRules: 'Ausgaberegeln bearbeiten',
},
workflowsPage: {
@@ -6879,7 +6879,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
currencyMismatchTitle: 'Währungsinkonsistenz',
currencyMismatchPrompt: 'Um einen Höchstbetrag festzulegen, wählen Sie Karten aus, die in derselben Währung abgerechnet werden.',
reviewSelectedCards: 'Ausgewählte Karten prüfen',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}, +${count} weitere` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}, +${count} weitere` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: 'Wenden Sie mindestens eine Ausgabenregel auf eine Karte an',
confirmErrorCardRequired: 'Feld „Karte“ ist erforderlich',
confirmErrorApplyAtLeastOneSpendRule: 'Wenden Sie mindestens eine Ausgabenregel an',
@@ -6914,6 +6914,30 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
editRuleTitle: 'Regel bearbeiten',
deleteRule: 'Regel löschen',
deleteRuleConfirmation: 'Sind Sie sicher, dass Sie diese Regel löschen möchten?',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Blockiert' : 'Erlaubt'} ${shownCount > 1 ? 'Händler' : 'Händler'}: ${merchants}${hiddenCount > 0 ? `, +${hiddenCount} weitere` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Blockiert' : 'Erlaubt'} ${shownCount > 1 ? 'Kategorien' : 'Kategorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} weitere` : ''}`,
},
},
planTypePage: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 897217ab..c52da5c3 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2540,7 +2540,7 @@ ${amount} pour ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezeSuffix: '. Veuillez contacter un administrateur pour la dégeler.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Cette carte a été gelée par ${person}. Veuillez contacter un administrateur pour la dégeler.`,
spendRules: 'Règles de dépense',
- editSpendRules: 'Modifier les règles de dépense',
+ editSpendRules: 'Modifier les règles de dépenses',
},
workflowsPage: {
workflowTitle: 'Dépense',
@@ -6901,7 +6901,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
currencyMismatchTitle: 'Incompatibilité de devise',
currencyMismatchPrompt: 'Pour définir un montant maximal, sélectionnez des cartes qui sont réglées dans la même devise.',
reviewSelectedCards: 'Examiner les cartes sélectionnées',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}, +${count} de plus` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}, +${count} de plus` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: 'Appliquez au moins une règle de dépense à une carte',
confirmErrorCardRequired: 'La carte est un champ obligatoire',
confirmErrorApplyAtLeastOneSpendRule: 'Appliquez au moins une règle de dépense',
@@ -6936,6 +6936,30 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
editRuleTitle: 'Modifier la règle',
deleteRule: 'Supprimer la règle',
deleteRuleConfirmation: 'Êtes-vous sûr de vouloir supprimer cette règle ?',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqué' : 'Autorisé'} ${shownCount > 1 ? 'commerçants' : 'commerçant'}: ${merchants}${hiddenCount > 0 ? `, +${hiddenCount} de plus` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqué' : 'Autorisé'} ${shownCount > 1 ? 'catégories' : 'catégorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} de plus` : ''}`,
},
},
planTypePage: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 95977d56..837c0fa6 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2529,7 +2529,7 @@ ${amount} per ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezeSuffix: '. Contatta un amministratore per sbloccarla.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Questa carta è stata bloccata da ${person}. Contatta un amministratore per sbloccarla.`,
spendRules: 'Regole di spesa',
- editSpendRules: 'Modifica le regole di spesa',
+ editSpendRules: 'Modifica regole di spesa',
},
workflowsPage: {
workflowTitle: 'Spesa',
@@ -6864,7 +6864,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
currencyMismatchTitle: 'Valuta non corrispondente',
currencyMismatchPrompt: 'Per impostare un importo massimo, seleziona carte che si regolano nella stessa valuta.',
reviewSelectedCards: 'Controlla le carte selezionate',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}, +${count} altro` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}, +${count} altri` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: 'Applica almeno una regola di spesa a una carta',
confirmErrorCardRequired: 'Il campo Carta è obbligatorio',
confirmErrorApplyAtLeastOneSpendRule: 'Applica almeno una regola di spesa',
@@ -6899,6 +6899,30 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
editRuleTitle: 'Modifica regola',
deleteRule: 'Elimina regola',
deleteRuleConfirmation: 'Sei sicuro di voler eliminare questa regola?',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloccato' : 'Consentito'} ${shownCount > 1 ? 'esercenti' : 'esercente'}: ${merchants}${hiddenCount > 0 ? `, +${hiddenCount} in più` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloccato' : 'Consentito'} ${shownCount > 1 ? 'categorie' : 'categoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} in più` : ''}`,
},
},
planTypePage: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index ffba36e6..402206fd 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6789,7 +6789,7 @@ ${reportName}
currencyMismatchTitle: '通貨の不一致',
currencyMismatchPrompt: '上限金額を設定するには、同じ通貨で清算されるカードを選択してください。',
reviewSelectedCards: '選択したカードを確認',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}、ほか +${count} 件` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}、ほか+${count}件` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: '少なくとも1つの支出ルールを1枚のカードに適用してください',
confirmErrorCardRequired: 'カードは必須項目です',
confirmErrorApplyAtLeastOneSpendRule: '少なくとも 1 つの支出ルールを適用してください',
@@ -6824,6 +6824,30 @@ ${reportName}
editRuleTitle: 'ルールを編集',
deleteRule: 'ルールを削除',
deleteRuleConfirmation: 'このルールを削除してもよろしいですか？',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'ブロック済み' : '許可されています'} ${shownCount > 1 ? '加盟店' : '加盟店'}: ${merchants}${hiddenCount > 0 ? `、ほか +${hiddenCount} 件` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'ブロック済み' : '許可されています'} ${shownCount > 1 ? 'カテゴリ' : 'カテゴリ'}: ${categories}${hiddenCount > 0 ? `、ほか +${hiddenCount} 件` : ''}`,
},
},
planTypePage: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 976c7946..2062bc13 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2526,7 +2526,7 @@ ${amount} voor ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Deze kaart is bevroren door ',
frozenByAdminNeedsUnfreezeSuffix: '. Neem contact op met een beheerder om deze te deblokkeren.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Deze kaart is bevroren door ${person}. Neem contact op met een beheerder om deze te deblokkeren.`,
- spendRules: 'Uitgavenregels',
+ spendRules: 'Bestedingsregels',
editSpendRules: 'Uitgavenregels bewerken',
},
workflowsPage: {
@@ -6845,7 +6845,7 @@ Voeg meer bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
currencyMismatchTitle: 'Valutamismatch',
currencyMismatchPrompt: 'Om een maximumbedrag in te stellen, selecteer je kaarten die in dezelfde valuta worden vereffend.',
reviewSelectedCards: 'Geselecteerde kaarten bekijken',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}, +${count} meer` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}, +${count} meer` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: 'Pas minstens één bestedingsregel toe op één kaart',
confirmErrorCardRequired: 'Kaart is een verplicht veld',
confirmErrorApplyAtLeastOneSpendRule: 'Pas minstens één bestedingsregel toe',
@@ -6880,6 +6880,30 @@ Voeg meer bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
editRuleTitle: 'Regel bewerken',
deleteRule: 'Regel verwijderen',
deleteRuleConfirmation: 'Weet je zeker dat je deze regel wilt verwijderen?',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Geblokkeerd' : 'Toegestaan'} ${shownCount > 1 ? 'handelaars' : 'handelaar'}: ${merchants}${hiddenCount > 0 ? `, +${hiddenCount} meer` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Geblokkeerd' : 'Toegestaan'} ${shownCount > 1 ? 'categorieën' : 'categorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} meer` : ''}`,
},
},
planTypePage: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 15ca55e5..9f3b617c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2522,7 +2522,7 @@ ${amount} dla ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezeSuffix: '. Skontaktuj się z administratorem, aby ją odmrozić.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Ta karta została zamrożona przez ${person}. Skontaktuj się z administratorem, aby ją odmrozić.`,
spendRules: 'Zasady wydatków',
- editSpendRules: 'Edytuj reguły wydatków',
+ editSpendRules: 'Edytuj zasady wydatków',
},
workflowsPage: {
workflowTitle: 'Wydatki',
@@ -6836,7 +6836,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
currencyMismatchTitle: 'Niezgodność waluty',
currencyMismatchPrompt: 'Aby ustawić maksymalną kwotę, wybierz karty rozliczane w tej samej walucie.',
reviewSelectedCards: 'Przejrzyj wybrane karty',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}, +${count} więcej` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}, +${count} więcej` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: 'Zastosuj co najmniej jedną regułę wydatków do jednej karty',
confirmErrorCardRequired: 'Pole „Karta” jest wymagane',
confirmErrorApplyAtLeastOneSpendRule: 'Zastosuj co najmniej jedną regułę wydatków',
@@ -6871,6 +6871,30 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
editRuleTitle: 'Edytuj regułę',
deleteRule: 'Usuń regułę',
deleteRuleConfirmation: 'Na pewno chcesz usunąć tę regułę?',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Zablokowane' : 'Dozwolone'} ${shownCount > 1 ? 'sprzedawcy' : 'sprzedawca'}: ${merchants}${hiddenCount > 0 ? `, +${hiddenCount} więcej` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Zablokowane' : 'Dozwolone'} ${shownCount > 1 ? 'kategorie' : 'kategoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} więcej` : ''}`,
},
},
planTypePage: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 51db7e9c..725f8dd7 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2520,7 +2520,7 @@ ${amount} para ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezeSuffix: '. Entre em contato com um administrador para desbloqueá-lo.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Este cartão foi bloqueado por ${person}. Entre em contato com um administrador para desbloqueá-lo.`,
spendRules: 'Regras de gasto',
- editSpendRules: 'Editar regras de gasto',
+ editSpendRules: 'Editar regras de gastos',
},
workflowsPage: {
workflowTitle: 'Gastos',
@@ -6843,7 +6843,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
currencyMismatchTitle: 'Incompatibilidade de moeda',
currencyMismatchPrompt: 'Para definir um valor máximo, selecione cartões que liquidem na mesma moeda.',
reviewSelectedCards: 'Revisar cartões selecionados',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}, +${count} mais` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}, +${count} mais` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: 'Aplicar pelo menos uma regra de gasto a um cartão',
confirmErrorCardRequired: 'O campo Cartão é obrigatório',
confirmErrorApplyAtLeastOneSpendRule: 'Aplicar pelo menos uma regra de gasto',
@@ -6878,6 +6878,30 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
editRuleTitle: 'Editar regra',
deleteRule: 'Excluir regra',
deleteRuleConfirmation: 'Tem certeza de que quer excluir esta regra?',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqueado' : 'Permitido'} ${shownCount > 1 ? 'comerciantes' : 'estabelecimento'}: ${merchants}${hiddenCount > 0 ? `, +${hiddenCount} mais` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqueado' : 'Permitido'} ${shownCount > 1 ? 'categorias' : 'categoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} mais` : ''}`,
},
},
planTypePage: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0d7f1f00..bc46e3b1 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6664,7 +6664,7 @@ ${reportName}
currencyMismatchTitle: '货币不匹配',
currencyMismatchPrompt: '若要设置最高金额，请选择以相同货币结算的卡片。',
reviewSelectedCards: '检查所选卡片',
- summaryMoreCount: ({summary, count}) => (count > 0 ? `${summary}，还有 +${count} 个` : summary),
+ summaryMoreCount: ({summary, count}: {summary: string; count: number}) => (count > 0 ? `${summary}，还有 +${count} 项` : summary),
confirmErrorApplyAtLeastOneSpendRuleToOneCard: '至少将一条支出规则应用到一张卡上',
confirmErrorCardRequired: '“卡”是必填字段',
confirmErrorApplyAtLeastOneSpendRule: '至少应用一条支出规则',
@@ -6699,6 +6699,30 @@ ${reportName}
editRuleTitle: '编辑规则',
deleteRule: '删除规则',
deleteRuleConfirmation: '确定要删除此规则吗？',
+ summaryMerchants: ({
+ merchants,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ merchants: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? '已屏蔽' : '已允许'} ${shownCount > 1 ? '商户' : '商家'}: ${merchants}${hiddenCount > 0 ? `，还有 +${hiddenCount} 个` : ''}`,
+ summaryCategories: ({
+ categories,
+ hiddenCount,
+ shownCount,
+ action,
+ }: {
+ categories: string;
+ hiddenCount: number;
+ shownCount: number;
+ action: ValueOf<typeof CONST.SPEND_RULES.ACTION>;
+ }) =>
+ `${action === CONST.SPEND_RULES.ACTION.BLOCK ? '已屏蔽' : '已允许'} ${shownCount > 1 ? '类别' : '类别'}: ${categories}${hiddenCount > 0 ? `，还有 +${hiddenCount} 个` : ''}`,
},
},
planTypePage: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
luacmartins
commented
Apr 15, 2026
| API.write(WRITE_COMMANDS.QUEUE_EXPENSIFY_CARD_FOR_BILLING, parameters); | ||
| } | ||
|
|
||
| function isSpendRuleASTNode(value: unknown): value is ExpensifyCardRuleFilter { |
Contributor
Author
There was a problem hiding this comment.
Just moved all this code to SpendRulesUtils.ts
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a148e7f80
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0be3bcb3e7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
melvin-bot
Bot
requested review from
JmillsExpensify and
suneox
and removed request for
a team
Contributor
|
I'll take a look on this one today |
Contributor
|
@luacmartins We have a BE issue with the SetExpensifyCardRule API CleanShot.2026-04-22.at.22.42.14.1.mp4 |
Contributor
Author
|
@suneox yea, that's know and it's a current BE issue. We're working on it. |
suneox
reviewed
Apr 22, 2026
| return undefined; | ||
| } | ||
|
|
||
| const MAX_SUMMARY_CHARS = 66; |
Contributor
There was a problem hiding this comment.
Truncation: We’ll truncate the same as the workspace editor, so 74 characters and up to two lines, after which we show “+X more.”
According to the document, the truncate limit is still 74 characters. I’m not sure if I missed any updates.
Contributor
Author
There was a problem hiding this comment.
Ah yea, sorry. We discussed this internally since 74 characters was too long and was truncating the +X more text, so we decided to update it to 66.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppCleanShot.2026-04-22.at.23.37.50.5.mp4Android: mWeb ChromeCleanShot.2026-04-22.at.23.32.52.3.mp4iOS: HybridAppCleanShot.2026-04-22.at.23.29.19.2.mp4iOS: mWeb SafariCleanShot.2026-04-22.at.23.35.55.4.mp4MacOS: Chrome / SafariCleanShot.2026-04-22.at.23.24.21.1.mp4 |
suneox
approved these changes
Apr 22, 2026
Contributor
suneox
left a comment
suneox
left a comment
There was a problem hiding this comment.
The current change set LGTM.
Regarding the issue with editing a spend rule: in the case of creating a new one, we don’t pre-fill the selected card, and this isn’t mentioned in the documentation. If we decide to handle this case, we can track it as a separate issue.
CleanShot.2026-04-22.at.23.29.19.2.mp4
JS00001
approved these changes
Apr 22, 2026
Contributor
Author
There was a problem hiding this comment.
Good point. I'll fix that in a follow up
Contributor
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
52 tasks
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds a summary of rules to the
Settings > WalletandWorkspace > Expensify Card > DetailspagesFixed Issues
$ #86525
Tests
Pre-condition: Workspace with expensify cards and rules enabled
Workspaces > RulesSpend rulesWorkspaces > Expensify cardAccount > Walletand select the Expensify card assigned to the userOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Screen.Recording.2026-04-20.at.4.26.47.PM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari