feat: add bulk duplicate report action to Reports search page#87728
feat: add bulk duplicate report action to Reports search page#87728Valforte merged 27 commits intoExpensify:mainfrom
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot review this |
PR Review —
|
… add playSound Signed-off-by: krishna2323 <belivethatkg@gmail.com>
… checks, add playSound" This reverts commit d4cedde.
…Reports Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
|
@MelvinBot review and look for regressions |
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@hungvu193 This seems to be an existing issue, it also doesn't highlight for new expense creation: Monosnap.screencast.2026-04-17.23-17-49.mp4 |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…eports Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Sounds good. Can you resolve the linting in the meantime? |
…cate Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de585d7742
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@Krishna2323 where are you at with these failing jest tests? |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@hungvu193 @Valforte I've added a beta gate for this feature because bulk features typically have many edge cases. I've worked on three bulk features, and both of the previous ones had beta gates to avoid reverts. WDYT? Let me know if you have a different opinion. IMO, bulk features are harder to test thoroughly since they involve cross-policy interactions. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Yep. I agree with this one 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb ChromemChrome.moviOS: HybridAppios.moviOS: mWeb Safarisafari.movMacOS: Chrome / Safarichrome.movchrome1.mov |
Valforte
left a comment
There was a problem hiding this comment.
Agree with the beta flag, LGTM!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.62-0 🚀
Bundle Size Analysis (Sentry): |
|
Deploy Blocker ##88665 was identified to be related to this PR. |
Explanation of Change
Fixed Issues
$ #86683
PROPOSAL:
Tests
1. Basic Bulk Report Duplication
2. Option Visibility — Only for Expense Reports You Submitted
3. Option Visibility — Only on Reports Tab
4. Option Visibility — Requires Default Expense Policy
5. Card and Scanning Expenses Excluded
6. Cross-Policy Duplication (Source Policy Accessible)
7. Cross-Policy Duplication (Source Policy Inaccessible)
8. Distance and Per Diem Expense Duplication
9. Empty Report / No Eligible Transactions
10. Selection Cleared After Duplication
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
test_1.mp4
test_2.mp4
test_3.mp4
test_4.mp4
test_5.mp4
test_6.mp4
test_7.mp4
test_7B.mp4
test_8.mp4
test_9.mp4
test_10.mp4
test_11.mp4