Add new span for FAB add report to Scan Page by rinej · Pull Request #87765 · Expensify/App

rinej · 2026-04-13T14:58:48Z

Explanation of Change

We need proper Sentry instrumentation for the Camera FAB → Scan page transition. Specifically, a parent span measuring the full time from FAB tap to camera ready, with two subspans:

Navigation to the Scan page
Scan page render until the camera is ready

In the PR I added a new dedicated Sentry span ManualEntryToScan with two subspans (ManualEntryToScanNavigation for FAB tap → Scan page mount, and ManualEntryToScanReady for Scan page mount → camera ready) to measure the Camera FAB → Scan page flow. The spans use a generic source attribute (camera_fab) so the same instrumentation can be reused for Global Create and Quick Action entry points without adding new constants. Both coexist with the existing ManualOpenCreateExpense span - no changes to current dashboards

Fixed Issues

$ #87854
PROPOSAL:

Tests

Web

Tap the Camera FAB button
Verify in Sentry (Explore) that a ManualEntryToScan span appears with:
source: camera_fab
platform: web
Confirm two child spans exist:
ManualEntryToScanNavigation
ManualEntryToScanReady

Native (iOS / Android)

Tap the Camera FAB button and wait for the camera to initialize
Verify in Sentry that a ManualEntryToScan span appears with:
source: camera_fab
platform: ios/android
Confirm:
ManualEntryToScanNavigation ends on page mount
ManualEntryToScanReady ends when the camera is ready

Non-FAB Entry

Open Create Expense via the Global Create menu
Verify that:
No ManualEntryToScan span is created
Only ManualOpenCreateExpense fires (unchanged behavior)

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-14T10:56:17Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-14T10:56:23Z

@cretadn22 @cristipaval One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9932964686

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-14T11:13:09Z

+            // Cancel entry-to-scan spans if they haven't ended naturally
+            cancelSpan(CONST.TELEMETRY.SPAN_ENTRY_TO_SCAN_NAVIGATION);
+            cancelSpan(CONST.TELEMETRY.SPAN_ENTRY_TO_SCAN_READY);
+            cancelSpan(CONST.TELEMETRY.SPAN_ENTRY_TO_SCAN);


Cancel entry-to-scan spans on permission denial

SPAN_ENTRY_TO_SCAN_READY and SPAN_ENTRY_TO_SCAN are only canceled in the unmount cleanup, so in the denied/blocked/unavailable permission path they stay active as long as the user remains on the Scan screen. That means a user who waits on the permission UI can produce inflated durations (or effectively never-finished spans), which skews the new FAB→Scan telemetry. The permission-status effect already cancels SPAN_OPEN_CREATE_EXPENSE; these new entry spans should be canceled there as well to keep measurements consistent.

Useful? React with 👍 / 👎.

@rinej could you please address that?

added the change and also resolved the conflicts

…ab-sentry-spans # Conflicts: # src/CONST/index.ts

Ollyws · 2026-04-15T11:45:12Z

Does this require C+ review? If so is it possible for C+ to access the Sentry logs for this?

rinej · 2026-04-15T13:23:44Z

Does this require C+ review? If so is it possible for C+ to access the Sentry logs for this?

I'm not sure about it. I know that for the previous span additions @rlinoz was testing it, maybe you could help here as well?

mkhutornyi · 2026-04-15T13:28:05Z

yes, C+ has access to sentry

Ollyws · 2026-04-15T15:32:53Z

@mkhutornyi We do, but do we have the permissions to create traces?

mkhutornyi · 2026-04-15T16:03:07Z

@mkhutornyi We do, but do we have the permissions to create traces?

Not sure what you mean. We send data to Sentry through the app with sentry log enabled and then we should see logs in sentry dashboard.

Ollyws · 2026-04-15T16:28:51Z

I meant on dev, it wasn't sending the logs but let me see if I can get it going.

mkhutornyi · 2026-04-15T16:30:15Z

I meant on dev, it wasn't sending the logs but let me see if I can get it going.

Try Troubleshoot > Switch Send data to Sentry on

rlinoz · 2026-04-15T17:00:08Z

Yep you can send spans from dev by doing the above.

Ollyws · 2026-04-15T18:04:37Z

Ah great, thanks!

Ollyws · 2026-04-15T18:04:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Ollyws · 2026-04-15T18:21:30Z

@rinej Are we supposed to have a ManualEntryToScanReady child span on web?
I can only see it being added to index.native.tsx and I'm only getting ManualEntryToScanNavigation on web:

rinej · 2026-04-23T10:00:15Z

Thanks for the input Olly!
The ManualEntryToScanReady span is intentionally native-only for now.
On native, camera initialization introduces quite big latency and, so it’s worth tracking as a dedicated child span.

On web, readiness is handled via the browser’s onUserMedia callback, which is generally faster and more predictable -so we just close the parent span on mount

We can add the extra logic to support a similar span on web as well.
Do we want to do it now, or wait until data shows it’s actually valuable?

rinej added 2 commits April 13, 2026 16:41

add ManualEntryToScan span in sentry

e7012d9

cleanup on web

9932964

melvin-bot Bot assigned rinej Apr 13, 2026

rinej mentioned this pull request Apr 13, 2026

[Performance] Optimize "Scan" page rendering (Camera FAB → Create expense w/ Scan) #83502

Open

rinej changed the title ~~Add ManualEntryToScan span in sentry~~ Add new span for FAB add report to Scan Page Apr 13, 2026

rinej marked this pull request as ready for review April 14, 2026 10:56

rinej requested review from a team as code owners April 14, 2026 10:56

melvin-bot Bot requested review from Ollyws and heyjennahay April 14, 2026 10:56

melvin-bot Bot requested review from a team, cretadn22 and cristipaval and removed request for a team April 14, 2026 10:56

melvin-bot Bot removed the request for review from a team April 14, 2026 10:56

rinej mentioned this pull request Apr 14, 2026

[Performance] Add Sentry spans for Camera FAB → Scan page flow #87854

Open

chatgpt-codex-connector Bot reviewed Apr 14, 2026

View reviewed changes

cristipaval removed the request for review from cretadn22 April 14, 2026 11:51

rinej added 2 commits April 15, 2026 12:42

cancel span when camera permission is denied

abcc9dd

Merge remote-tracking branch 'upstream/main' into sentry-add-camera-f…

99e9758

…ab-sentry-spans # Conflicts: # src/CONST/index.ts

Conversation

rinej commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 14, 2026

Uh oh!

melvin-bot Bot commented Apr 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

cristipaval Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

rinej Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Ollyws commented Apr 15, 2026

Uh oh!

rinej commented Apr 15, 2026

Uh oh!

mkhutornyi commented Apr 15, 2026

Uh oh!

Ollyws commented Apr 15, 2026

Uh oh!

mkhutornyi commented Apr 15, 2026

Uh oh!

Ollyws commented Apr 15, 2026

Uh oh!

mkhutornyi commented Apr 15, 2026

Uh oh!

rlinoz commented Apr 15, 2026

Uh oh!

Ollyws commented Apr 15, 2026

Uh oh!

Ollyws commented Apr 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws commented Apr 15, 2026

Uh oh!

rinej commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rinej commented Apr 13, 2026 •

edited

Loading