Fix Audit Reports navigation and prioritize report routes#87778
Fix Audit Reports navigation and prioritize report routes#87778marufsharifi wants to merge 4 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce0b3268b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@sobitneupane, I've addressed AI feedback. all yours. thanks. |
|
@sobitneupane, kindly bump. thanks. |
|
@sobitneupane, friendly bump. Thanks. |
|
Reviewing the PR. |
Explanation of Change
This update fixes several cases where users started in
Reports/Searchbut were unexpectedly redirected intoInbox.The change makes report-opening behavior context-aware, so direct opens from Search now use Search-owned routes instead of Inbox routes. It also fixes Search-based task create/edit flows by returning users to their existing Search stack after dismissing modals, rather than reconstructing an Inbox report route.
For leave-chat flows, the exact
backToroute from report details is now preserved and used first, which keeps users in the same Search context they came from. Finally, the deleted-report fallback after leaving was updated to be Search-aware as well, so once a report disappears, users are no longer bounced into Inbox as a fallback.Fixed Issues
$ #85560
PROPOSAL: #85560 (comment)
Tests
Open a task from Reports > Chats search results and stay in Search context
Edit task description from Search and dismiss back to the same Search stack
Leave-chat or deleted-report fallback preserves Search context
Edit expense description from Search and return to the same Search flow
Create or edit a second task description from Search without losing Search context
Edit task title from Search and dismiss back correctly
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-14.at.12.13.18.AM.mov
REC-2026041924207.PM.mp4
REC-2026041924307.PM.mp4
REC-2026041924753.PM.mp4
REC-2026041925021.PM.mp4
REC-2026041925056.PM.mp4
Android: mWeb Chrome
Screen.Recording.2026-04-13.at.11.59.29.PM.mov
REC-2026041641057.PM.mp4
REC-2026041641135.PM.mp4
REC-2026041641215.PM.mp4
REC-2026041641342.PM.mp4
REC-2026041641716.PM.mp4
iOS: Native
Screen.Recording.2026-04-13.at.10.52.13.PM.mov
REC-20260416101416.AM.mp4
REC-20260416101950.AM.mp4
REC-20260416102051.AM.mp4
REC-20260416102647.AM.mp4
REC-20260416102821.AM.mp4
iOS: mWeb Safari
Screen.Recording.2026-04-13.at.10.55.14.PM.mov
REC-2026041662705.PM.mp4
REC-2026041662858.PM.mp4
MacOS: Chrome / Safari
assign.task.mp4
assing.description.edit.mp4
concierge.mp4
expense.description.mp4
Screen.Recording.2026-04-13.at.10.35.44.PM.mov
task.title.edit.mov