Skip to content

fix: Navigation bar translucency on Android#87810

Open
chrispader wants to merge 8 commits intoExpensify:mainfrom
margelo:@chrispader/fix/navigation-bar-translucency-on-android
Open

fix: Navigation bar translucency on Android#87810
chrispader wants to merge 8 commits intoExpensify:mainfrom
margelo:@chrispader/fix/navigation-bar-translucency-on-android

Conversation

@chrispader
Copy link
Copy Markdown
Contributor

@chrispader chrispader commented Apr 13, 2026

@mountiny

Explanation of Change

Problem

When a modal opens on Android, a translucent background color and style is applied to three-button navigation bar. Since we render a custom navigation bar overlay in JS, we don't want that background color to show.

Solution

This PR updates the react-native+0.83.1+022+fix-modal-transparent-navigation-bar.patch and disables this native background style.

main This PR
Screen.Recording.2026-04-14.at.17.00.26.mov
Screen.Recording.2026-04-14.at.16.58.53.mov

Fixed Issues

$ #64241
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console
  1. Enable three-button navigation bar in Android settings
  2. Open the app on Android
  3. Go to a report
  4. Long-press a message
  5. While the modal opens, make sure that there is no translucent background style applied to the navigation bar

Offline tests

None needed.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console
  1. Enable three-button navigation bar in Android settings
  2. Open the app on Android
  3. Go to a report
  4. Long-press a message
  5. While the modal opens, make sure that there is no translucent background style applied to the navigation bar

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
main This PR
Screen.Recording.2026-04-14.at.17.00.26.mov
Screen.Recording.2026-04-14.at.16.58.53.mov

@chrispader chrispader requested review from a team as code owners April 13, 2026 22:11
@melvin-bot melvin-bot Bot requested review from heyjennahay and removed request for a team April 13, 2026 22:11
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@melvin-bot melvin-bot Bot requested a review from stitesExpensify April 13, 2026 22:11
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 13, 2026

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team April 13, 2026 22:11
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3c5ffbaa2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread android/app/src/main/res/values-v31/styles.xml Outdated
chrispader added a commit to margelo/Expensify that referenced this pull request Apr 13, 2026
@shubham1206agra
Copy link
Copy Markdown
Contributor

@chrispader Do we need any change in Mobile-Expensify repo too?

@mountiny mountiny requested review from mountiny and removed request for stitesExpensify April 14, 2026 04:13
@mountiny
Copy link
Copy Markdown
Contributor

@chrispader thanks, please also add a bit more detail when you have a minute

@chrispader chrispader changed the title [WIP] fix: Navigation bar translucency on Android fix: Navigation bar translucency on Android Apr 14, 2026
@chrispader
Copy link
Copy Markdown
Contributor Author

chrispader commented Apr 14, 2026

@chrispader thanks, please also add a bit more detail when you have a minute

@mountiny @shubham1206agra updated the PR description and checklist. Also simplified the PR, so no changes to Mobile-Expensify are needed anymore.

@shubham1206agra this is ready for review! Please note, the jump seen in the videos is not caused by my changes in the PR and also reproducible on main.

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@shubham1206agra
Copy link
Copy Markdown
Contributor

@chrispader Is there any device restriction to repro this bug? As I am unable to repro the bug in my device.

@chrispader
Copy link
Copy Markdown
Contributor Author

@chrispader Is there any device restriction to repro this bug? As I am unable to repro the bug in my device.

@shubham1206agra did you enable the three-button navigation bar?

@shubham1206agra
Copy link
Copy Markdown
Contributor

@chrispader Is there any device restriction to repro this bug? As I am unable to repro the bug in my device.

@shubham1206agra did you enable the three-button navigation bar?

Yes

@chrispader
Copy link
Copy Markdown
Contributor Author

@shubham1206agra what device and Android version are you on?

I can reproduce this on a Samsung Galaxy S10e with Android 12 and Samsung Galaxy A14 5G with Android 15. The only restriction for this bug to be reproducible should be that it allows edge-to-edge mode, meaning Android 10 and above.

The translucent scrim behind the three-button navigation bar might not be black/dark, but you should be able to see an overlay with a slightly different color than the background at least.

@shubham1206agra
Copy link
Copy Markdown
Contributor

@shubham1206agra what device and Android version are you on?

I can reproduce this on a Samsung Galaxy S10e with Android 12 and Samsung Galaxy A14 5G with Android 15. The only restriction for this bug to be reproducible should be that it allows edge-to-edge mode, meaning Android 10 and above.

The translucent scrim behind the three-button navigation bar might not be black/dark, but you should be able to see an overlay with a slightly different color than the background at least.

I have sent the details on DM to Chris

@mountiny
Copy link
Copy Markdown
Contributor

@chrispader what is the latest on this one?

@mountiny
Copy link
Copy Markdown
Contributor

@shubham1206agra Are you willing to work on this one for $250? I would like to have Chris work on some other issues and this is hard for him to reproduce, while you seem to be able to repro

@chrispader
Copy link
Copy Markdown
Contributor Author

@shubham1206agra if you're going to work on this, here is some context.

The navigation bar translucency depends very much on the device, OEM and Android version. In d18a367 i removed some changes to the Android XML-styles, which we might still need for specific devices like yours. In order to fix the navbar translucency (and also the navbar buttons/icons color and contrast), you could just add back these style changes and start from there.

I think this should be related to these styles, if not, we might need to find a similar fix in the React Native modal implementation, which i already updated in the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants