Skip to content

Part 2 - Thread personalDetailsList param through isOptimisticPersonalDetail + isTestTransactionReport chains#87825

Open
Krishna2323 wants to merge 8 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/66413/part-2
Open

Part 2 - Thread personalDetailsList param through isOptimisticPersonalDetail + isTestTransactionReport chains#87825
Krishna2323 wants to merge 8 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/66413/part-2

Conversation

@Krishna2323
Copy link
Copy Markdown
Contributor

@Krishna2323 Krishna2323 commented Apr 13, 2026 •
edited
Loading

Explanation of Change

Fixed Issues

$ #66413
PROPOSAL:

Tests

Tests

isOptimisticPersonalDetail / shouldDisableDetailPage:

  1. Log in to the app
  2. Open any 1:1 DM chat
  3. Tap the chat header to open the report details page
  4. Verify the details page loads correctly and is not disabled
  5. Go offline
  6. Send a message to a brand new user (who hasn't signed up yet)
  7. Verify the chat opens and the header shows correctly (optimistic personal detail scenario)
  8. Tap the header — verify the chat header is correctly disabled (not clickable) for the optimistic participant
  9. Go back online and verify the chat header becomes clickable once real personal details arrive.

isTestTransactionReport / buildOptimisticReportPreview:

  1. Submit a new expense to another user (e.g. manual expense for $10)
  2. Verify the report preview message appears correctly in the chat
  3. Open the expense report and verify it displays without errors
  4. If you have access to a test drive account (mctest), verify the test transaction badge behavior is correct

General:

  1. Open a split expense and verify the report preview renders correctly
  2. Verify no errors or crashes throughout
  • Verify that no errors appear in the JS console

Offline tests

  • Same as Tests

QA Steps

  • Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-04-14.19-35-36.mp4
Monosnap.screencast.2026-04-14.19-42-15.mp4

@Krishna2323
Add personalDetailsList param to isOptimisticPersonalDetail, shouldDi…
011b06d 
…sableDetailPage, isTestTransactionReport, and buildOptimisticReportPreview

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 changed the title Add personalDetailsList param to isOptimisticPersonalDetail, shouldDisableDetailPage, isTestTransactionReport, and buildOptimisticReportPreview Part 2 - Thread personalDetailsList param through isOptimisticPersonalDetail + isTestTransactionReport chains Apr 13, 2026
@Krishna2323
Copy link
Copy Markdown
Contributor Author

Krishna2323 commented Apr 13, 2026

@codex review

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026 •
edited by github-actions Bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...gineProvider/HTMLRenderers/UserDetailsRenderer.tsx 77.77% <100.00%> (+2.77%) ⬆️
src/libs/actions/IOU/Hold.ts 93.59% <ø> (ø)
src/libs/actions/IOU/PerDiem.ts 70.63% <100.00%> (ø)
src/libs/actions/IOU/SendInvoice.ts 95.93% <100.00%> (ø)
src/libs/actions/IOU/index.ts 80.31% <100.00%> (ø)
src/libs/actions/Policy/Member.ts 74.48% <100.00%> (-0.13%) ⬇️
src/libs/actions/Report/index.ts 68.90% <100.00%> (+0.28%) ⬆️
src/pages/inbox/HeaderView.tsx 96.90% <100.00%> (+0.06%) ⬆️
src/pages/inbox/report/ReportActionItemCreated.tsx 100.00% <100.00%> (ø)
src/libs/ReportUtils.ts 81.26% <91.66%> (+0.01%) ⬆️
... and 5 more
... and 139 files with indirect coverage changes

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 13, 2026

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Krishna2323
Standardize TODO comments to name the fallback function and target PR
08f5ed2 
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Move personalDetailsList before defaulted params in buildOptimisticRe…
a1a7b72 
…portPreview and standardize TODO comments

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 marked this pull request as ready for review April 14, 2026 14:13
@Krishna2323 Krishna2323 requested review from a team as code owners April 14, 2026 14:13
@melvin-bot melvin-bot Bot requested review from a team, DylanDylann and flaviadefaria and removed request for a team and DylanDylann April 14, 2026 14:13
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 14, 2026

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from DylanDylann and removed request for a team April 14, 2026 14:14
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 14, 2026

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Krishna2323 Krishna2323 mentioned this pull request Apr 14, 2026
Open
@flaviadefaria flaviadefaria removed their request for review April 14, 2026 18:41
@flaviadefaria
Copy link
Copy Markdown
Contributor

flaviadefaria commented Apr 14, 2026

No new product considerations - removing my assignment and unsubscribing.

@Krishna2323 Krishna2323 force-pushed the krishna2323/issue/66413/part-2 branch from b61063d to a1a7b72 Compare April 15, 2026 21:19
@Krishna2323 Krishna2323 requested review from a team and stephanieelliott as code owners April 15, 2026 21:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@Krishna2323
Merge branch 'main' into krishna2323/issue/66413/part-2
c49a0a7 
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 force-pushed the krishna2323/issue/66413/part-2 branch from 39ba12c to c49a0a7 Compare April 15, 2026 21:23
@Krishna2323
Copy link
Copy Markdown
Contributor Author

Krishna2323 commented Apr 15, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 15, 2026

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott stephanieelliott removed their request for review April 16, 2026 06:33
@Krishna2323
Copy link
Copy Markdown
Contributor Author

Krishna2323 commented Apr 17, 2026

@DylanDylann friendly bump

DylanDylann
DylanDylann reviewed Apr 20, 2026
View reviewed changes
Comment thread src/libs/ReportUtils.ts Outdated
@Krishna2323
Narrow isOptimisticPersonalDetail to accept a single PersonalDetails …
6fcc952 
…entry and use selector at call sites

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
fix lint.
4078e88 
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

This comment was marked as duplicate.

Sign in to view
@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 20, 2026

To use Codex here, create a Codex account and connect to github.

@Krishna2323
Copy link
Copy Markdown
Contributor Author

Krishna2323 commented Apr 20, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 20, 2026

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann
DylanDylann reviewed Apr 21, 2026
View reviewed changes
Comment thread src/components/HTMLEngineProvider/HTMLRenderers/UserDetailsRenderer.tsx
const styles = useThemeStyles();
const accountID = tnode.attributes.accountid ? parseInt(tnode.attributes.accountid, 10) : undefined;
const accountID = tnode.attributes.accountid ? parseInt(tnode.attributes.accountid, 10) : CONST.DEFAULT_NUMBER_ID;
const [personalDetail] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: personalDetailsSelector(accountID)});
Copy link
Copy Markdown
Contributor

@DylanDylann DylanDylann Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting isOptimisticPersonalDetail only should be sufficient here.

Copy link
Copy Markdown
Contributor

@DylanDylann DylanDylann Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishna2323 one comment

DylanDylann
DylanDylann reviewed Apr 21, 2026
View reviewed changes
Comment thread src/libs/ReportUtils.ts
* Helper method to check if the report is a test transaction report
*/
function isTestTransactionReport(report: OnyxEntry<Report>): boolean {
function isTestTransactionReport(report: OnyxEntry<Report>, personalDetailsList: OnyxEntry<PersonalDetailsList>): boolean {
Copy link
Copy Markdown
Contributor

@DylanDylann DylanDylann Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to isOptimisticPersonalDetail function I think we should not pass personalDetailsList

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DylanDylann DylanDylann DylanDylann left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Krishna2323 Krishna2323

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Krishna2323 @flaviadefaria @DylanDylann