Remove SCAN_TEST_TOOLTIP from Create Expense Scan flow

[MelvinBot]

Fixed Issues

$ #87170

Tests

1. Open the app and tap the + FAB → Submit Expense
2. Navigate to the Scan tab
3. Verify that no SCAN_TEST_TOOLTIP or SCAN_TEST_TOOLTIP_MANAGER tooltip appears
4. Verify the scan functionality still works normally (take/upload a photo)
5. Navigate to New Chat and search for contacts
6. Verify the InviteMemberListItem renders correctly without the old EducationalTooltip wrapper
7. If you have the NEWDOT_MANAGER_MCTEST beta enabled and are not a member of any policy, verify Manager McTest still appears as a contact
8. Verify the TestDrive feature (SCAN_TEST_DRIVE_CONFIRMATION tooltip) still works when applicable
9. Submit an expense and verify it completes successfully without errors
10. Verify that no errors appear in the JS console

Offline tests

1. Go offline (airplane mode or disconnect network)
2. Open the app and tap + FAB → Submit Expense → Scan tab
3. Verify no tooltip-related errors appear in the JS console
4. Go back online and verify the scan flow works normally

QA Steps

1. Open the app, navigate to + FAB → Submit Expense → Scan tab
2. Verify no SCAN_TEST_TOOLTIP appears on the scan screen
3. Verify the scan camera/upload view loads correctly
4. Navigate to New Chat and verify the contact list renders correctly
5. If the TestDrive feature is applicable, verify the SCAN_TEST_DRIVE_CONFIRMATION tooltip still displays
6. Verify Manager McTest contact is accessible when expected (beta-enabled user, not a member of any policy)
7. Submit an expense end-to-end and verify it completes without errors

Summary

Removes the SCAN_TEST_TOOLTIP, SCAN_TEST_TOOLTIP_MANAGER, and SCAN_TEST_CONFIRMATION product training tooltips from the Create Expense Scan flow. This is a cleanup of the old scan test tooltip feature while preserving the newer TestDrive feature.

What was removed:

• 3 tooltip configurations and their priority entries from TOOLTIPS.ts
• shouldRenderActionButtons type field and action buttons rendering in ProductTrainingContext
• setTestReceiptAndNavigate function and onLayout callback chain used to inject fake receipts
• Tooltip-based Manager McTest restriction logic in getRestrictedLogins
• Optimistic NVP dismissal update on expense submission in IOU actions
• getIsUserSubmittedExpenseOrScannedReceipt and isManagerMcTestReport helper functions
• EducationalTooltip wrapper from InviteMemberListItem
• scanTestTooltip translation keys from all 10 language files
• fake-receipt.png asset
• Related test fixtures and test case

What was preserved:

• SCAN_TEST_DRIVE_CONFIRMATION tooltip and TestDrive feature
• EmployeeTestDriveModal and setTestReceipt action
• Manager McTest backend flow and CONST.BETAS.NEWDOT_MANAGER_MCTEST
• All other product training tooltips

[MelvinBot]

Fixed the failing Changed files ESLint check: removed an unused date variable at src/libs/actions/IOU/index.ts:1689 (@typescript-eslint/no-unused-vars error).

The other warnings (pre-existing no-onyx-connect and react-hooks/immutability on viewfinderLayout) are not new to this PR.

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	92.30% <ø> (ø)
src/components/MoneyRequestConfirmationList.tsx	67.74% <100.00%> (-1.15%)	⬇️
src/components/ProductTrainingContext/TOOLTIPS.ts	37.50% <100.00%> (+10.22%)	⬆️
...onents/SelectionList/ListItem/ListItemRenderer.tsx	81.25% <ø> (ø)
...ListWithSections/BaseSelectionListWithSections.tsx	93.90% <ø> (ø)
src/libs/OptionsListUtils/index.ts	82.93% <100.00%> (-0.11%)	⬇️
src/libs/actions/IOU/index.ts	78.53% <ø> (-0.45%)	⬇️
src/pages/iou/request/IOURequestStartPage.tsx	72.41% <ø> (+3.29%)	⬆️
...s/iou/request/MoneyRequestParticipantsSelector.tsx	0.00% <ø> (ø)
...equestStepScan/components/DesktopWebUploadView.tsx	0.00% <ø> (ø)
... and 8 more
... and 121 files with indirect coverage changes

[ChavdaSachin]

@MelvinBot, please lay out the testing steps.

[MelvinBot]

Here are the testing steps for this PR:

Testing Steps

Prerequisites

• Use a test account that has the newDotManagerMcTest beta enabled and is not a member of any policy (to verify Manager McTest still works)

1. Verify SCAN_TEST_TOOLTIP is removed

1. Log in to the app (web or mobile)
2. Tap the + FAB → Submit Expense (or Create Expense)
3. Navigate to the Scan tab
4. Verify that no tooltip appears saying "Scan our test receipt to see how it works!" with "Try it out" / "No thanks" buttons
5. Confirm the scan camera/upload UI loads normally without any tooltip overlay

2. Verify TestDrive feature still works

1. Use an account eligible for TestDrive (beta-enabled, no policy membership)
2. Navigate through the onboarding flow that triggers the SCAN_TEST_DRIVE_CONFIRMATION tooltip
3. Verify the EmployeeTestDriveModal still appears and functions correctly
4. Confirm the test receipt flow via TestDrive (not the old tooltip) still works end-to-end

3. Verify Manager McTest still appears

1. Using the same eligible account (beta-enabled, not a member of any policy)
2. Go to a flow where you'd select a manager/recipient
3. Verify Manager McTest still appears in the contact list as expected
4. Confirm Manager McTest is not gated behind the removed tooltip logic

4. Verify InviteMemberListItem renders correctly

1. Navigate to a screen that shows a member selection list (e.g., invite members to a workspace, or select a recipient)
2. Verify list items render correctly without layout issues
3. Confirm no EducationalTooltip wrapper artifacts remain

5. Verify expense submission flow

1. Create and submit an expense through the normal flow (manual or scan)
2. Verify the submission completes without errors
3. Confirm no optimistic NVP dismissal errors appear in the console

6. Regression checks

1. Verify other product training tooltips (e.g., TestDrive) still function
2. Check that no console errors related to missing tooltip configs or translation keys appear

[ChavdaSachin]

@MelvinBot mark it ready for review

[MelvinBot]

🤖 PR has been marked as ready for review as requested by ChavdaSachin.

[melvin-bot]

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ChavdaSachin]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-15.at.6.18.39.PM.mov

[ChavdaSachin]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[ChavdaSachin]

@MelvinBot, could you check if any unused props/styles could be removed, please?

[MelvinBot]

I found 4 categories of unused artifacts that can be cleaned up:

1. Unused style variables — src/styles/variables.ts:332-333

• inviteMemberListItemTooltipShiftVertical and inviteMemberListItemTooltipShiftHorizontal have zero references in the codebase. They were only used by the removed EducationalTooltip in InviteMemberListItem.

2. Dead canShowProductTrainingTooltip prop chain — threaded through 5 files but no longer consumed by any list item component:

• src/pages/iou/request/MoneyRequestParticipantsSelector.tsx (passes canShowManagerMcTest)
• src/components/SelectionList/SelectionListWithSections/types.ts and BaseSelectionListWithSections.tsx
• src/components/SelectionList/ListItem/ListItemRenderer.tsx
• src/components/SelectionList/ListItem/types.ts (type definitions on ListItem and BaseListItemProps)

3. Unused type fields on InviteMemberListItemProps — src/components/SelectionList/ListItem/types.ts:406-411

• canShowProductTrainingTooltip, index, and sectionIndex are still defined but the component no longer destructures or uses them.

4. Unused nvpDismissedProductTraining parameter — src/libs/OptionsListUtils/index.ts:2420

• Declared in getValidOptions but never read in the function body (its only consumer was the old getRestrictedLogins signature). Removing it requires updating all callers (getSearchOptions, useSearchSelector), so this is a broader cleanup.

Items 1-3 are straightforward removals. Item 4 is a wider refactor since it touches callers throughout OptionsListUtils.

[ChavdaSachin]

@MelvinBot, that makes sense. Please perform the cleanup.

[MelvinBot]

Cleanup done — removed unused artifacts left over from the scan test tooltip removal:

1. Unused style variables — removed inviteMemberListItemTooltipShiftVertical and inviteMemberListItemTooltipShiftHorizontal from variables.ts
2. Dead canShowProductTrainingTooltip prop chain — removed from SelectionListWithSections, ListItemRenderer, MoneyRequestParticipantsSelector, and all related type definitions
3. Unused InviteMemberListItemProps fields — simplified to just UserListItemProps (removed canShowProductTrainingTooltip, index, sectionIndex that were never destructured)

Skipped item 4 (nvpDismissedProductTraining parameter cleanup) as it touches 10+ caller files across the codebase — better as a separate PR.

[ChavdaSachin]

@MelvinBot, please clean up use of nvpDismissedProductTraining too; it's not worth a separate PR.

[MelvinBot]

Cleaned up the unused nvpDismissedProductTraining parameter from getValidOptions and getSearchOptions in OptionsListUtils, along with all callers and tests (14 files). The parameter was passed through but never used in the function bodies.

[ChavdaSachin]

@MelvinBot, add tests to the PR description.

[ChavdaSachin]

LGTM! ✅

[melvin-bot]

We did not find an internal engineer to review this PR, trying to assign a random engineer to #87170 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

[MelvinBot]

🤖 Updated the PR description with proper numbered test steps, offline tests, and QA steps per the PR template.

[ChavdaSachin]

Ready for merge.
cc. @jamesdeanexpensify

[Copilot]

Pull request overview

Removes the legacy scan “test receipt” product-training tooltips and the associated fake-receipt injection flow from the Create Expense → Scan experience, while keeping the newer TestDrive tooltip/flow intact.

Changes:

• Deletes SCAN_TEST_TOOLTIP, SCAN_TEST_TOOLTIP_MANAGER, and SCAN_TEST_CONFIRMATION tooltip configs/priority entries and removes their UI/action-button rendering path.
• Removes the fake-receipt injection plumbing (setTestReceiptAndNavigate + onLayout callback chain) from the scan step.
• Simplifies option-building and selection list plumbing by removing tooltip-driven Manager McTest restriction logic and eliminating the nvpDismissedProductTraining argument from relevant option utilities and callers.

Reviewed changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/utils/TestHelper.ts	Removes legacy test helper for dismissed product training related to scan test tooltips.
tests/unit/useSearchSelectorTest.tsx	Updates mocked getValidOptions call expectations after signature change.
tests/unit/hooks/useAutocompleteSuggestions.test.ts	Updates test params after removing nvpDismissedProductTraining from hook inputs.
tests/unit/OptionsListUtilsTest.tsx	Updates many getValidOptions/getSearchOptions calls and removes scan-tooltip-specific assertions.
tests/ui/components/ProductTrainingContextProvider.tsx	Updates tooltip name usage/priorities to align with remaining tooltips.
tests/perf-test/OptionsListUtils.perf-test.ts	Updates perf tests for getSearchOptions/getValidOptions signature changes.
src/types/onyx/DismissedProductTraining.ts	Removes scan test tooltip keys from the dismissed-product-training Onyx type.
src/styles/variables.ts	Removes tooltip-shift variables used only by the old InviteMemberListItem educational tooltip.
src/pages/iou/request/step/IOURequestStepScan/types.ts	Removes onLayout prop used for the test receipt injection path.
src/pages/iou/request/step/IOURequestStepScan/index.tsx	Removes onLayout wiring and setTestReceiptAndNavigate usage from web scan step.
src/pages/iou/request/step/IOURequestStepScan/index.native.tsx	Removes native onLayout wrapper that provided the test receipt injection callback.
src/pages/iou/request/step/IOURequestStepScan/hooks/useReceiptScan.ts	Removes setTestReceiptAndNavigate and legacy fake receipt asset usage.
src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx	Removes onLayout prop/plumbing.
src/pages/iou/request/step/IOURequestStepScan/components/DesktopWebUploadView.tsx	Removes onLayout prop/plumbing related to test receipt injection.
src/pages/iou/request/MoneyRequestParticipantsSelector.tsx	Stops passing now-removed tooltip gating prop into selection list.
src/pages/iou/request/MoneyRequestAccountantSelector.tsx	Removes nvpDismissedProductTraining dependency from options building.
src/pages/iou/request/IOURequestStartPage.tsx	Removes scan test tooltip context usage and related tracking/dismissal logic.
src/pages/Share/ShareTab.tsx	Removes nvpDismissedProductTraining from search options construction.
src/pages/NewChatPage.tsx	Removes nvpDismissedProductTraining from options construction.
src/libs/actions/IOU/index.ts	Removes optimistic NVP dismissal merge tied to the removed scan test tooltip.
src/libs/OptionsListUtils/index.ts	Removes tooltip-driven Manager McTest restrictions and eliminates nvpDismissedProductTraining from APIs.
src/languages/zh-hans.ts	Removes scanTestTooltip translation keys.
src/languages/pt-BR.ts	Removes scanTestTooltip translation keys.
src/languages/pl.ts	Removes scanTestTooltip translation keys.
src/languages/nl.ts	Removes scanTestTooltip translation keys.
src/languages/ja.ts	Removes scanTestTooltip translation keys.
src/languages/it.ts	Removes scanTestTooltip translation keys.
src/languages/fr.ts	Removes scanTestTooltip translation keys.
src/languages/es.ts	Removes scanTestTooltip translation keys.
src/languages/en.ts	Removes scanTestTooltip translation keys.
src/languages/de.ts	Removes scanTestTooltip translation keys.
src/hooks/useSearchSelector.base.ts	Removes nvpDismissedProductTraining from option computation calls.
src/hooks/useAutocompleteSuggestions.ts	Removes nvpDismissedProductTraining from hook params and internal calls.
src/components/SelectionList/SelectionListWithSections/types.ts	Removes canShowProductTrainingTooltip prop from list API.
src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx	Removes forwarding of canShowProductTrainingTooltip.
src/components/SelectionList/ListItem/types.ts	Removes canShowProductTrainingTooltip and related InviteMember-specific props.
src/components/SelectionList/ListItem/ListItemRenderer.tsx	Removes forwarding of canShowProductTrainingTooltip.
src/components/SelectionList/ListItem/InviteMemberListItem.tsx	Removes EducationalTooltip wrapper and scan-tooltip-specific logic.
src/components/Search/SearchFiltersChatsSelector.tsx	Removes nvpDismissedProductTraining dependency from search options construction.
src/components/Search/SearchAutocompleteList.tsx	Removes nvpDismissedProductTraining from search options + autocomplete suggestions inputs.
src/components/Search/FilterDropdowns/InSelectPopup.tsx	Removes nvpDismissedProductTraining dependency from search options construction.
src/components/ProductTrainingContext/index.tsx	Removes action-button rendering path and scan-tooltip modal exceptions.
src/components/ProductTrainingContext/TOOLTIPS.ts	Removes scan test tooltip configurations and the action-buttons type field.
src/components/MoneyRequestConfirmationList.tsx	Removes legacy scan confirmation tooltip branch; keeps TestDrive confirmation tooltip.
src/CONST/index.ts	Removes scan test tooltip analytics event constants and tooltip name constants.
assets/images/fake-receipt.png	Removes legacy fake receipt image asset used by the old scan test tooltip flow.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.