Skip to content

deferreing onyx calls #87908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elirangoshen wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Draft

deferreing onyx calls #87908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
260c69a
deferreing onyx calls
elirangoshen Apr 14, 2026
f9186cb
pr fix
elirangoshen Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {ModalProvider} from './components/Modal/Global/ModalContext';
import NavigationBar from './components/NavigationBar';
import OnyxListItemProvider from './components/OnyxListItemProvider';
import PopoverContextProvider from './components/PopoverProvider';
import {ProductTrainingContextProvider} from './components/ProductTrainingContext';
import SafeArea from './components/SafeArea';
import ScrollOffsetContextProvider from './components/ScrollOffsetContextProvider';
import {SearchRouterContextProvider} from './components/Search/SearchRouter/SearchRouterContext';
Expand Down Expand Up @@ -125,7 +124,6 @@ function App() {
KeyboardStateProvider,
KeyboardDismissibleFlatListContextProvider,
SearchRouterContextProvider,
ProductTrainingContextProvider,
InputBlurContextProvider,
FullScreenBlockingViewContextProvider,
FullScreenLoaderContextProvider,
Expand Down
6 changes: 4 additions & 2 deletions src/components/ProductTrainingContext/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,13 @@ type ProductTrainingContextConfig = {
onShown?: () => void;
};

const ProductTrainingContext = createContext<ProductTrainingContextType>({
const defaultProductTrainingContext: ProductTrainingContextType = {
shouldRenderTooltip: () => false,
registerTooltip: () => {},
unregisterTooltip: () => {},
});
};

const ProductTrainingContext = createContext<ProductTrainingContextType>(defaultProductTrainingContext);

function ProductTrainingContextProvider({children}: ChildrenProps) {
const [isLoadingApp = true] = useOnyx(ONYXKEYS.IS_LOADING_APP);
Expand Down
2 changes: 2 additions & 0 deletions src/libs/Navigation/AppNavigator/AuthScreens.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import LockedAccountModalProvider from '@components/LockedAccountModalProvider';
import OpenAppFailureModal from '@components/OpenAppFailureModal';
import OptionsListContextProvider from '@components/OptionListContextProvider';
import PriorityModeController from '@components/PriorityModeController';
import {ProductTrainingContextProvider} from '@components/ProductTrainingContext';
import {SearchContextProvider} from '@components/Search/SearchContext';
import SearchRouterModal from '@components/Search/SearchRouter/SearchRouterModal';
import SupportalPermissionDeniedModalProvider from '@components/SupportalPermissionDeniedModalProvider';
Expand Down Expand Up @@ -157,6 +158,7 @@ function AuthScreens() {
OptionsListContextProvider,
SidebarOrderedReportsContextProvider,
SearchContextProvider,
ProductTrainingContextProvider,
LockedAccountModalProvider,
DelegateNoAccessModalProvider,
SupportalPermissionDeniedModalProvider,
Expand Down
Loading