refactor createChildReport to use isSelfTourViewed from useOnyx#87914
Open
dukenv0307 wants to merge 6 commits intoExpensify:mainfrom
Open
refactor createChildReport to use isSelfTourViewed from useOnyx#87914dukenv0307 wants to merge 6 commits intoExpensify:mainfrom
dukenv0307 wants to merge 6 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
Contributor
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
Contributor
Author
|
@DylanDylann It's ready for review |
Contributor
|
@codex review |
DylanDylann
reviewed
Apr 20, 2026
Comment on lines
+4662
to
+4701
| it('should pass isSelfTourViewed=true through to openReport when creating a new child report', async () => { | ||
| const PARENT_REPORT = createRandomReport(1, undefined); | ||
| const PARENT_REPORT_ACTION: OnyxTypes.ReportAction = { | ||
| ...createRandomReportAction(REPORT_ACTION_ID), | ||
| reportActionID: '1', | ||
| actorAccountID: TEST_USER_ACCOUNT_ID, | ||
| }; | ||
|
|
||
| await TestHelper.signInWithTestUser(TEST_USER_ACCOUNT_ID, TEST_USER_LOGIN); | ||
| await TestHelper.setPersonalDetails(TEST_USER_LOGIN, TEST_USER_ACCOUNT_ID); | ||
| Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${PARENT_REPORT_ID}`, PARENT_REPORT); | ||
| await waitForBatchedUpdates(); | ||
|
|
||
| Report.navigateToAndOpenChildReport(undefined, PARENT_REPORT_ACTION, PARENT_REPORT, TEST_USER_ACCOUNT_ID, INTRO_SELECTED, undefined, true); | ||
| await waitForBatchedUpdates(); | ||
|
|
||
| TestHelper.expectAPICommandToHaveBeenCalled(WRITE_COMMANDS.OPEN_REPORT, 1); | ||
| expect(Navigation.navigate).toHaveBeenCalledWith(ROUTES.REPORT_WITH_ID.getRoute(MOCK_NEW_THREAD_REPORT_ID)); | ||
| }); | ||
|
|
||
| it('should pass isSelfTourViewed=false through to openReport when creating a new child report', async () => { | ||
| const PARENT_REPORT = createRandomReport(1, undefined); | ||
| const PARENT_REPORT_ACTION: OnyxTypes.ReportAction = { | ||
| ...createRandomReportAction(REPORT_ACTION_ID), | ||
| reportActionID: '1', | ||
| actorAccountID: TEST_USER_ACCOUNT_ID, | ||
| }; | ||
|
|
||
| await TestHelper.signInWithTestUser(TEST_USER_ACCOUNT_ID, TEST_USER_LOGIN); | ||
| await TestHelper.setPersonalDetails(TEST_USER_LOGIN, TEST_USER_ACCOUNT_ID); | ||
| Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${PARENT_REPORT_ID}`, PARENT_REPORT); | ||
| await waitForBatchedUpdates(); | ||
|
|
||
| Report.navigateToAndOpenChildReport(undefined, PARENT_REPORT_ACTION, PARENT_REPORT, TEST_USER_ACCOUNT_ID, INTRO_SELECTED, undefined, false); | ||
| await waitForBatchedUpdates(); | ||
|
|
||
| TestHelper.expectAPICommandToHaveBeenCalled(WRITE_COMMANDS.OPEN_REPORT, 1); | ||
| expect(Navigation.navigate).toHaveBeenCalledWith(ROUTES.REPORT_WITH_ID.getRoute(MOCK_NEW_THREAD_REPORT_ID)); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
I am not sure what you want to verify in this test? Could you please clarify?
Contributor
There was a problem hiding this comment.
Currently, the test only verifies that OPEN_REPORT is called, regardless of the value of isSelfTourViewed.
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
Author
|
@DylanDylann It's ready for review again |
DylanDylann
reviewed
Apr 22, 2026
Comment on lines
+4931
to
+4951
| it('should pass isSelfTourViewed=true through to createChildReport when creating a new explain thread', async () => { | ||
| const PARENT_REPORT = createRandomReport(1, undefined); | ||
| const REPORT_ACTION: OnyxTypes.ReportAction = { | ||
| ...createRandomReportAction(REPORT_ACTION_ID), | ||
| reportActionID: '1', | ||
| actorAccountID: TEST_USER_ACCOUNT_ID, | ||
| }; | ||
|
|
||
| await TestHelper.signInWithTestUser(TEST_USER_ACCOUNT_ID, TEST_USER_LOGIN); | ||
| await TestHelper.setPersonalDetails(TEST_USER_LOGIN, TEST_USER_ACCOUNT_ID); | ||
| Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${PARENT_REPORT_ID}`, PARENT_REPORT); | ||
| await waitForBatchedUpdates(); | ||
|
|
||
| Report.explain(undefined, PARENT_REPORT, REPORT_ACTION, TestHelper.translateLocal, TEST_USER_ACCOUNT_ID, INTRO_SELECTED, undefined, true, CONST.DEFAULT_TIME_ZONE); | ||
| await waitForBatchedUpdates(); | ||
|
|
||
| TestHelper.expectAPICommandToHaveBeenCalled(WRITE_COMMANDS.OPEN_REPORT, 1); | ||
| expect(Navigation.navigate).toHaveBeenCalledWith(ROUTES.REPORT_WITH_ID.getRoute(MOCK_NEW_THREAD_REPORT_ID)); | ||
| }); | ||
|
|
||
| it('should pass isSelfTourViewed=false through to createChildReport when creating a new explain thread', async () => { |
Contributor
There was a problem hiding this comment.
This test is the same as the one above. Does that mean isSelfTourViewed doesn’t affect the output?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #66424
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-14.at.22.56.22.mov