[Payment due @ikevin127] Fix how we handle card names on search/reports#87922
[Payment due @ikevin127] Fix how we handle card names on search/reports#87922luacmartins merged 11 commits intomainfrom
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ikevin127 would you mind reviewing this one as well please? |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Yes, reviewing! |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-04-14.at.16.16.31.movSimulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-04-14.at.16.22.37.mov |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM
Only (3) NAB comments.
This PR successfully fixes the "Deleted Card" false positive issue by changing from a feed-existence check (which requires permissions users may not have) to a card-existence check (which uses data all users have access to). The refactoring is clean, type-safe, and maintains consistency between Search and Report views ✅
|
🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@JS00001 eslint is failing |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.60-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. This is a code-level bug fix that changes how card names are internally resolved in the search/reports UI — replacing the No help site changes are required. No user-facing features, workflows, terminology, or settings were added, removed, or renamed. The existing help site articles cover company card setup and management at a conceptual level and don't reference the internal card name resolution logic that was changed here. |
|
Hi @JS00001. How can we add the VCF card feed? |
|
@trjExpensify do you know how QA can add a vcf feed?? |
|
I'm pretty sure we can add one for you (per this SO) Do you have a test domain or workspace we can add it to? |
|
@JS00001 @heyjennahay I think this was still not validated, I wont blcok the deploy on it, but please follow up with testing it, thanks |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|
|
🤖 Payment issue created: #88400 |
|
I've validated these here: https://github.com/Expensify/Expensify/issues/623736 |
Explanation of Change
We previously showed 'Deleted Card' when the feed didn't exist, however, not all members have access to feed data. Lets use the same method as we do in
MoneyRequestReportViewFixed Issues
$ https://github.com/Expensify/Expensify/issues/623736
Tests
Add a VCF card feed with cards on it & transactions correlated with them
Navigate to the expenses page
Enable the
CardcolumnEnsure that
Deleted Cardis not shownNavigate to reports
Click on a report
Ensure that
Deleted Cardis not the name of the card in theCardcolumnOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Before:

After:
