Fix crash when attendee email is undefined in getPersonalDetailByEmail by marufsharifi · Pull Request #87955 · Expensify/App

marufsharifi · 2026-04-15T08:41:54Z

Explanation of Change

This change makes attendee data safer and more consistent when older expenses contain incomplete attendee info.

Before, some historical attendees could exist without an email, but parts of the app still assumed email was always present. That could crash report previews, break attendee selection, and create inconsistent recent-attendee data. Now we normalize attendee data into one canonical shape as soon as it enters app logic, preserve name-only attendees safely, and keep email lookups guarded as a fallback.

Fixed Issues

$ #86781
PROPOSAL: #86781 (comment)

Tests

Open any workspace expense report that contains at least one transaction.
Open that transaction so the expense details page is visible.
Open the browser DevTools console.
Run:
```
const tx = await window.transaction;
```

Run:

window.Onyx.merge(`transactions_${tx.transactionID}`, {
    comment: {
        ...tx.comment,
        attendees: [
            {
                displayName: 'Legacy attendee',
                avatarUrl: '',
            },
        ],
    },
});

Refresh the page, or navigate away and open the same expense report again.
Verify that the expense report loads successfully and no crash screen appears even though the attendee has no email field.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Not applicable.

Android: mWeb Chrome

Not applicable.

iOS: Native

Not applicable.

iOS: mWeb Safari

Not applicable.

MacOS: Chrome / Safari

Screen.Recording.2026-04-15.at.1.02.23.PM.mp4

…ailByEmail

melvin-bot · 2026-04-15T08:52:22Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28dd257f5d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

JmillsExpensify

LGTM

marufsharifi · 2026-04-16T07:10:13Z

@Krishna2323 I have addressed all the feedbacks and lint errors, could you please take another look. thanks

codecov · 2026-04-16T07:10:57Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/AttendeeUtils.ts	`55.55% <100.00%> (+15.55%)`	⬆️
src/libs/MergeTransactionUtils.ts	`78.60% <100.00%> (+0.18%)`	⬆️
src/libs/OptionsListUtils/index.ts	`82.72% <ø> (ø)`
src/libs/PersonalDetailsUtils.ts	`84.33% <100.00%> (+0.19%)`	⬆️
src/libs/TransactionUtils/index.ts	`83.37% <100.00%> (ø)`
src/libs/actions/IOU/UpdateMoneyRequest.ts	`61.18% <100.00%> (ø)`
...pages/iou/request/MoneyRequestAttendeeSelector.tsx	`0.00% <0.00%> (ø)`
... and 27 files with indirect coverage changes

Krishna2323 · 2026-04-19T18:10:19Z

+                    return getSplitAuthor(tr, splits);
+                }
+
+                return att.email ? getPersonalDetailByEmail(att.email)?.accountID : undefined;


getPersonalDetailByEmail already handles undefined email now. The att.email ? check is redundant.

Krishna2323 · 2026-04-19T18:16:43Z

        // If the transaction is a split, then attendees are not present as a property so we need to use a helper function.
        ?.flatMap<number | undefined>((tr) =>
-            tr.comment?.attendees?.map?.((att) => (tr.comment?.source === CONST.IOU.TYPE.SPLIT ? getSplitAuthor(tr, splits) : getPersonalDetailByEmail(att.email)?.accountID)),
+            normalizeAttendees(tr.comment?.attendees).map((att) => {


The normalizeAttendees call here is redundant since getPersonalDetailByEmail already handles undefined email. We can simplify this back to the original one-liner and remove the normalizeAttendees import from this file.

Krishna2323 · 2026-04-19T18:26:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-04-19.23-54-07.mp4

Krishna2323 · 2026-04-19T18:29:20Z

@marufsharifi left a few minor comments—otherwise LGTM.

Krishna2323 · 2026-04-21T23:05:00Z

@codex review

chatgpt-codex-connector · 2026-04-21T23:21:36Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Krishna2323

LGTM!

chuckdries

LGTM!

github-actions · 2026-04-21T23:36:47Z

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-21T23:40:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87955.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3ef40f2-cbc9c0e-849f1420ff68a2052e0984a54f05223990685749/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3ef40f2-cbc9c0e-9a8e132c52b69eea4087bcd14e7a0d46d06b82f7/index.html

Web 🕸️
https://87955.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T23:42:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: prevent crash when attendee email is undefined in getPersonalDet…

28dd257

…ailByEmail

melvin-bot Bot assigned marufsharifi Apr 15, 2026

marufsharifi marked this pull request as ready for review April 15, 2026 08:52

marufsharifi requested review from a team as code owners April 15, 2026 08:52

melvin-bot Bot requested review from JmillsExpensify and Krishna2323 and removed request for a team April 15, 2026 08:52

chatgpt-codex-connector Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread src/libs/AttendeeUtils.ts Outdated

marufsharifi added 5 commits April 15, 2026 18:07

Merge branch 'main' into fix/handle-undefined-attendee-email

fe550d3

fix: preserve login-only attendees and align optional email types

9bbb739

fix eslint type error

152d92d

Merge branch 'main' into fix/handle-undefined-attendee-email

3747bee

fix: handle optional attendee email

83b6ad3

JmillsExpensify previously approved these changes Apr 15, 2026

View reviewed changes

fix lint

c5b95ad

marufsharifi dismissed JmillsExpensify’s stale review via c5b95ad April 16, 2026 07:02

marufsharifi added 3 commits April 16, 2026 15:38

test: add coverage for optional attendee email flows

7c55821

fix prettier

0de4bd8

Merge branch 'main' into fix/handle-undefined-attendee-email

4048a15

Krishna2323 reviewed Apr 19, 2026

View reviewed changes

marufsharifi added 2 commits April 21, 2026 10:44

Merge branch 'main' into fix/handle-undefined-attendee-email

ad14a16

refactor: simplify attendee email handling in getReportPreviewSenderID

5c91b6e

Krishna2323 approved these changes Apr 21, 2026

View reviewed changes

melvin-bot Bot requested a review from chuckdries April 21, 2026 23:22

chuckdries approved these changes Apr 21, 2026

View reviewed changes

chuckdries merged commit 3ef40f2 into Expensify:main Apr 21, 2026
33 checks passed

Conversation

marufsharifi commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

marufsharifi commented Apr 16, 2026

Uh oh!

codecov Bot commented Apr 16, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Apr 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Apr 19, 2026

Uh oh!

Krishna2323 commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marufsharifi commented Apr 15, 2026 •

edited

Loading

codecov Bot commented Apr 16, 2026 •

edited by github-actions Bot

Loading