Add 'Apply Cash Back to My Expensify Bill' toggle to card settings by allgandalf · Pull Request #87956 · Expensify/App

allgandalf · 2026-04-15T09:26:49Z

Explanation of Change

Adds the "Apply Cash Back to My Expensify Bill" toggle to the workspace Expensify Card settings page. This toggle exists in Expensify Classic but was missing from NewDot.

The toggle allows workspace admins to choose whether their Expensify Card cash back is applied toward their Expensify bill or sent to their settlement account. It defaults to enabled (matching Classic behavior).

Visibility constraints (matching Classic):

Only shown for US card programs (not UK/EU)
Hidden for invoiced subscription customers

Related PRs (must be merged together for the feature to work):

Auth: https://github.com/Expensify/Auth/pull/21079
Web-Expensify: https://github.com/Expensify/Web-Expensify/pull/52123

Fixed Issues

$ #77925

Tests

Navigate to a workspace with an Expensify Card enabled (US program)
Go to Settings > Workspaces > [workspace] > Expensify Card > Settings
Verify the "Apply cash back to my Expensify bill" toggle appears below settlement frequency
Verify the toggle defaults to ON
Toggle it OFF, verify optimistic UI update (toggle turns off immediately)
Refresh the page, verify the setting persisted
Toggle it back ON, verify it updates
Verify the toggle is hidden when viewing a workspace with a UK/EU Expensify Card feed
Verify the toggle is hidden when the account is on an invoicing subscription

Verify that no errors appear in the JS console

Offline tests

Turn off network
Toggle the cashback setting
Verify the toggle updates optimistically
Turn network back on
Verify the setting syncs correctly

QA Steps

Log into a workspace with US Expensify Cards on staging
Navigate to Workspace > Expensify Card > Settings
Verify "Apply cash back to my Expensify bill" toggle is visible
Toggle it off and on, verify it persists across page refreshes
For a workspace with UK/EU cards, verify the toggle does NOT appear
For an invoiced customer, verify the toggle does NOT appear

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-15T09:26:56Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-04-15T09:26:57Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3309561d34

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

allgandalf · 2026-04-20T07:40:29Z

@JS00001 assigning you here since pull bearer assigned you in the Auth PR https://github.com/Expensify/Auth/pull/21079

codecov · 2026-04-20T07:49:18Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/API/types.ts	`100.00% <ø> (ø)`
...kspace/expensifyCard/WorkspaceCardSettingsPage.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/Card.ts	`0.00% <0.00%> (ø)`
... and 408 files with indirect coverage changes

allgandalf · 2026-04-20T08:00:24Z

+            applyCashbackToBill: 'Apply cash back to my Expensify bill',
+            applyCashbackToBillDescription: 'Cash back from the Expensify Card will be used towards payment for your Expensify bill.',


asking copy confirmation on slack https://expensify.slack.com/archives/C07NMDKEFMH/p1776671920436959?thread_ts=1776114531.642309&cid=C07NMDKEFMH

JS00001 · 2026-04-20T12:47:59Z

@@ -32,6 +36,11 @@ function WorkspaceCardSettingsPage({route}: WorkspaceCardSettingsPageProps) {
    const [bankAccountList] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST);
    const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${defaultFundID}`);


It seems like we are using the expensify card settings NVP here, but I dont think we are in the auth PR

yeah we write to DOMAIN_MEMBER in Auth, but getFullExpensifyCardsSettingsForOnyx reads that value and injects it into the PRIVATE_EXPENSIFYCARD_SETTINGS response. so the frontend reads from PRIVATE_EXPENSIFY_CARD_SETTINGS Onyx key and the value is always the current DOMAIN_MEMBER state, kept in sync by the backend

JS00001 · 2026-04-20T12:48:25Z

@@ -0,0 +1,6 @@
+type ToggleCardCashbackToBillParams = {
+    workspaceAccountID: number;


Lets make this the domain account ID

Suggested change

workspaceAccountID: number;

domainAccountID: number;

keeping workspaceAccountID to match the existing UpdateCardSettlementFrequencyParams pattern in the same file. the Web-E handler accepts both policyAccountID and workspaceAccountID (same as UpdateCardSettlementFrequency) before passing as domainAccountID to Auth

shawnborton · 2026-04-20T15:13:45Z

Let us know when there are screenshots/videos to review.

allgandalf · 2026-04-21T04:25:32Z

will let you know, we need to deploy auth and Web-E first so put this in draft

allgandalf added 6 commits April 15, 2026 14:44

Add shouldApplyCashbackToBill field to ExpensifyCardSettingsBase type

8138110

Create ToggleCardCashbackToBillParams API parameter type

8648e3b

Register TOGGLE_CARD_CASHBACK_TO_BILL write command

104faba

Add toggleCashbackToBill action function

090e40e

Add cashback-to-bill translations for en and es

fb6801e

Add cashback-to-bill toggle to workspace card settings page

3309561

allgandalf requested review from a team as code owners April 15, 2026 09:26

melvin-bot Bot assigned allgandalf Apr 15, 2026

melvin-bot Bot requested review from ZhenjaHorbach and flaviadefaria April 15, 2026 09:26

melvin-bot Bot removed the request for review from a team April 15, 2026 09:26

allgandalf removed request for ZhenjaHorbach and flaviadefaria April 15, 2026 09:27

allgandalf marked this pull request as draft April 15, 2026 09:27

github-actions Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread src/libs/actions/Card.ts

chatgpt-codex-connector Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread src/languages/en.ts Outdated

allgandalf added 2 commits April 20, 2026 13:04

Fix curly quote syntax error in en.ts translations

00dbe09

Add pendingFields to toggleCashbackToBill to drive OfflineWithFeedback

7725780

allgandalf requested a review from JS00001 April 20, 2026 07:40

allgandalf added 5 commits April 20, 2026 13:20

Add cashback toggle translations for de

1db74a4

Add cashback toggle translations for fr

7cee725

Add cashback toggle translations for it

cd66006

Add cashback toggle translations for ja

e60af3f

Add cashback toggle translations for nl

1198b6d

allgandalf added 3 commits April 20, 2026 13:21

Add cashback toggle translations for pl

929c840

Add cashback toggle translations for pt-BR

121c2ae

Add cashback toggle translations for zh-hans

2f25c7c

allgandalf commented Apr 20, 2026

View reviewed changes

JS00001 requested changes Apr 20, 2026

View reviewed changes

allgandalf requested a review from JS00001 April 21, 2026 12:49

		applyCashbackToBill: 'Apply cash back to my Expensify bill',
		applyCashbackToBillDescription: 'Cash back from the Expensify Card will be used towards payment for your Expensify bill.',

		@@ -32,6 +36,11 @@ function WorkspaceCardSettingsPage({route}: WorkspaceCardSettingsPageProps) {
		const [bankAccountList] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST);
		const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${defaultFundID}`);

		@@ -0,0 +1,6 @@
		type ToggleCardCashbackToBillParams = {
		workspaceAccountID: number;

Conversation

allgandalf commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 15, 2026

Uh oh!

melvin-bot Bot commented Apr 15, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

allgandalf commented Apr 20, 2026

Uh oh!

codecov Bot commented Apr 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

allgandalf Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

allgandalf Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

allgandalf Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Apr 20, 2026

Uh oh!

allgandalf commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

allgandalf commented Apr 15, 2026 •

edited

Loading

codecov Bot commented Apr 20, 2026 •

edited by github-actions Bot

Loading