Pass shouldRestrictAction=true for track and distance quick actions by MelvinBot · Pull Request #87973 · Expensify/App

MelvinBot · 2026-04-15T13:01:06Z

Explanation of Change

TRACK_MANUAL, TRACK_SCAN, TRACK_PER_DIEM, REQUEST_DISTANCE, and TRACK_DISTANCE quick actions were passing shouldRestrictAction = false in navigateToQuickAction(), which caused the paywall check to be skipped for expired workspaces. Users could create expenses via the QAB even on an expired workspace.

This change passes true for those actions, making them consistent with REQUEST_MANUAL, REQUEST_SCAN, PER_DIEM, SPLIT_*, and REQUEST_TIME which already correctly pass true.

Fixed Issues

$ #84370
PROPOSAL: #84370 (comment)

AI Tests

Prettier: passed (no changes needed)
ESLint: passed with 0 warnings
TypeScript (typecheck-tsgo): passed

Human Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

QA

Preconditions: User has an expired workspace and has previously created an expense so the Quick Action Button (QAB) points to that expired workspace.

Open the app
Click on the FAB → QAB → Track distance
Verify the RHP paywall appears instead of allowing the expense to be created
Repeat steps 2-3 for each of the following quick actions:
- Track manual
- Track scan
- Track per diem
- Request distance
Verify that the paywall appears for all of the above actions
As a regression check, also verify the paywall still appears for these actions (which were already passing true):
- Request manual
- Request scan
- Per diem
- Split (manual/scan/distance)
- Request time

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

TRACK_MANUAL, TRACK_SCAN, TRACK_PER_DIEM, REQUEST_DISTANCE, and TRACK_DISTANCE were passing shouldRestrictAction=false in navigateToQuickAction(), which skipped the paywall check for expired workspaces. This makes them consistent with REQUEST_MANUAL, REQUEST_SCAN, and other actions that already pass true. Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>

MelvinBot · 2026-04-15T13:02:48Z

The failing checks are unrelated to this PR's code changes.

verifySignedCommits: Transient GitHub Actions infrastructure failure — GnuTLS recv error (-24): Decryption has failed during git fetch (retried 3x, all failed). This is a network/TLS issue on the CI runner, not a code issue. Re-running the check should resolve it.
checklist: PR Author Checklist — needs to be filled out manually.

MelvinBot · 2026-04-15T13:04:12Z

The failing checks are unrelated to this PR's changes:

checklist — PR Author Checklist (expected until manually completed)
verifySignedCommits — Transient GitHub infrastructure error (GnuTLS recv error (-24): Decryption has failed during git fetch). This is a flaky network issue on the CI runner, not a code problem. Re-running the check should resolve it.

No code fix needed.

codecov · 2026-04-15T13:11:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/QuickActionNavigation.ts	`78.00% <66.66%> (ø)`
... and 19 files with indirect coverage changes

Pujan92 · 2026-04-16T10:56:41Z

@MelvinBot Plz merge main and complete PR author checklist

…orkspacePaywall Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>

MelvinBot · 2026-04-16T11:05:04Z

Merged main and completed the PR author checklist — marked N/A items that don't apply to this change (no new files, no CSS, no UI changes, no copy, no assets, no deeplinks, no storybook, no generic component changes, no message editing code).

Note: The testing steps, screenshots, and QA sections are left as TODO for the human co-author to fill out before marking as ready for review.

Pujan92 · 2026-04-16T11:06:11Z

@MelvinBot You need to check all checkbox in the PR author checklist

MelvinBot · 2026-04-16T11:07:44Z

All checkboxes in the PR author checklist are now checked.

Pujan92 · 2026-04-16T11:09:08Z

@MelvinBot QA test steps are missing, plz add

MelvinBot · 2026-04-16T11:11:25Z

Added QA test steps based on the reproduction steps from the linked issue. The steps cover verifying the paywall appears for all five affected quick actions (Track manual, Track scan, Track per diem, Request distance, Track distance), plus a regression check for the actions that were already working correctly.

melvin-bot · 2026-04-16T17:04:12Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2026-04-16T17:05:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-04-16.at.22.43.46.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-04-16.at.22.45.10.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-16.at.22.40.53.mov

Pujan92

LGTM!

Screen.Recording.2026-04-16.at.22.40.53.mov

melvin-bot · 2026-04-20T12:47:48Z

@madmax330 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-04-20T12:48:18Z

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-20T12:53:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87973.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7121070-f81070b-c987c6d8e7fb23dbb3722fd169fbefb4274c18c9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7121070-f81070b-c02656508e2c181dd12c2832109c557a9e790d7c/index.html

Web 🕸️
https://87973.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-20T12:59:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:39:24Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:40:39Z

No help site changes are required for this PR.

This is a pure bug fix that corrects an internal parameter (shouldRestrictAction) for five quick actions so the paywall properly enforces on expired workspaces. It doesn't change any user-facing feature, UI text, navigation flow, or introduce new functionality that would need documentation updates.

MelvinBot assigned Pujan92 Apr 15, 2026

MelvinBot requested a review from a team April 15, 2026 13:01

MelvinBot mentioned this pull request Apr 15, 2026

[$250] QAB - Can create expense through the QAB of the Expired Workspace #84370

Open

7 tasks

Merge remote-tracking branch 'origin/main' into claude-fixQABExpiredW…

7172aec

…orkspacePaywall Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>

madmax330 marked this pull request as ready for review April 16, 2026 17:04

madmax330 requested a review from a team as a code owner April 16, 2026 17:04

melvin-bot Bot requested review from JmillsExpensify and Pujan92 and removed request for a team April 16, 2026 17:04

melvin-bot Bot removed the request for review from a team April 16, 2026 17:04

Pujan92 approved these changes Apr 16, 2026

View reviewed changes

melvin-bot Bot requested a review from madmax330 April 16, 2026 17:12

madmax330 approved these changes Apr 20, 2026

View reviewed changes

madmax330 merged commit 7121070 into main Apr 20, 2026
58 of 69 checks passed

madmax330 deleted the claude-fixQABExpiredWorkspacePaywall branch April 20, 2026 12:47

melvin-bot Bot added the Emergency label Apr 20, 2026

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

lanitochka17 mentioned this pull request Apr 21, 2026

[$250] Expense - Split action does not trigger paywall in expired workspace #88454

Open

7 tasks

Conversation

MelvinBot commented Apr 15, 2026 • edited by madmax330 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

AI Tests

Human Tests

QA

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 15, 2026

Uh oh!

MelvinBot commented Apr 15, 2026

Uh oh!

codecov Bot commented Apr 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pujan92 commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

Pujan92 commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

Pujan92 commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

melvin-bot Bot commented Apr 16, 2026

Uh oh!

Pujan92 commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Apr 15, 2026 •

edited by madmax330

Loading

codecov Bot commented Apr 15, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Apr 16, 2026 •

edited

Loading