Part 4: Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/SubscriptionUtils by hungvu193 · Pull Request #87992 · Expensify/App

hungvu193 · 2026-04-15T16:19:04Z

Explanation of Change

Part 4: Remove usages of Onyx.connect for ONYXKEYS.SESSION by making the functions "pure":

shouldRestrictUserBillableActions

Fixed Issues

$ #66442
PROPOSAL: N/A

Tests

Same as QA Tests.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test 1:

You are a member of a workspace that the owner ended their free trial.
Try to submit an expense.
Verify you're navigated to Restricted page.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-04-12.at.23.15.26.mov

Screen.Recording.2026-04-12.at.23.20.49.mov

codecov · 2026-04-15T16:40:38Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../FloatingCameraButton/BaseFloatingCameraButton.tsx	`80.00% <ø> (+3.52%)`	⬆️
.../SearchPageHeader/SearchActionsBarCreateButton.tsx	`93.87% <100.00%> (ø)`
src/hooks/useReceiptScanDrop.tsx	`30.43% <ø> (ø)`
src/libs/SubscriptionUtils.ts	`81.18% <100.00%> (+0.10%)`	⬆️
src/components/SettlementButton/index.tsx	`84.75% <0.00%> (ø)`
...nents/Navigation/QuickCreationActionsBar/index.tsx	`0.00% <0.00%> (ø)`
...tReportView/SearchMoneyRequestReportEmptyState.tsx	`3.33% <0.00%> (ø)`
... and 122 files with indirect coverage changes

hungvu193 · 2026-04-15T16:48:17Z

@MelvinBot assign yourself to this PR. Revert the change from MobileExpensify

melvin-bot · 2026-04-15T16:49:50Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-04-15T16:50:43Z

Assigned myself and reverted the Mobile-Expensify submodule change back to main (d10f585).

hungvu193 · 2026-04-15T16:58:54Z

@MelvinBot Revert the change from MobileExpensify

MelvinBot · 2026-04-15T17:07:21Z

Reverted the Mobile-Expensify submodule change back to main (d10f585).

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

MelvinBot · 2026-04-15T17:10:51Z

Pushed the Mobile-Expensify submodule revert to the PR branch.

…into fix-664420-part41

hungvu193 · 2026-04-16T06:31:24Z

@MelvinBot merge main and resolve the conflicts

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

MelvinBot · 2026-04-16T06:37:14Z

Merged main and resolved the conflict in src/components/Navigation/QuickCreationActionsBar/index.tsx.

The conflict was between the PR's change (passing session?.accountID to make shouldRestrictUserBillableActions pure) and main's addition of the amountOwed parameter. Resolved by keeping both: amountOwed from main and session?.accountID from this PR.

flaviadefaria · 2026-04-16T08:22:02Z

No new product considerations - removing my assignment and unsubscribing.

shubham1206agra · 2026-04-16T12:26:35Z

    // We should restrict the workspace's owner actions if it's past its grace period end date and it's owing some amount.
    if (
-        isPolicyOwner(policy, deprecatedCurrentUserAccountID) &&
+        isPolicyOwner(policy, currentUserAccountID ?? deprecatedCurrentUserAccountID) &&


Suggested change

isPolicyOwner(policy, currentUserAccountID ?? deprecatedCurrentUserAccountID) &&

isPolicyOwner(policy, currentUserAccountID) &&

shubham1206agra · 2026-04-16T12:35:56Z

+                                userBillingGracePeriodEnds,
+                                amountOwed,
+                                undefined,
+                                session?.accountID,


@hungvu193 Try to use useCurrentUserPersonalDetails so you don't need to fill fallback value everywhere.

shubham1206agra · 2026-04-16T15:39:26Z

@hungvu193 Please fix tests

shubham1206agra · 2026-04-16T15:40:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-04-16.at.9.09.40.PM.mov

hungvu193 · 2026-04-16T16:26:15Z

Done 😀

OSBotify · 2026-04-20T18:37:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-20T19:14:36Z

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-20T19:22:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87992.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f56ac50-41d2bf8-dc55e45ae01d62a8912f9749944951b544162463/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f56ac50-41d2bf8-333e880300b7d5ddda2f98c78bfd91ca2709bb3a/index.html

Web 🕸️
https://87992.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T11:39:37Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:40:39Z

No help site changes are required for this PR. This is an internal refactor that changes how shouldRestrictUserBillableActions receives the current user's account ID (passed as a parameter instead of read from Onyx). No user-facing behavior, feature names, or UI elements are affected.

update shouldRestrictUserBillableActions usages part 1

fb20e1c

melvin-bot Bot assigned hungvu193 Apr 15, 2026

hungvu193 changed the title ~~update shouldRestrictUserBillableActions usages part 1~~ Part 4: Remove usages of Onyx.connect for ONYXKEYS.SESSION Apr 15, 2026

fix conflicts

9acac8a

hungvu193 marked this pull request as ready for review April 15, 2026 16:49

MelvinBot assigned OSBotify Apr 15, 2026

hungvu193 requested review from a team as code owners April 15, 2026 16:49

melvin-bot Bot requested review from flaviadefaria and shubham1206agra April 15, 2026 16:49

melvin-bot Bot removed request for a team April 15, 2026 16:49

github-actions Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread src/components/MoneyRequestReportView/SearchMoneyRequestReportEmptyState.tsx Outdated

shubham1206agra reviewed Apr 15, 2026

View reviewed changes

Comment thread Mobile-Expensify

Revert Mobile-Expensify submodule change

66b56b5

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

hungvu193 added 2 commits April 16, 2026 00:11

revert submodule

d50ea04

Merge branch 'fix-664420-part41' of https://github.com/hungvu193/App …

7849246

…into fix-664420-part41

Merge main and resolve conflicts in QuickCreationActionsBar

673d2b2

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

hungvu193 requested a review from shubham1206agra April 16, 2026 06:40

flaviadefaria removed their request for review April 16, 2026 08:21

shubham1206agra reviewed Apr 16, 2026

View reviewed changes

Comment thread src/libs/SubscriptionUtils.ts Outdated

shubham1206agra reviewed Apr 16, 2026

View reviewed changes

hungvu193 added 2 commits April 16, 2026 22:04

update optional params

257f731

address comments

11c7b2c

fix tests

90892a9

shubham1206agra approved these changes Apr 17, 2026

View reviewed changes

melvin-bot Bot requested a review from dangrous April 17, 2026 16:03

hungvu193 changed the title ~~Part 4: Remove usages of Onyx.connect for ONYXKEYS.SESSION~~ Part 4: Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/SubscriptionUtils Apr 18, 2026

dangrous approved these changes Apr 20, 2026

View reviewed changes

dangrous merged commit f56ac50 into Expensify:main Apr 20, 2026
35 checks passed

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

	isPolicyOwner(policy, currentUserAccountID ?? deprecatedCurrentUserAccountID) &&
	isPolicyOwner(policy, currentUserAccountID) &&

Conversation

hungvu193 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Test 1:

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hungvu193 commented Apr 15, 2026

Uh oh!

melvin-bot Bot commented Apr 15, 2026

Uh oh!

MelvinBot commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Apr 15, 2026

Uh oh!

MelvinBot commented Apr 15, 2026

Uh oh!

MelvinBot commented Apr 15, 2026

Uh oh!

hungvu193 commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

flaviadefaria commented Apr 16, 2026

Uh oh!

Uh oh!

shubham1206agra Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Apr 16, 2026

Uh oh!

shubham1206agra commented Apr 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Apr 16, 2026

Uh oh!

Uh oh!

OSBotify commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hungvu193 commented Apr 15, 2026 •

edited

Loading

codecov Bot commented Apr 15, 2026 •

edited by github-actions Bot

Loading