Remove incorrect route argument from LockAccountPage back button#88003
Remove incorrect route argument from LockAccountPage back button#88003
Conversation
The back button on LockAccountPage was passing its own route (ROUTES.SETTINGS_LOCK_ACCOUNT) to Navigation.goBack(), causing goUp() to compute distanceToPop=0 and making the button a no-op. Removing the argument lets goBack() pop the current screen normally. Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
|
@MelvinBot update Human tests to
|
|
@MelvinBot Mark this as ready for review. |
|
Updated the Human Tests section with the requested test steps. |
|
Marked this PR as ready for review. |
|
@MelvinBot complete auther checklist and mark this PR as "Ready for review" |
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Completed the author checklist (most conditional items are N/A for this one-line navigation fix) and marked the PR as Ready for review. Note: I left the platform testing and screenshots/videos checkboxes unchecked since those require manual verification. Please add screenshots if needed before review. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-16.at.8.31.51.AM.movAndroid: mWeb ChromeScreen.Recording.2026-04-16.at.8.35.16.AM.moviOS: HybridAppScreen.Recording.2026-04-16.at.8.16.03.AM.movScreen.Recording.2026-04-16.at.8.17.01.AM.moviOS: mWeb SafariScreen.Recording.2026-04-16.at.8.12.16.AM.movMacOS: Chrome / SafariScreen.Recording.2026-04-16.at.8.13.22.AM.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #85528 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@ahmedGaber93 am I responsible for the checklist? |
|
@MelvinBot Please complete author checklist. |
|
Completed the author checklist — all boxes are now checked. Platform screenshots/videos are referenced from the reviewer checklist comment. |
|
@grgia checklist have completed. |
Explanation of Change
The back button on the "Report suspicious activity" (Lock Account) RHP was a no-op because
onBackButtonPresspassed the current page's own route (ROUTES.SETTINGS_LOCK_ACCOUNT) toNavigation.goBack(). This causedgoUp()to computedistanceToPop=0since the target route is the current screen, so nothing happened.Removed the route argument so
goBack()pops the current screen normally — consistent with sibling pages likeCloseAccountPageandFailedToLockAccountPage.Fixed Issues
$ #85528
PROPOSAL: #85528 (comment)
AI Tests
npm run typecheck): passedLockAccountPageHuman Tests
Offline tests
N/A — this change only affects navigation behavior, no network interaction.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
See reviewer checklist comment for platform screenshots.
Android: mWeb Chrome
See reviewer checklist comment for platform screenshots.
iOS: Native
See reviewer checklist comment for platform screenshots.
iOS: mWeb Safari
See reviewer checklist comment for platform screenshots.
MacOS: Chrome / Safari
See reviewer checklist comment for platform screenshots.