[Payment due @Ollyws] Display recurrence count for de-duplicated sync failure messages#88008
Merged
tylerkaraszewski merged 6 commits intomainfrom Apr 21, 2026
Merged
Conversation
melvin-bot
Bot
requested review from
a team,
heyjennahay and
ikevin127
and removed request for
a team
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| takeControl: `Kontrolle übernommen`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `Beim Synchronisieren mit ${label}${errorMessage ? ` ("${errorMessage}")` : ''} ist ein Problem aufgetreten. Bitte behebe das Problem in den <a href="${workspaceAccountingLink}">Workspace-Einstellungen</a>.`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not German. The same untranslated English string is copy-pasted across 7 non-English locale files (de, fr, it, ja, nl, pl, pt-BR, zh-hans), which is both a duplication issue and an i18n defect. Only es.ts has an actual translation.
Provide a proper German translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `Dieses Problem ist ${count} Mal aufgetreten.`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| takeControl: `a pris le contrôle`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `un problème est survenu lors de la synchronisation avec ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Veuillez corriger le problème dans les <a href="${workspaceAccountingLink}">paramètres de l’espace de travail</a>.`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not French. This is the same untranslated English string duplicated across all non-English locale files (except es.ts).
Provide a proper French translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `Ce problème s'est reproduit ${count} fois.`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| takeControl: `ha preso il controllo`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `si è verificato un problema di sincronizzazione con ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Risolvi il problema nelle <a href="${workspaceAccountingLink}">impostazioni dello spazio di lavoro</a>.`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not Italian. This is the same untranslated English string duplicated across all non-English locale files (except es.ts).
Provide a proper Italian translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `Questo problema si è verificato ${count} volte.`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| takeControl: `管理権限を取得しました`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `${label}${errorMessage ? ` ("${errorMessage}")` : ''}との同期中に問題が発生しました。<a href="${workspaceAccountingLink}">ワークスペース設定</a>で問題を解決してください。`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not Japanese. This is the same untranslated English string duplicated across all non-English locale files (except es.ts).
Provide a proper Japanese translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `この問題は${count}回発生しています。`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| takeControl: `nam de controle over`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `er trad een probleem op bij het synchroniseren met ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Los het probleem op in de <a href="${workspaceAccountingLink}">werkruimte-instellingen</a>.`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not Dutch. This is the same untranslated English string duplicated across all non-English locale files (except es.ts).
Provide a proper Dutch translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `Dit probleem is ${count} keer opgetreden.`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| takeControl: `przejął kontrolę`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `wystąpił problem z synchronizacją z ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Napraw problem w <a href="${workspaceAccountingLink}">ustawieniach przestrzeni roboczej</a>.`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not Polish. This is the same untranslated English string duplicated across all non-English locale files (except es.ts).
Provide a proper Polish translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `Ten problem wystąpił ${count} razy.`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| takeControl: `assumiu o controle`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `houve um problema ao sincronizar com ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Corrija o problema em <a href="${workspaceAccountingLink}">configurações do workspace</a>.`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not Portuguese. This is the same untranslated English string duplicated across all non-English locale files (except es.ts).
Provide a proper Portuguese translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `Este problema ocorreu ${count} vezes.`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| takeControl: `取得控制权`, | ||
| integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) => | ||
| `与 ${label}${errorMessage ? ` ("${errorMessage}")` : ''} 同步时出现问题。请在<a href="${workspaceAccountingLink}">工作区设置</a>中修复此问题。`, | ||
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The string This issue has recurred ${count} times. is in English, not Chinese. This is the same untranslated English string duplicated across all non-English locale files (except es.ts).
Provide a proper Simplified Chinese translation, e.g.:
integrationSyncFailedRecurrence: ({count}: {count: number}) => `此问题已重复发生${count}次。`,Reviewed at: c00f999 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 50276d50..dc9d0097 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7860,7 +7860,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
takeControl: `Kontrolle übernommen`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`Beim Synchronisieren mit ${label}${errorMessage ? ` ("${errorMessage}")` : ''} ist ein Problem aufgetreten. Bitte behebe das Problem in den <a href="${workspaceAccountingLink}">Workspace-Einstellungen</a>.`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `Dieses Problem ist ${count} Mal erneut aufgetreten.`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `(${count} Mal wiederholt.)`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`Die Verbindung für ${feedName} ist unterbrochen. Um Kartenimporte wiederherzustellen, <a href='${workspaceCompanyCardRoute}'>melden Sie sich bei Ihrer Bank an</a>.`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index d34bb439..c19a70d4 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7882,7 +7882,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
takeControl: `a pris le contrôle`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`un problème est survenu lors de la synchronisation avec ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Veuillez corriger le problème dans les <a href="${workspaceAccountingLink}">paramètres de l’espace de travail</a>.`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `Ce problème s’est reproduit ${count} fois.`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `(Répété ${count} fois.)`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`La connexion ${feedName} est interrompue. Pour rétablir l’importation des cartes, <a href=’${workspaceCompanyCardRoute}’>connectez-vous à votre banque</a>.`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 3e328956..cbb1185b 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7848,7 +7848,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
takeControl: `ha preso il controllo`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`si è verificato un problema di sincronizzazione con ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Risolvi il problema nelle <a href="${workspaceAccountingLink}">impostazioni dello spazio di lavoro</a>.`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `Questo problema si è ripresentato ${count} volte.`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `(Ripetuto ${count} volte.)`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`La connessione ${feedName} è interrotta. Per ripristinare le importazioni della carta, <a href='${workspaceCompanyCardRoute}'>accedi alla tua banca</a>.`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index e7e39243..015c2100 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7751,7 +7751,7 @@ ${reportName}
takeControl: `管理権限を取得しました`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`${label}${errorMessage ? ` ("${errorMessage}")` : ''}との同期中に問題が発生しました。<a href="${workspaceAccountingLink}">ワークスペース設定</a>で問題を解決してください。`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `この問題は${count}回再発しています。`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `（${count} 回繰り返し）`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`${feedName} との接続が切断されています。カードの取引明細の取込を再開するには、<a href='${workspaceCompanyCardRoute}'>銀行にログイン</a>してください。`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 93507e83..c2605d61 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7825,7 +7825,7 @@ Voeg meer bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
takeControl: `nam de controle over`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`er trad een probleem op bij het synchroniseren met ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Los het probleem op in de <a href="${workspaceAccountingLink}">werkruimte-instellingen</a>.`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `Dit probleem is ${count} keer opnieuw opgetreden.`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `(${count} keer herhaald.)`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`De verbinding met ${feedName} is verbroken. <a href='${workspaceCompanyCardRoute}'>Log in bij je bank</a> om kaartimports te herstellen.`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 1577ef1c..e50e27a6 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7814,7 +7814,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
takeControl: `przejął kontrolę`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`wystąpił problem z synchronizacją z ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Napraw problem w <a href="${workspaceAccountingLink}">ustawieniach przestrzeni roboczej</a>.`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `Ten problem wystąpił ponownie ${count} razy.`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `(Powtórzono ${count} razy.)`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`Połączenie ${feedName} jest przerwane. Aby przywrócić importy kart, <a href='${workspaceCompanyCardRoute}'>zaloguj się do swojego banku</a>.`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 18723ab1..e55ed3f6 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7818,7 +7818,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
takeControl: `assumiu o controle`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`houve um problema ao sincronizar com ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Corrija o problema em <a href="${workspaceAccountingLink}">configurações do workspace</a>.`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `Este problema voltou a ocorrer ${count} vezes.`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `(Repetido ${count} vezes.)`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`A conexão de ${feedName} está interrompida. Para restaurar as importações do cartão, <a href='${workspaceCompanyCardRoute}'>faça login no seu banco</a>.`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b5f41e98..e375a520 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7614,7 +7614,7 @@ ${reportName}
takeControl: `取得控制权`,
integrationSyncFailed: (label: string, errorMessage: string, workspaceAccountingLink?: string) =>
`与 ${label}${errorMessage ? ` ("${errorMessage}")` : ''} 同步时出现问题。请在<a href="${workspaceAccountingLink}">工作区设置</a>中修复此问题。`,
- integrationSyncFailedRecurrence: ({count}: {count: number}) => `此问题已重复出现 ${count} 次。`,
+ integrationSyncFailedRecurrence: ({count}: {count: number}) => `（重复 ${count} 次。）`,
companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) =>
`${feedName} 连接已中断。要恢复银行卡导入，请<a href='${workspaceCompanyCardRoute}'>登录您的银行账户</a>。`,
plaidBalanceFailure: ({maskedAccountNumber, walletRoute}: {maskedAccountNumber: string; walletRoute: string}) =>
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c00f9998e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| integrationSyncFailedRecurrence: ({count}: {count: number}) => `This issue has recurred ${count} times.`, | ||
| companyCardConnectionBroken: ({feedName, workspaceCompanyCardRoute}: {feedName: string; workspaceCompanyCardRoute: string}) => | ||
| `La connexion ${feedName} est interrompue. Pour rétablir l’importation des cartes, <a href='${workspaceCompanyCardRoute}'>connectez-vous à votre banque</a>.`, | ||
| `La connexion ${feedName} est interrompue. Pour rétablir l’importation des cartes, <a href=’${workspaceCompanyCardRoute}’>connectez-vous à votre banque</a>.`, |
There was a problem hiding this comment.
The French companyCardConnectionBroken translation now uses typographic apostrophes around href (’...’) instead of valid HTML quote characters. In notifications rendered from this string, the anchor can fail to parse as a link, so French users may not be able to click through to reconnect their bank from this message.
Useful? React with 👍 / 👎.
Add client-side rendering of recurrenceCount for INTEGRATIONSYNCFAILED messages that have been de-duplicated by the server. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yuwenmemon
force-pushed
the
yuwen-dedup-sync-failed-app
branch
from
bbe5b35 to
ad8a897
Compare
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
@yuwenmemon Who's supposed to review this ? I'm seeing @Ollyws assigned, happy to have them review 🙌 |
Contributor
Author
|
Yeah dunno why it assigned two... Will remove your assignment @ikevin127 |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
|
Ollyws
approved these changes
Apr 16, 2026
Contributor
Ollyws
left a comment
Ollyws
left a comment
There was a problem hiding this comment.
I don't know if the backend changes are live yet, so I just hard coded the recurrenceCount but LGTM.
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
changed the title
|
🎯 @Ollyws, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
Contributor
|
Tests are failing |
# Conflicts: # tests/unit/ReportActionsUtilsTest.ts
Contributor
Author
|
@tylerkaraszewski updated! |
tylerkaraszewski
approved these changes
Apr 21, 2026
Contributor
|
🚧 @tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When the Auth service de-duplicates consecutive identical INTEGRATIONSYNCFAILED messages in #admins rooms, it adds a
recurrenceCountfield to the message'soriginalMessage. This PR updates the App frontend to read that field and display "This issue has recurred X times." after the sync failure text.Changes:
recurrenceCounttoOriginalMessageIntegrationSyncFailedtypegetIntegrationSyncFailedMessageto append recurrence text whenrecurrenceCount > 1integrationSyncFailedRecurrencetranslation key to all language filesFixed Issues
For https://github.com/Expensify/Expensify/issues/624351
Tests
Offline tests
N/A - this is server-rendered content, offline behavior unchanged.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Tested locally — message updates in place with recurrence count text after de-duplication.