Fix RHP dismissal during report navigation with key-based wrapper

[leshniak]

When navigating between expense reports via prev/next arrows, the RHP closes unexpectedly because setParams updates reportIDFromRoute immediately but Onyx briefly returns undefined for the new report. The dismissal effect misinterprets this transient state as a report deletion and calls dismissModal.

Explanation of Change

Split SearchMoneyRequestReportPage into an outer wrapper that passes key={reportIDFromRoute} and an inner SearchMoneyRequestReportPageContent. Each arrow click remounts the inner component with a clean slate — all hooks and refs reset naturally without manual tracking.

The dismissal effect uses a mount-scoped hasEverHadReportRef — it starts false on each remount, so the transient undefined during Onyx hydration cannot trigger dismissal. Once the report loads, the ref becomes true. If the report is later deleted (becomes undefined), we dismiss — preserving the existing behavior. The isMoneyRequestReport check from the original code was dropped since this page only renders money request reports.

Also adds a hydration guard in shouldShowAccessErrorPage: when reportIDFromRoute is set but reportID hasn't resolved from Onyx yet and report actions haven't loaded, the error page is suppressed — showing the skeleton loader instead of "Hmm... it's not there". The guard is bounded by hasLoadedReportActionsForAccessError so genuinely non-existent reports still show the error once loading completes.

This also removes both usePrevious calls from the component, making it React Compiler compliant.

Fixed Issues

$ #87784
PROPOSAL:

Tests

1. Navigate to Search → Reports (expense reports)
2. Click on any expense report row to open it in the RHP
3. Verify the RHP opens and shows the report content (not "Hmm... it's not there")
4. Use the prev/next navigation arrows to navigate between reports
5. Verify the RHP stays open and shows a skeleton loader briefly during transitions
6. Verify no unexpected dismissal occurs during rapid arrow clicking

• Verify that no errors appear in the JS console

Offline tests

1. Open an expense report via search arrows while online
2. Go offline
3. Use prev/next arrows to navigate between cached reports
4. Verify navigation works for reports already loaded in Onyx
5. Verify no crash or unexpected dismissal occurs

QA Steps

Same as Tests above.

• Verify that no errors appear in the JS console

[melvin-bot]

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@aimane-chnaif @Julesssss One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/Search/SearchMoneyRequestReportPage.tsx	0.00% <0.00%> (ø)
... and 266 files with indirect coverage changes