Fix undeleted action width by luacmartins · Pull Request #88165 · Expensify/App

luacmartins · 2026-04-16T23:36:52Z

Explanation of Change

Makes the action column wider if the Undelete option is present so that the text is not truncated (in English at least)

Fixed Issues

$ #88040

Tests

Pre-condition: a deleted and a non-deleted transaction

Navigate to Reports
Update the Status filter to show all statuses
Update the Columns filter to show the Action column
Verify that the Undelete is not truncated
Update the Status column to not show the deleted transaction
Verify that the action column width gets smaller

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-04-16.at.6.01.41.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-17T00:16:34Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-17T00:17:11Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a30b264635

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

luacmartins · 2026-04-17T00:42:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4fc630e83c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-17T00:53:32Z

                                    shouldShowSorting
                                    groupBy={validGroupBy}
                                    isExpenseReportView={isExpenseReportType}
+                                    isActionColumnWide={isTask || hasDeletedTransaction}


Limit wide action column to transaction/task views

This now passes isTask || hasDeletedTransaction for all search types, so EXPENSE_REPORT screens can enable a wide action header whenever any transaction in the snapshot is deleted. Report rows do not consume this flag (their action cell still uses the default narrow width in ExpenseReportListItemRow), so the table header/action column widths can drift out of alignment and trigger unnecessary horizontal scrolling in Reports view even though report rows never expose UNDELETE actions.

Useful? React with 👍 / 👎.

EXPENSE_REPORT screens will not enable wide action header as deleted transactions are not considered. Ignoring this comment LGTM.

rojiphil · 2026-04-17T13:10:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

88165-android-hybrid-001.mp4

Android: mWeb Chrome

88165-web-chrome-001.mp4

iOS: HybridApp

88165-ios-hybrid-001.mp4

iOS: mWeb Safari

88165-mweb-safari-001.mp4

MacOS: Chrome / Safari

88165-web-chrome-001.mp4

rojiphil

@luacmartins LGTM. Changes work well. Just that unit tests need a fix.

@marcaaron Over to you.
Thanks.

trjExpensify

clean-up for deleted expenses 👍

marcaaron · 2026-04-17T19:03:46Z

Conflicts

luacmartins · 2026-04-17T19:14:17Z

Updated

codecov · 2026-04-17T20:09:37Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...archList/ListItem/TransactionGroupListExpanded.tsx	`66.66% <100.00%> (+0.59%)`	⬆️
...h/SearchList/ListItem/TransactionGroupListItem.tsx	`71.91% <ø> (ø)`
...Search/SearchList/ListItem/TransactionListItem.tsx	`0.00% <ø> (ø)`
src/components/Search/SearchList/index.tsx	`44.06% <ø> (ø)`
src/components/TransactionItemRow/index.tsx	`89.28% <100.00%> (+0.09%)`	⬆️
src/components/Search/SearchTableHeader.tsx	`5.33% <0.00%> (-0.08%)`	⬇️
src/components/Search/index.tsx	`0.93% <0.00%> (-0.01%)`	⬇️
src/libs/SearchUIUtils.ts	`63.49% <81.81%> (-0.12%)`	⬇️
... and 10 files with indirect coverage changes

luacmartins · 2026-04-17T20:13:01Z

@marcaaron ready for you again

OSBotify · 2026-04-17T23:46:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:42:10Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:43:31Z

No help site changes are required for this PR.

This PR is a purely visual fix that adjusts the width of the "Action" column in search results when the "Undelete" option is present to prevent text truncation. It does not introduce, rename, or change any user-facing feature, workflow, or terminology — it only modifies internal column sizing logic. The existing help site articles do not document search table column widths or layout details at this level.

Fix undeleted action width

d5ace71

luacmartins self-assigned this Apr 16, 2026

luacmartins added 4 commits April 16, 2026 18:01

refactor code

8d3d63b

rm tuple

9e81c8d

udpate section getter

e37cae1

fix prettier

a30b264

luacmartins marked this pull request as ready for review April 17, 2026 00:16

luacmartins requested review from a team as code owners April 17, 2026 00:16

melvin-bot Bot requested review from rojiphil and removed request for a team April 17, 2026 00:16

luacmartins requested a review from a team April 17, 2026 00:16

melvin-bot Bot requested review from trjExpensify and removed request for a team April 17, 2026 00:16

This was referenced Apr 17, 2026

Reports - Undelete button is truncated #88040

Open

Fix undeleted action width #88080

Closed

melvin-bot Bot requested review from marcaaron and removed request for a team April 17, 2026 00:17

github-actions Bot reviewed Apr 17, 2026

View reviewed changes

Comment thread src/libs/SearchUIUtils.ts

chatgpt-codex-connector Bot reviewed Apr 17, 2026

View reviewed changes

Comment thread src/components/TransactionItemRow/index.tsx

Comment thread src/components/Search/index.tsx

fix typecheck

4fc630e

rm unused var

d147eeb

chatgpt-codex-connector Bot reviewed Apr 17, 2026

View reviewed changes

rojiphil approved these changes Apr 17, 2026

View reviewed changes

trjExpensify previously approved these changes Apr 17, 2026

View reviewed changes

fix tests

b5aa3cc

luacmartins dismissed trjExpensify’s stale review via b5aa3cc April 17, 2026 19:04

luacmartins added 2 commits April 17, 2026 13:07

resolve conflicts

d34892b

resolve conflicts

9ced795

fix test

6b90bc3

marcaaron approved these changes Apr 17, 2026

View reviewed changes

marcaaron merged commit a7b0b95 into main Apr 17, 2026
32 checks passed

marcaaron deleted the cmartins-fixButtonWidth branch April 17, 2026 23:37

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

Conversation

luacmartins commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 17, 2026

Uh oh!

melvin-bot Bot commented Apr 17, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

luacmartins commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

rojiphil Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

rojiphil commented Apr 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron commented Apr 17, 2026

Uh oh!

luacmartins commented Apr 17, 2026

Uh oh!

codecov Bot commented Apr 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

luacmartins commented Apr 17, 2026

Uh oh!

Uh oh!

OSBotify commented Apr 17, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

luacmartins commented Apr 16, 2026 •

edited

Loading

codecov Bot commented Apr 17, 2026 •

edited by github-actions Bot

Loading