Do not show workspace deleted offline in the feed selector#88188
Do not show workspace deleted offline in the feed selector#88188koko57 wants to merge 2 commits intoExpensify:mainfrom
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d21925951
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| onyxMethod: Onyx.METHOD.SET, | ||
| key: `${ONYXKEYS.COLLECTION.LAST_SELECTED_FEED}${policyID}`, | ||
| value: null, |
There was a problem hiding this comment.
Restore feed selection keys on delete failure
This optimistic update clears LAST_SELECTED_FEED and LAST_SELECTED_EXPENSIFY_CARD_FEED, but the failure path does not restore either key. When DELETE_WORKSPACE fails (for example, after an offline attempt later rejected by the server), the workspace stays active but its remembered card feed selections are lost, so users are forced onto defaults in subsequent card flows. Please capture and reapply the previous values in failureData, as is done for the other optimistic Onyx mutations.
Useful? React with 👍 / 👎.
|
@madmax330 @linhvovan29546 Also, as it's my last day working on the Expensify project, please ping @MrMuzyk if the PR will still be in review next week - @MrMuzyk will take it over or will help find someone to take over. Thank you for the collaboration, it's been a pleasure working with you! Wishing you all the best ❤️ |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Explanation of Change
Fixed Issues
$ #88126
PROPOSAL:
Tests
Prerequisites: a workspace (A) with Expensify Card enabled with bank account connected and verified
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2026-04-17.at.11.17.04.mp4
iOS: Native
Screen.Recording.2026-04-17.at.11.10.52.mp4
iOS: mWeb Safari
Screen.Recording.2026-04-17.at.11.06.46.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-04-17.at.10.33.42.mp4