[Landscape] Fix popup content is not fully shown

[bernhardoj]

Explanation of Change

Fixed Issues

$ #88051
PROPOSAL:

Tests

Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. Open Spend
2. Press Settings button > Sort by
3. Verify you can see the header, sort order, sort by list, and the buttons

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fa7f24bbb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	92.30% <ø> (ø)
...mponents/Search/FilterDropdowns/DropdownButton.tsx	84.61% <100.00%> (+0.61%)	⬆️
...mponents/Search/FilterDropdowns/TextInputPopup.tsx	0.00% <ø> (ø)
...rc/components/Search/FilterDropdowns/BasePopup.tsx	0.00% <0.00%> (ø)
...ents/Search/FilterDropdowns/GroupCurrencyPopup.tsx	0.00% <0.00%> (ø)
.../Search/SearchPageHeader/DatePickerFilterPopup.tsx	0.00% <0.00%> (ø)
...stReportView/MoneyRequestReportTransactionList.tsx	0.00% <0.00%> (ø)
...s/Search/FilterDropdowns/DateSelectPopup/index.tsx	0.00% <0.00%> (ø)
...omponents/Search/FilterDropdowns/InSelectPopup.tsx	2.85% <0.00%> (-0.09%)	⬇️
...mponents/Search/FilterDropdowns/SortOrderPopup.tsx	0.00% <0.00%> (ø)
... and 8 more
... and 111 files with indirect coverage changes

[bernhardoj]

I'll explain the solution, but before that, we need to understand the root cause first.
We have 2 styles: getSelectionListPopoverHeight and getCommonSelectionListPopoverHeight. They have different uses.

getSelectionListPopoverHeight
We use this to set the height of the selection list.
Example:

<BasePopup>
  <View style={styles.getSelectionListPopoverHeight()}>
    <SelectionList />
  </View>
</BasePopup>

getCommonSelectionListPopoverHeight
We use this to set the height of the whole popup (list, header, footer, search input).

<BasePopup style={styles.getCommonSelectionListPopoverHeight()}>
  <SelectionList />
</BasePopup>

The first problem here is that we don't take into account the sort order menu item height, so when used in landscape mode, there isn't enough space for the sort order menu.

App/src/components/Search/FilterDropdowns/SortByPopup.tsx

Lines 57 to 78 in bfba460

	<>
	<MenuItemWithTopDescription
	shouldShowRightIcon
	description={translate('search.display.sortOrder')}
	title={sortOrder ? translate(`search.filters.sortOrder.${sortOrder}`) : undefined}
	onPress={onSortOrderPress}
	/>
	<View style={styles.dividerLine} />
	<SingleSelectPopup
	style={styles.p0}
	items={sortableColumns}
	value={sortBy}
	closeOverlay={closeOverlay}
	defaultValue={sortableColumns.at(0)?.value}
	onChange={(item) => {
	if (!item) {
	return;
	}
	onSortChange(item.value);
	}}
	/>
	</>

But even if we take into account the sort order menu item height, the issue still won't be fully fixed. We can notice this height issue in other popups that use the same getSelectionListPopoverHeight. The second issue lies in getSelectionListPopoverHeight logic.

Here is how it works:
It will return the minimum value between ESTIMATED_LIST_HEIGHT, MAX_HEIGHT, and windowHeight * 0.9.

App/src/styles/index.ts

Line 6305 in bfba460

const height = Math.min(ESTIMATED_LIST_HEIGHT, MAX_HEIGHT, windowHeight * 0.9);

ESTIMATED_LIST_HEIGHT:
estimated height of the list, simple

MAX_HEIGHT:
maximum height of the list. We have POPOVER_DROPDOWN_MAX_HEIGHT that defines the maximum height of the whole popup (for landscape, we get 75% of the window height). So, to get the maximum height of the list, we subtract it from other elements in the popover (header, footer, search input).

windowHeight * 0.9:
another max height, but this caps the list to be 90% of the window height.

On the web, with mobile view, if we reduce the height to be really small, then the list will take the 90% of the height, and the footer will be hidden because of not enough space.

MAX_HEIGHT calculation doesn't take into account when the popup has a header with a back button instead of a label/title. So, when there is a mismatch, the list will take too much space, and the header or buttons could be cut.

---

This is why I decided to use getCommonSelectionListPopoverHeight approach. If the height is windowHeight * 0.9, then it's the whole popover height. The list will take up as much space as available. The header/title and buttons will. never be cut.

[bernhardoj]

Created this for a non-selection list popup.

[bernhardoj]

On a small screen, a bottom-docked modal will be used, and by default, it have a 16px vertical padding applied. That's why we had !isSmallScreenWidth && styles.pv4 everywhere. I disabled this, so we can apply the padding to all screens, and we don't need to conditionally account for the modal vertical padding anymore in getSelectionListPopoverHeight.

[aimane-chnaif]

@JS00001 can you please generate adhoc build?

[github-actions]

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88191.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f5452b7-08b118a-43f34e286f96e608f87216e842a0d11c7a88c9c1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f5452b7-08b118a-baaedaf7ff6a2fd5dc1a5f82542e0e43c9541b84/index.html

Web 🕸️
https://88191.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[aimane-chnaif]

We should consider bottom safe area.

portrait mode:

landscape mode: Should be scrollable to see Status, Amount

[bernhardoj]

@aimane-chnaif fixed