Hide three-dot menu for locked bank accounts in Wallet by MelvinBot · Pull Request #88254 · Expensify/App

MelvinBot · 2026-04-18T14:18:29Z

Explanation of Change

When a bank account is in a locked state, the three-dot menu still renders in the Wallet page. Since there are no useful actions for a locked account (most conditional items are false), the menu shows empty space with only a delete option. Additionally, tapping the icon triggers both navigation to Concierge chat AND the popup menu simultaneously.

This fix adds !isInLockedState to the showThreeDotsMenu condition in PaymentMethodListItem.tsx, which prevents the three-dot icon from rendering entirely for locked bank accounts. This matches the expected behavior described in the issue: "No more menu appears when tapping the three-dot icon on a locked account."

Fixed Issues

$ #87731
PROPOSAL: #87731 (comment)

Tests

Log in with an account that has a locked bank account in the Wallet (e.g. applausetester+lockedba@applause.expensifail.com)
Navigate to Account Settings > Wallet
Observe the locked bank account entry — verify the three-dot menu icon is not displayed
Tap on the locked bank account entry — verify you are redirected to Concierge chat without any popup menu appearing
If you also have a non-locked bank account, verify that its three-dot menu icon is still displayed and functional

Verify that no errors appear in the JS console

Offline tests

Disconnect from the network
Navigate to Account Settings > Wallet
Verify the locked bank account still renders correctly without the three-dot menu icon (the UI should not change when going offline)

QA Steps

Log in with an account that has a locked bank account in the Wallet
Navigate to Account Settings > Wallet
Verify the three-dot menu icon is not shown on the locked bank account
Tap the locked bank account — verify navigation to Concierge chat works without a popup menu appearing
Verify non-locked bank accounts still show the three-dot menu and it works correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

When a bank account is in a locked state, the three-dot menu should not appear since there are no useful menu actions available. This prevents the empty popup from showing and the dual navigation/popup behavior. Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>

codecov · 2026-04-18T14:26:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/pages/settings/Wallet/PaymentMethodListItem.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

ShridharGoel · 2026-04-18T15:55:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-18.at.9.23.21.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-04-18.at.9.24.28.PM.mov

iOS: HybridApp

Screen.Recording.2026-04-18.at.9.13.12.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-04-18.at.9.15.31.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-18.at.8.32.31.PM.mov

ShridharGoel · 2026-04-18T15:55:18Z

@MelvinBot mark this as ready for review

MelvinBot · 2026-04-18T15:56:32Z

🤖 I attempted to mark this PR as ready for review, but I don't have the required permissions to do so in this environment. You can mark it as ready yourself by clicking the "Ready for review" button at the bottom of the PR, or by running:

gh pr ready 88254 --repo Expensify/App

ShridharGoel · 2026-04-18T16:08:21Z

@MelvinBot try again

MelvinBot · 2026-04-18T16:09:44Z

🤖 Done! This PR has been marked as ready for review.

melvin-bot · 2026-04-18T16:09:46Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-18T16:10:17Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2026-04-18T16:11:34Z

@MelvinBot Add manual tests in the desc and complete the checklist

MelvinBot · 2026-04-18T16:13:53Z

Updated the PR description with manual tests, offline tests, QA steps, and completed the applicable checklist items.

Note: The following checklist items are left unchecked as they require manual verification by the co-author:

Screenshots/videos on all platforms
Platform-specific test runs (Android Native, Android mWeb, iOS Native, iOS mWeb, MacOS)
High Traffic account testing

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1462178ae2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-18T16:17:18Z

    const isInSetupState = isAccountInSetupState(item);
    const isInLockedState = isBusinessBankAccountLocked(item);
-    const showThreeDotsMenu = item.shouldShowThreeDotsMenu !== false && !!threeDotsMenuItems;
+    const showThreeDotsMenu = item.shouldShowThreeDotsMenu !== false && !!threeDotsMenuItems && !isInLockedState;


Hide right-side three-dot icon for locked accounts

Setting showThreeDotsMenu to false for locked accounts stops rendering ThreeDotsMenu, but it also activates the fallback path in MenuItem (shouldShowRightIcon={!showThreeDotsMenu && item.shouldShowRightIcon}) while iconRight is still the three-dot asset for wallet payment methods. In WalletPage this means locked bank accounts still show a three-dot icon, just without the menu behavior, which preserves the misleading affordance this change is trying to remove.

Useful? React with 👍 / 👎.

@flaviadefaria Can you confirm if we want to show the three dots icon or not? We have prevented the menu from showing, should we remove the icon as well?

MelvinBot assigned ShridharGoel Apr 18, 2026

MelvinBot requested a review from a team April 18, 2026 14:18

MelvinBot mentioned this pull request Apr 18, 2026

[$250] Wallet - More menu appears over concierge chat when tapping on three-dot icon #87731

Open

7 tasks

MelvinBot marked this pull request as ready for review April 18, 2026 16:09

MelvinBot requested a review from a team as a code owner April 18, 2026 16:09

melvin-bot bot requested review from ShridharGoel and flaviadefaria and removed request for a team April 18, 2026 16:09

melvin-bot bot requested review from a team and AndrewGable and removed request for a team April 18, 2026 16:09

ShridharGoel approved these changes Apr 18, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Apr 18, 2026

View reviewed changes

Conversation

MelvinBot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 18, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ShridharGoel commented Apr 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented Apr 18, 2026

Uh oh!

MelvinBot commented Apr 18, 2026

Uh oh!

ShridharGoel commented Apr 18, 2026

Uh oh!

MelvinBot commented Apr 18, 2026

Uh oh!

melvin-bot bot commented Apr 18, 2026

Uh oh!

melvin-bot bot commented Apr 18, 2026

Uh oh!

ShridharGoel commented Apr 18, 2026

Uh oh!

MelvinBot commented Apr 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Apr 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MelvinBot commented Apr 18, 2026 •

edited

Loading

codecov bot commented Apr 18, 2026 •

edited by github-actions bot

Loading