Fix ReferralProgramCTA text tap not responsive by MelvinBot · Pull Request #88274 · Expensify/App

MelvinBot · 2026-04-18T23:23:45Z

Explanation of Change

The ReferralProgramCTA component uses an absolutely-positioned PressableWithoutFeedback as the tap target, but the View wrapping RenderHTML sits on top and its Text nodes absorb touch events. This means taps landing directly on the text glyphs never reach the pressable underneath, requiring users to tap above/below the text or tap multiple times.

Adding pointerEvents="none" to the aria-hidden View wrapping RenderHTML lets all touch events pass through to the underlying CTA pressable, making the text responsive on first tap.

Fixed Issues

$ #86510
PROPOSAL: #86510 (comment)

Tests

Open the app with a new account.
Click the global FAB (+) → Start chat.
Verify that the "Start a chat, refer a friend" text and the area above or below it are clickable and open the Referral page.
On a wide screen browser, hover over the "Start a chat, refer a friend" text and its surrounding area, and verify the cursor changes to a pointer.
Click the (×) icon and verify that the button is hidden.

The clickable area should be like this

Offline tests

Open the app with a new account.
Click the global FAB (+) → Start chat.
Verify that the "Start a chat, refer a friend" text and the area above or below it are clickable and open the Referral page.
On a wide screen browser, hover over the "Start a chat, refer a friend" text and its surrounding area, and verify the cursor changes to a pointer.
Click the (×) icon and verify that the button is hidden.

The clickable area should be like this

QA Steps

Open the app with a new account.
Click the global FAB (+) → Start chat.
Verify that the "Start a chat, refer a friend" text and the area above or below it are clickable and open the Referral page.
On a wide screen browser, hover over the "Start a chat, refer a friend" text and its surrounding area, and verify the cursor changes to a pointer.
Click the (×) icon and verify that the button is hidden.

The clickable area should be like this

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The aria-hidden View wrapping RenderHTML absorbs touch events, preventing taps on the text from reaching the underlying absolute- positioned PressableWithoutFeedback. Adding pointerEvents="none" lets all touches pass through to the CTA pressable underneath. Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>

ahmedGaber93 · 2026-04-23T00:24:37Z

@MelvinBot update Tests & Offline tests & QA steps to be:

Open the app with a new account.
Click the global FAB (+) → Start chat.
Verify that the “Start a chat, refer a friend” text and the area above or below it are clickable and open the Referral page.
On a wide screen browser, hover over the “Start a chat, refer a friend” text and its surrounding area, and verify the cursor changes to a pointer.
Click the (×) icon and verify that the button is hidden.

The clickable area should be like this

MelvinBot · 2026-04-23T00:28:11Z

Updated the Tests, Offline tests, and QA Steps sections as requested.

ahmedGaber93 · 2026-04-23T00:30:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-23.at.1.47.58.AM.mov

Android: mWeb Chrome

Screen.Recording.2026-04-23.at.1.49.26.AM.mov

iOS: HybridApp

Screen.Recording.2026-04-23.at.1.52.50.AM.mov

iOS: mWeb Safari

Screen.Recording.2026-04-23.at.1.55.47.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-23.at.1.43.10.AM.mov

ahmedGaber93 · 2026-04-23T00:31:49Z

@MelvinBot complete your checklist

MelvinBot · 2026-04-23T00:34:21Z

Completed the PR Author Checklist. Left unchecked the items that require manual human verification: offline network testing, high traffic account testing, screenshots/videos, platform testing, and console error verification.

MelvinBot · 2026-04-23T00:35:52Z

The only failing check is the PR Author Checklist (checklist). All code checks (ESLint, TypeScript, tests, builds, prettier, etc.) are passing.

This isn't a code issue — the checklist items in the PR description need to be checked off manually. Please update the PR body to complete the checklist items.

ahmedGaber93 · 2026-04-23T00:40:07Z

@MelvinBot please complete the author checklist, I already verified them.

MelvinBot · 2026-04-23T00:41:53Z

Completed the PR Author Checklist — all items are now checked.

ahmedGaber93 · 2026-04-23T00:42:43Z

@MelvinBot Mark this PR as ready for review.

MelvinBot · 2026-04-23T00:44:03Z

PR has been marked as ready for review.

melvin-bot · 2026-04-23T00:44:04Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-23T00:48:21Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #86510 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

github-actions · 2026-04-23T14:22:38Z

🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-23T14:32:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88274.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4daa1f0-52e5d87-709fecb27cd3f819222e449342171d6e0ca9ac17/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4daa1f0-52e5d87-6e5a28d662c88377a4489429d559506105c7dd58/index.html

Web 🕸️
https://88274.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-23T14:35:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-23T20:19:55Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.62-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot assigned ahmedGaber93 Apr 18, 2026

MelvinBot requested a review from a team April 18, 2026 23:23

MelvinBot mentioned this pull request Apr 18, 2026

[$250] Chat - Tapping 'Start a chat, refer a friend' text link is not responsive #86510

Open

7 tasks

MelvinBot marked this pull request as ready for review April 23, 2026 00:43

MelvinBot requested a review from a team as a code owner April 23, 2026 00:43

melvin-bot Bot requested a review from ahmedGaber93 April 23, 2026 00:44

melvin-bot Bot requested review from heyjennahay and removed request for a team April 23, 2026 00:44

ahmedGaber93 approved these changes Apr 23, 2026

View reviewed changes

melvin-bot Bot requested a review from amyevans April 23, 2026 00:48

amyevans approved these changes Apr 23, 2026

View reviewed changes

amyevans merged commit 4daa1f0 into main Apr 23, 2026
48 of 51 checks passed

amyevans deleted the claude-referralProgramCTATapFix branch April 23, 2026 14:22

OSBotify mentioned this pull request Apr 23, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

Conversation

MelvinBot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Apr 23, 2026

Uh oh!

MelvinBot commented Apr 23, 2026

Uh oh!

ahmedGaber93 commented Apr 23, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Apr 23, 2026

Uh oh!

MelvinBot commented Apr 23, 2026

Uh oh!

MelvinBot commented Apr 23, 2026

Uh oh!

ahmedGaber93 commented Apr 23, 2026

Uh oh!

MelvinBot commented Apr 23, 2026

Uh oh!

ahmedGaber93 commented Apr 23, 2026

Uh oh!

MelvinBot commented Apr 23, 2026

Uh oh!

melvin-bot Bot commented Apr 23, 2026

Uh oh!

melvin-bot Bot commented Apr 23, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Apr 18, 2026 •

edited

Loading