[Payment due @suneox] Add followup_clicked telemetry to resolveSuggestedFollowup by marcochavezf · Pull Request #88277 · Expensify/App

marcochavezf · 2026-04-19T01:01:30Z

Explanation of Change

Adds observability for the suggested-followup feature by emitting a followup_clicked telemetry event whenever resolveSuggestedFollowup() actually resolves a followup. The event flows through the existing Log.info pipeline → backend → VictoriaLogs, so no new infra is needed. The payload includes reportID, reportActionID, and hasPregeneratedResponse (true = instant path, false = LLM round-trip).

This pairs with the Web-E generation-side telemetry (separate issue) to give us a full CTR picture before flipping BetaManager::BETA_SUGGESTED_FOLLOWUPS to always-on.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/625673
PROPOSAL: N/A (internal issue — no external contributor proposal required)

Tests

This change is observability-only (a Log.info call). It has no user-visible behavior, so manual tests focus on verifying the log payload is emitted.

Open any Concierge chat where a suggested-followup chip is rendered under a Concierge response
Click one of the followup chips
In the browser DevTools console (or the app's JS console), confirm a log line appears containing [Followups] followup clicked with parameters {event: "followup_clicked", reportID, reportActionID, hasPregeneratedResponse}
Repeat the click on both:
- A followup that renders instantly (pre-generated response, hasPregeneratedResponse: true)
- A followup that waits for an LLM round-trip (hasPregeneratedResponse: false)
Verify the chip becomes non-interactive after being clicked (existing resolved-state behavior is unchanged)

Unit test evidence:

FAIL — before fix (only the test commit 56f8a391a7b applied; Log.info call not yet added to SuggestedFollowup.ts):

● actions/Report › resolveSuggestedFollowup › should emit Log.info followup_clicked telemetry when a suggested followup is resolved

  expect(received).toBeDefined()

  Received: undefined

    5311 |             expect(telemetryCall).toBeDefined();
         |                                   ^

Test Suites: 1 failed, 1 total
Tests:       1 failed, 198 skipped, 199 total

PASS — after fix (HEAD):

Test Suites: 1 passed, 1 total
Tests:       198 skipped, 1 passed, 199 total

Verify that no errors appear in the JS console

Offline tests

The telemetry call is a local Log.info — it is queued by Log while offline and flushed when connectivity returns, same as every other Log.info call in the app. No additional offline behavior was introduced by this PR.

QA Steps

Same as Tests. This is additive telemetry only; no user-visible behavior changes. QA can verify by clicking a followup chip in a Concierge chat on staging and confirming the chip becomes resolved (existing behavior). Backend log verification is out-of-scope for QA.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

This PR is observability-only (adds a single Log.info call in a non-UI code path). There is no user-visible rendering change on any platform, so per the UI verify classification, no platform screenshots are applicable. The behavior that matters is verified by the unit test included in this PR (see Tests section).

Android: Native