feat: Added role filter to workspace members list by Uzaifm127 · Pull Request #88293 · Expensify/App

Uzaifm127 · 2026-04-19T18:28:18Z

Explanation of Change

This PR introduces a role-based member filter to the Workspace Members page, aligning it with the behavior already available on the domain members page.

Previously, users could not filter members by role, so this changes resolves that by:

Adding a role filter dropdown with options:
- Control workspaces: All members, Admins, Approvers, Auditors
- Collect workspaces: All members, Admins, Approvers
Setting “All members” as the default selection
The role filter is applied before the existing search
Supporting both layouts:
- Filter only (when search bar is hidden)
- Filter + search (when search bar is visible)

Fixed Issues

$ #87907
PROPOSAL: #87907 (comment)

Tests

Open the app or go to https://staging.new.expensify.com
Navigate to Workspace Settings > Members
Verify that the role filter dropdown is visible when there is at least one member
Verify that the default selected value is “All members”
Open the dropdown and verify that the options:
- For Control workspace: All members, Admins, Approvers, Auditors
- For Collect workspace: All members, Admins, Approvers
Select any filter and verify that only the filtered options are shown.
Verify that if workspace members are below the search limit then search bar is hidden otherwise it will be shown next to the filter.
Apply a role filter and then search for a member.
Verify that the search results are scoped within the selected role.
Select a role where no members exist.
Verify that the empty state is shown with:
- Title: No members match this filter
- Subtitle: Invite a member or change the filter above.

Verify that no errors appear in the JS console

Offline tests

Same as Test

QA Steps

Same as Test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-mWeb.mov

iOS: Native

ios-native.mov

iOS: mWeb Safari

ios-safari.mov

MacOS: Chrome / Safari

macOS.mov

melvin-bot · 2026-04-19T18:28:23Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-04-19T18:35:17Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/WorkspaceMembersPage.tsx	`61.20% <67.18%> (+0.21%)`	⬆️
... and 3016 files with indirect coverage changes

melvin-bot · 2026-04-20T09:41:54Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad5a7f99a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…arch

Uzaifm127 · 2026-04-21T08:07:47Z

@codex review

chatgpt-codex-connector · 2026-04-21T08:17:38Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

FitseTLT · 2026-04-23T13:25:57Z

@shawnborton can u review this?

FitseTLT · 2026-04-23T15:21:27Z

@Uzaifm127 the old filter list appears briefly with empty state graphics when filter is changed.

2026-04-23.18-20-12.mp4

shawnborton · 2026-04-23T15:26:33Z

Sure, will run a test build.

github-actions · 2026-04-23T15:29:21Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

FitseTLT · 2026-04-30T21:22:36Z

@shawnborton is the position of no items found text correct? or it should be below the text box?

FitseTLT · 2026-04-30T21:56:20Z

@Uzaifm127 one last bug related with debounced value because this line

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 595 to 596 in e69882b

    
           if (filteredData.length === 0) { 
        
               return null;

using non-debounced data it is causing the header disappear before the list is empty

dubielzyk-expensify · 2026-05-01T00:08:53Z

@shawnborton is the position of no items found text correct? or it should be below the text box?

That looks correct. It's meant to be in place of the table or results themselves which is where it sits currently

shawnborton · 2026-05-01T06:37:02Z

Yeah that works for me 👍

Uzaifm127 · 2026-05-01T15:12:03Z

@FitseTLT This is done.

using non-debounced data it is causing the header disappear before the list is empty

Uzaifm127 · 2026-05-01T15:13:42Z

@@ -881,7 +991,11 @@ function WorkspaceMembersPage({personalDetails, route, policy}: WorkspaceMembers
                        canSelectMultiple={canSelectMultiple}
                        turnOnSelectionModeOnLongPress={isPolicyAdmin}
                        onSelectAll={filteredData.length > 0 ? () => toggleAllUsers(filteredData) : undefined}


@FitseTLT Though I'm not sure, should we also use debounce data here instead of raw filteredData?

The latest bug (mentioned by you) is caused by this so we must do this.

Implemented.

FitseTLT · 2026-05-01T16:10:08Z

@Uzaifm127 there is a new bug the spacing on the header disappears quickly before the header does. Look

2026-05-01.19-08-37.mp4

Uzaifm127 · 2026-05-01T16:46:48Z

@FitseTLT Coincidentally, that bug is caused this

FitseTLT · 2026-05-01T17:32:41Z

Also don't you think we should reset selection on filter change see this:

2026-05-01.20-31-36.mp4

Uzaifm127 · 2026-05-01T17:53:56Z

@FitseTLT Do we also need to do with Search too? should we remove selection on search?

FitseTLT · 2026-05-01T17:55:39Z

I think so

Uzaifm127 · 2026-05-01T18:00:50Z

Done for Filters and Search.

FitseTLT

LGTM

github-actions · 2026-05-04T01:08:48Z

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-04T01:13:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88293.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a4898c6-34a8d39-542fc1eaec6496aba20f8c36fa6d87872738087b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a4898c6-34a8d39-ed261a1f48bd2e4ba6467e46b1d3de5f22f14b98/index.html

Web 🕸️
https://88293.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-04T01:15:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-04T13:26:59Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:29:49Z

Yes, help site changes are required. PR #88293 adds a role-based member filter to the Workspace Members page, but the existing help article (Managing-Workspace-Members.md) doesn't document this feature.

I've created a draft PR with the docs update: #89492

Changes made:

Added a new "Filter Workspace Members by Role" section documenting the role filter dropdown and its options (All members, Admins, Approvers, Auditors)
Updated article metadata keywords to include filter-related terms

Note: I was unable to add the PR to GitHub project 196 due to token permission limitations. Please add it manually: gh project item-add 196 --owner Expensify --url https://github.com/Expensify/App/pull/89492

Uzaifm127 · 2026-05-04T18:29:04Z

@stephanieelliott As per this Slack thread, Melvin posted that the help site changes are required but I'm not able to mark the PR ready for review?

Could you please help me how can I proceed further? Do I need to ping in the comment after reviewing the PR?

Do I only need to run this command: gh project item-add 196 --owner Expensify --url https://github.com/Expensify/App/pull/89492 ?

jponikarchuk · 2026-05-04T18:48:43Z

Deploy Blocker #89554 was identified to be related to this PR.

added role filter to workspace members list

3fb5310

melvin-bot Bot assigned Uzaifm127 Apr 19, 2026

Uzaifm127 changed the title ~~feat: Added role filter to workspace members list~~ [WIP] feat: Added role filter to workspace members list Apr 19, 2026

Uzaifm127 added 3 commits April 20, 2026 10:36

fixed prettier: formatted the added spanish translations

87fc273

Fixed the no result found message position when search has zero results

37f42ad

Merge branch 'main' of https://github.com/Uzaifm127/App into feat/87907

ad5a7f9

Uzaifm127 changed the title ~~[WIP] feat: Added role filter to workspace members list~~ feat: Added role filter to workspace members list Apr 20, 2026

Uzaifm127 marked this pull request as ready for review April 20, 2026 09:41

Uzaifm127 requested review from a team as code owners April 20, 2026 09:41

melvin-bot Bot requested review from FitseTLT and trjExpensify and removed request for a team April 20, 2026 09:41

melvin-bot Bot removed request for a team and trjExpensify April 20, 2026 09:41

github-actions Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread src/pages/workspace/WorkspaceMembersPage.tsx Outdated

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread src/pages/workspace/WorkspaceMembersPage.tsx Outdated

Uzaifm127 added 3 commits April 21, 2026 12:48

Replaced hardcoded minHeight: 40 to styles.mnh40

5081b48

preserved accessible no-results announcements on workspace members se…

884012f

…arch

Merge branch 'main' of https://github.com/Uzaifm127/App into feat/87907

0cb4261

Merge branch 'main' of https://github.com/Uzaifm127/App into feat/87907

d2be0af

replaced raw filtered data with debounced filtered data

42c1c32

Uzaifm127 commented May 1, 2026

View reviewed changes

replaced raw filtered data with debounced data on onSelectAll prop

eacf030

fixed workspace members selection state during filtering and searching

5aad3cd

FitseTLT approved these changes May 1, 2026

View reviewed changes

melvin-bot Bot requested a review from srikarparsi May 1, 2026 18:30

srikarparsi approved these changes May 4, 2026

View reviewed changes

srikarparsi merged commit a4898c6 into Expensify:main May 4, 2026
39 checks passed

MelvinBot mentioned this pull request May 4, 2026

[NO QA] Docs updates for E/A#88293 Add role filter to workspace members docs #89492

Draft

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

76 tasks

jponikarchuk mentioned this pull request May 4, 2026

Members - Empty state screen is not scrollable on landscape mode when applying role filter. #89554

Open

7 tasks

jponikarchuk mentioned this pull request May 4, 2026

[$250] [CFI] Add member filter to Workspace Members #87907

Open

7 tasks

Conversation

Uzaifm127 commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 19, 2026

Uh oh!

codecov Bot commented Apr 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Apr 20, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uzaifm127 commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

FitseTLT commented Apr 23, 2026

Uh oh!

FitseTLT commented Apr 23, 2026

Uh oh!

shawnborton commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

FitseTLT commented Apr 30, 2026

Uh oh!

FitseTLT commented Apr 30, 2026

Uh oh!

dubielzyk-expensify commented May 1, 2026

Uh oh!

shawnborton commented May 1, 2026

Uh oh!

Uzaifm127 commented May 1, 2026

Uh oh!

Uzaifm127 May 1, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uzaifm127 May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented May 1, 2026

Uh oh!

Uzaifm127 commented May 1, 2026

Uh oh!

FitseTLT commented May 1, 2026

Uh oh!

Uzaifm127 commented May 1, 2026

Uh oh!

FitseTLT commented May 1, 2026

Uh oh!

Uzaifm127 commented May 1, 2026

Uh oh!

FitseTLT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uh oh!

OSBotify commented May 4, 2026

Uzaifm127 commented Apr 19, 2026 •

edited

Loading

codecov Bot commented Apr 19, 2026 •

edited by github-actions Bot

Loading

Uzaifm127 May 1, 2026 •

edited

Loading