Show action badge in LHN for individual expense reports by MelvinBot · Pull Request #88294 · Expensify/App

MelvinBot · 2026-04-19T18:34:46Z

Explanation of Change

The action badge (Approve/Pay/Submit) in the LHN was only showing for workspace chat reports because getIOUReportActionWithBadge searched exclusively for REPORT_PREVIEW actions, which only exist in workspace chats. When an individual expense report appeared directly in the LHN, the function found no REPORT_PREVIEW actions and returned no badge.

This PR adds handling in getIOUReportActionWithBadge to detect when the report is an expense report itself (with hasParentAccess === false) and directly evaluate canIOUBePaid/canApproveIOU/canSubmitAndIsAwaitingForCurrentUser on it, using the same priority order (Pay > Approve > Submit) as for workspace chats. The caller in getReasonAndReportActionThatRequiresAttention is also updated: isWaitingForAssigneeToCompleteAction is refactored into getActionTypeForAssigneeToComplete so the badge can be computed and included in the early return path for expense reports.

Per the issue requirement, "Review duplicates" cases still get an Approve badge because canApproveIOU returns true regardless of duplicate state.

Fixed Issues

$ #87712
PROPOSAL: #87712 (comment)

Tests

Precondition:

A: workspace owner
B: workspace member & submitter
C: workspace member & approver

B: Submit expense
C: Leave the B's workspace chat
C: Open B's expense report from search router
C: Verify that "Approve" badge shows in LHN
Verify that no errors appear in the JS console

Offline tests

Follow the test steps above so the Approve badge appears on the LHN entry
Go offline (disable network)
Verify the Approve badge is still visible on the LHN entry
Go back online
Verify the badge still displays correctly

QA Steps

Precondition:

A: workspace owner
B: workspace member & submitter
C: workspace member & approver

B: Submit expense
C: Leave the B's workspace chat
C: Open B's expense report from search router
C: Verify that "Approve" badge shows in LHN
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

AI Tests

TypeScript (typecheck-tsgo): Passed
ESLint (lint-changed): Passed (no TS files changed per lint-changed; manual eslint run on changed files shows only pre-existing Onyx.connect deprecation warnings)
Prettier: Passed (no formatting changes needed)
Unit tests (ReportUtils, ReportWorkflow): Passed (877 + 42 = 919 tests)

…reports Expense reports shown directly in the LHN were missing action badges because getIOUReportActionWithBadge only searched for REPORT_PREVIEW actions, which only exist in workspace chat reports. Added handling for expense reports to evaluate canIOUBePaid/canApproveIOU/canSubmitAndIsAwaitingForCurrentUser directly on the report itself. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

…ion filtering The 'should exclude deleted actions' test was passing an expense report directly to getIOUReportActionWithBadge, but the PR added a new early-return path for expense reports that returns reportAction: undefined. Updated the test to use a chat report with REPORT_PREVIEW actions pointing to a separate expense report, matching the pattern used in other tests. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

MelvinBot · 2026-04-19T18:46:38Z

Fixed the failing test should exclude deleted actions in ReportWorkflowTest.ts.

The test was passing an expense report directly to getIOUReportActionWithBadge, but the new early-return path for expense reports (which returns reportAction: undefined) meant the REPORT_PREVIEW scanning logic was never reached. Updated the test to use a chat report with REPORT_PREVIEW actions pointing to a separate expense report, matching the pattern used in the other tests in this describe block.

aimane-chnaif · 2026-04-19T19:29:20Z

-    const iouReportID = getIOUReportIDFromReportActionPreview(iouReportActionToApproveOrPay);
+    const isExpenseReportOption = isExpenseReport(optionOrReport);
+    const iouReportID = isExpenseReportOption ? optionOrReport.reportID : getIOUReportIDFromReportActionPreview(iouReportActionToApproveOrPay);


@MelvinBot your solution is wrong (never reaches this line) because of early return here:

App/src/libs/ReportUtils.ts

Lines 4302 to 4310 in ff9d4b7

if (isWaitingForAssigneeToCompleteAction(optionOrReport, parentReportAction)) {

return {

reason: CONST.REQUIRES_ATTENTION_REASONS.IS_WAITING_FOR_ASSIGNEE_TO_COMPLETE_ACTION,

reportAction: Object.values(reportActions)

// eslint-disable-next-line rulesdir/prefer-locale-compare-from-context

.sort((a, b) => a.created.localeCompare(b.created))

.find((action) => action.childType === CONST.REPORT.TYPE.TASK && !isTaskCompleted(action)),

};

}

As stated in isWaitingForAssigneeToCompleteAction, this issue happens only when you doesn't have access to workspace chat report (hasParentAccess = false).

App/src/libs/ReportUtils.ts

Lines 4209 to 4215 in ff9d4b7

if (report?.hasParentAccess === false && isReportManager(report)) {

if (isOpenTaskReport(report, parentReportAction)) {

return true;

}

if (isProcessingReport(report) && isExpenseReport(report)) {

return true;

You're right — when hasParentAccess === false, isWaitingForAssigneeToCompleteAction returns true for processing expense reports, so the badge computation was never reached.

Fixed by moving getIOUReportActionWithBadge above the isWaitingForAssigneeToCompleteAction check and including actionBadge in that early return path for expense reports.

…rly return When hasParentAccess is false, isWaitingForAssigneeToCompleteAction returns true for expense reports in processing state, causing an early return before the badge is computed. Move getIOUReportActionWithBadge call above this check and include the actionBadge in the early return path for expense reports. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

aimane-chnaif · 2026-04-19T19:37:40Z

+    // When the report is an expense report itself (not a workspace chat), check it directly
+    // since expense reports don't contain REPORT_PREVIEW actions
+    if (isExpenseReport(chatReport)) {
+        const parentChat = getReportOrDraftReport(chatReport?.chatReportID);
+        let expenseBadge: ValueOf<typeof CONST.REPORT.ACTION_BADGE> | undefined;
+        if (
+            canIOUBePaid(chatReport, parentChat, policy, undefined, undefined, undefined, undefined, invoiceReceiverPolicy) ||
+            canIOUBePaid(chatReport, parentChat, policy, undefined, undefined, true, undefined, invoiceReceiverPolicy)
+        ) {
+            expenseBadge = CONST.REPORT.ACTION_BADGE.PAY;
+        } else if (canApproveIOU(chatReport, policy, reportMetadata)) {
+            expenseBadge = CONST.REPORT.ACTION_BADGE.APPROVE;
+        } else {
+            const isWaitingSubmitFromCurrentUser = canSubmitAndIsAwaitingForCurrentUser(
+                chatReport,
+                parentChat,
+                policy,
+                getReportTransactions(chatReport?.reportID),
+                getAllTransactionViolations(),
+                getCurrentUserEmail(),
+                getUserAccountID(),
+                getAllReportActions(chatReport?.reportID),
+            );
+            if (isWaitingSubmitFromCurrentUser) {
+                expenseBadge = CONST.REPORT.ACTION_BADGE.SUBMIT;
+            }
+        }
+        return {reportAction: undefined, actionBadge: expenseBadge};
+    }


@MelvinBot this logic is duplicated. Extract this into getBadgeFromIOUReport function

Extracted the shared Pay > Approve > Submit logic into getBadgeFromIOUReport. Both the expense report path and the REPORT_PREVIEW path now call it.

Done — extracted into getBadgeFromIOUReport and deduplicated the logic in getIOUReportActionWithBadge.

The Pay > Approve > Submit badge computation was duplicated between the expense report path and the REPORT_PREVIEW path in getIOUReportActionWithBadge. Extract into a shared getBadgeFromIOUReport function. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

MelvinBot · 2026-04-19T19:45:04Z

The Jest test failure (should exclude deleted actions) was already fixed in commit 929354c. The test run completed successfully. The only remaining failing check is PR Author Checklist, which needs to be completed by the human co-author before marking as ready for review.

aimane-chnaif · 2026-04-19T19:48:37Z

    );
 }

+function getBadgeFromIOUReport(


@MelvinBot add unit test for this function

Added 3 unit tests for getBadgeFromIOUReport: APPROVE for submitted reports, PAY for approved reports, and undefined for settled reports.

Added unit tests for getBadgeFromIOUReport: APPROVE for submitted reports, PAY for approved reports, and undefined for settled reports.

aimane-chnaif · 2026-04-19T19:49:10Z

            return false;
        }
        const iouReport = getReportOrDraftReport(action.childReportID);
-        // Show to the actual payer, or to policy admins via the pay-elsewhere path for negative expenses


@MelvinBot restore this comment in new getBadgeFromIOUReport function

Restored the comment: // Show to the actual payer, or to policy admins via the pay-elsewhere path for negative expenses

Restored — the comment is at line 272 in the new getBadgeFromIOUReport function.

aimane-chnaif · 2026-04-19T19:52:45Z

+    if (isExpenseReport(chatReport)) {
+        const parentChat = getReportOrDraftReport(chatReport?.chatReportID);
+        return {reportAction: undefined, actionBadge: getBadgeFromIOUReport(chatReport, parentChat, policy, reportMetadata, invoiceReceiverPolicy)};
+    }


@MelvinBot this is only when user doesn't have access to workspace chat.
Add this to if condition: && chatReport.hasParentAccess === false and pass undefined instead of parentChat as 2nd param of getBadgeFromIOUReport

Done — added chatReport?.hasParentAccess === false to the condition and passing undefined instead of parentChat.

Done — added chatReport?.hasParentAccess === false to the condition and passing undefined as the chatReport param to getBadgeFromIOUReport.

aimane-chnaif · 2026-04-19T19:55:22Z

-        ((optionOrReport.hasOutstandingChildRequest === true && !hasStaleChildRequest) || iouReportActionToApproveOrPay?.reportActionID) &&
+        ((optionOrReport.hasOutstandingChildRequest === true && !hasStaleChildRequest) || iouReportActionToApproveOrPay?.reportActionID || (isExpenseReportOption && actionBadge)) &&


@MelvinBot revert this line change as redundant as early returned already

Reverted — removed (isExpenseReportOption && actionBadge) from the condition since the early return in isWaitingForAssigneeToCompleteAction now handles it.

Already reverted in the previous commit — removed (isExpenseReportOption && actionBadge) from the condition since the expense report case is now handled by the isWaitingForAssigneeToCompleteAction early return.

…dd tests - Restore "Show to the actual payer" comment in getBadgeFromIOUReport - Scope expense report path to hasParentAccess === false and pass undefined for parentChat - Revert redundant (isExpenseReportOption && actionBadge) condition in getReasonAndReportActionThatRequiresAttention - Export getBadgeFromIOUReport and add unit tests for it Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

MelvinBot · 2026-04-19T20:03:24Z

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

MelvinBot · 2026-04-19T20:03:26Z

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

aimane-chnaif · 2026-04-19T20:09:16Z

+        return {
+            reason: CONST.REQUIRES_ATTENTION_REASONS.IS_WAITING_FOR_ASSIGNEE_TO_COMPLETE_ACTION,
+            reportAction: Object.values(reportActions).find((action) => action.childType === CONST.REPORT.TYPE.TASK),
+            ...(isExpenseReportOption && actionBadge ? {actionBadge} : {}),


@MelvinBot

define in CONST below this

ACTION_TYPES_FOR_ASSIGNEE_TO_COMPLETE: { EXPENSE: 'expense', TASK: 'task', },

refactor isWaitingForAssigneeToCompleteAction function to getActionTypeForAssigneeToComplete which returns action type instead of boolean

Instead of isExpenseReportOption condition, use this condition directly - actionTypeForAssigneeToComplete === CONST.REPORT.ACTION_TYPES_FOR_ASSIGNEE_TO_COMPLETE.EXPENSE

Done. Renamed isWaitingForAssigneeToCompleteAction to getActionTypeForAssigneeToComplete which returns the action type (expense/task/undefined), added ACTION_TYPES_FOR_ASSIGNEE_TO_COMPLETE const, and replaced the isExpenseReportOption condition with actionTypeForAssigneeToComplete === CONST.REPORT.ACTION_TYPES_FOR_ASSIGNEE_TO_COMPLETE.EXPENSE.

…gneeToComplete Rename the function to return the specific action type (expense/task) instead of a boolean, and add ACTION_TYPES_FOR_ASSIGNEE_TO_COMPLETE const. Use the returned action type to conditionally include the badge in the early return path instead of relying on isExpenseReport. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

aimane-chnaif · 2026-04-19T20:17:16Z

 * @param [parentReportAction] - The parent report action of the report (Used to check if the task has been canceled)
 */
-function isWaitingForAssigneeToCompleteAction(report: OnyxEntry<Report>, parentReportAction: OnyxEntry<ReportAction>): boolean {
+function getActionTypeForAssigneeToComplete(


@MelvinBot add unit test

aimane-chnaif · 2026-04-19T20:19:56Z

@@ -4314,6 +4310,17 @@ function getReasonAndReportActionThatRequiresAttention(
    // eslint-disable-next-line @typescript-eslint/no-deprecated
    const invoiceReceiverPolicy = invoiceReceiverPolicyID ? getPolicy(invoiceReceiverPolicyID) : undefined;
    const {reportAction: iouReportActionToApproveOrPay, actionBadge} = getIOUReportActionWithBadge(optionOrReport, policy, optionReportMetadata, invoiceReceiverPolicy);


@MelvinBot For code optimization, move this line below if (actionTypeForAssigneeToComplete) condition.
And inside if (actionTypeForAssigneeToComplete) {} block, call this only when isAssigneeExpenseAction = true.
This way, we can avoid calling unnecessary getIOUReportActionWithBadge when assignee complete action type is 'task'.

Done. Moved getIOUReportActionWithBadge below the actionTypeForAssigneeToComplete check. It's now only called inside the if block when isAssigneeExpenseAction is true, and otherwise called in the normal path below.

Move getIOUReportActionWithBadge below the actionTypeForAssigneeToComplete check and only call it when the action type is 'expense'. This avoids an unnecessary call when the assignee action is a task. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

…=false Verifies that getReasonAndReportActionThatRequiresAttention returns an actionBadge (APPROVE) when an expense report has hasParentAccess=false and is in processing state, ensuring the badge is included even when the early return path via getActionTypeForAssigneeToComplete is taken. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

MelvinBot · 2026-04-19T20:39:09Z

Added a unit test in ReportUtilsTest.ts that verifies getReasonAndReportActionThatRequiresAttention returns IS_WAITING_FOR_ASSIGNEE_TO_COMPLETE_ACTION with an actionBadge of APPROVE for expense reports with hasParentAccess=false in processing state.

aimane-chnaif · 2026-04-19T20:50:52Z

@MelvinBot

pull main and fix prettier diff
add Tests / QA Steps
complete author checklist
mark as ready for review

…eForExpenseReports Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>

Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>

MelvinBot · 2026-04-19T20:53:14Z

Merged main and fixed prettier formatting. I wasn't able to mark the PR as ready for review due to permission restrictions — please mark it manually.

aimane-chnaif · 2026-04-19T20:54:25Z

@MelvinBot complete author checklist and mark as ready for review

aimane-chnaif · 2026-04-19T21:02:24Z

@MelvinBot add this to Tests / QA Steps.

Precondition:

A: workspace owner
B: workspace member & submitter
C: workspace member & approver

B: Submit expense
C: Leave the B's workspace chat
C: Open B's expense report from search router
C: Verify that "Approve" badge shows in LHN

aimane-chnaif · 2026-04-19T21:25:22Z

@MelvinBot check off missing items in author checklist

MelvinBot · 2026-04-19T21:28:32Z

🤖 Code Review

The changes look correct for the stated goal. Summary:

Correctness ✅

getActionTypeForAssigneeToComplete rename is complete — no stale callers remain (only string references in CONST/translation keys).
getBadgeFromIOUReport extraction preserves identical logic from the inlined version in getIOUReportActionWithBadge.
Passing chatReport=undefined in the assignee expense path (ReportUtils.ts:4316) is safe — canIOUBePaid uses it only for archive/invoice checks that degrade gracefully to undefined.

No regressions ✅

Task reports with hasParentAccess=false still hit the isOpenTaskReport branch and return TASK — they can never return EXPENSE.
The downstream getIOUReportActionWithBadge path for workspace chat reports (REPORT_PREVIEW scanning) is unchanged.

One pre-existing gap (not a regression from this PR):

Approved expense reports with hasParentAccess=false that need a PAY badge won't be caught — getActionTypeForAssigneeToComplete only returns EXPENSE for isProcessingReport (SUBMITTED state), and getIOUReportActionWithBadge won't find REPORT_PREVIEW actions in an expense report. This would need a separate fix if it's a real scenario.

Tests ✅

New test covers the primary scenario (hasParentAccess=false, processing expense report → APPROVE badge).
getBadgeFromIOUReport has 3 dedicated tests (APPROVE, PAY, settled=undefined).

MelvinBot · 2026-04-19T21:30:50Z

All items in the PR Author Checklist are already checked off — there are no unchecked items remaining.

aimane-chnaif · 2026-04-19T21:35:53Z

@MelvinBot these items are still missing in checklist

      - [ ] If any non-english text was added/modified, I used [JaimeGPT](https://chatgpt.com/g/g-2dgOQl5VM-english-to-spanish-translator-aka-jaimegpt) to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

- [ ] If new assets were added or existing ones were modified, I verified that:
    - [ ] The assets are optimized and compressed (for SVG files, run `npm run compress-svg`)
    - [ ] The assets load correctly across all supported platforms.

chatgpt-codex-connector · 2026-04-19T21:36:21Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

MelvinBot · 2026-04-19T21:39:38Z

Added the missing checklist items (non-English text / JaimeGPT and new assets verification). Both are checked since this PR doesn't add non-English text or new assets.

AndrewGable · 2026-04-20T17:15:14Z

Is this ready for review @aimane-chnaif?

aimane-chnaif · 2026-04-20T17:16:07Z

Is this ready for review @aimane-chnaif?

yes ready

AndrewGable · 2026-04-20T21:21:00Z

Conflicts

aimane-chnaif · 2026-04-21T02:32:18Z

@MelvinBot fix conflict

…eForExpenseReports Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com> # Conflicts: # src/libs/ReportUtils.ts

MelvinBot · 2026-04-21T02:45:31Z

Merged main and resolved the conflict in src/libs/ReportUtils.ts:

Deduplicated the ReportWorkflow import (main added a similar import line; merged them keeping getBadgeFromIOUReport)
Kept the PR's removal of isWaitingForAssigneeToCompleteAction usage block (replaced by getActionTypeForAssigneeToComplete in this PR)

Typecheck passes.

MelvinBot · 2026-04-21T03:02:44Z

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

aimane-chnaif · 2026-04-21T03:03:28Z

+        const expenseBadge = isAssigneeExpenseAction ? getBadgeFromIOUReport(optionOrReport, undefined, policy, optionReportMetadata, invoiceReceiverPolicy) : undefined;
+        return {
+            reason: CONST.REQUIRES_ATTENTION_REASONS.IS_WAITING_FOR_ASSIGNEE_TO_COMPLETE_ACTION,
+            reportAction: Object.values(reportActions).find((action) => action.childType === CONST.REPORT.TYPE.TASK),


@MelvinBot apply this change which came from #87166

Applied the change from #87166 — the task reportAction lookup now filters by !isTaskCompleted(action) and childManagerAccountID === deprecatedCurrentUserAccountID, sorts by created, and picks the first match via .at(0).

Filter task report actions by completion status and current user, and sort by creation date to pick the earliest incomplete task. Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>

MelvinBot · 2026-04-21T03:14:59Z

🤖 Code Review — PR #88294

Summary: The PR correctly adds action badge support for individual expense reports in the LHN by:

Refactoring isWaitingForAssigneeToCompleteAction → getActionTypeForAssigneeToComplete (returns 'expense'/'task'/undefined instead of boolean)
Extracting shared Pay > Approve > Submit logic into getBadgeFromIOUReport
Computing the badge in the early return path for expense reports with hasParentAccess === false

No issues found. The changes look correct and clean:

Rename is safe: isWaitingForAssigneeToCompleteAction was only used internally in ReportUtils.ts — no external callers break. The CONST key and i18n strings use the string value 'isWaitingForAssigneeToCompleteAction', not the function, so they're unaffected.
Badge deduplication is correct: getBadgeFromIOUReport faithfully reproduces the original inline logic from getIOUReportActionWithBadge, and both call sites now use it.
Task filtering from Action Badge: deep link to report action #87166 is applied: The reportAction lookup correctly filters by !isTaskCompleted(action), childManagerAccountID === deprecatedCurrentUserAccountID, and sorts by created.
Optimization is good: getIOUReportActionWithBadge is only called when the action type is NOT an assignee-complete action (or when it's specifically an expense action), avoiding unnecessary work for task actions.
Test coverage is solid: New tests for getBadgeFromIOUReport (approve/pay/undefined) and getReasonAndReportActionThatRequiresAttention (expense report with hasParentAccess=false). Existing getIOUReportActionWithBadge test was cleaned up to use separate chat/IOU reports.

LGTM ✅

aimane-chnaif · 2026-04-21T03:16:58Z

@AndrewGable done

flaviadefaria · 2026-04-21T09:32:52Z

While I think the change is ok, it feels to me like an edge case, really, given that the user needs to "Open B's expense report from search router". I'll check with some other members of the product team before approving this one.

aimane-chnaif · 2026-04-21T09:35:53Z

FYI: this came from David's request

flaviadefaria · 2026-04-21T09:51:38Z

Cool, thanks for the additional context here. I'll approve the PR.

flaviadefaria

Approved!

OSBotify · 2026-04-21T17:14:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-21T17:51:20Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-21T18:08:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88294.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-105f09d-ec04572-4cfa62ac19ff33d298f504581f255562207611dd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-105f09d-ec04572-82a3ff3b8a98233ae723a8d03002e33d5dbd8abd/index.html

Web 🕸️
https://88294.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-23T20:20:10Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.62-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot assigned aimane-chnaif Apr 19, 2026

MelvinBot requested a review from a team April 19, 2026 18:34

MelvinBot mentioned this pull request Apr 19, 2026

Show action badge (Approve) in LHN for individual expense reports #87712

Open

aimane-chnaif reviewed Apr 19, 2026

View reviewed changes

aimane-chnaif suggested changes Apr 19, 2026

View reviewed changes

aimane-chnaif reviewed Apr 19, 2026

View reviewed changes

MelvinBot and others added 2 commits April 19, 2026 20:26

MelvinBot and others added 2 commits April 19, 2026 20:52

MelvinBot marked this pull request as ready for review April 19, 2026 21:03

MelvinBot requested a review from a team as a code owner April 19, 2026 21:03

melvin-bot Bot requested a review from flaviadefaria April 19, 2026 21:03

aimane-chnaif approved these changes Apr 19, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into claude-showActionBadg…

a5688ea

…eForExpenseReports Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com> # Conflicts: # src/libs/ReportUtils.ts

aimane-chnaif reviewed Apr 21, 2026

View reviewed changes

flaviadefaria approved these changes Apr 21, 2026

View reviewed changes

AndrewGable approved these changes Apr 21, 2026

View reviewed changes

AndrewGable merged commit 105f09d into main Apr 21, 2026
38 checks passed

AndrewGable deleted the claude-showActionBadgeForExpenseReports branch April 21, 2026 17:02

OSBotify mentioned this pull request Apr 23, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

	if (isWaitingForAssigneeToCompleteAction(optionOrReport, parentReportAction)) {
	return {
	reason: CONST.REQUIRES_ATTENTION_REASONS.IS_WAITING_FOR_ASSIGNEE_TO_COMPLETE_ACTION,
	reportAction: Object.values(reportActions)
	// eslint-disable-next-line rulesdir/prefer-locale-compare-from-context
	.sort((a, b) => a.created.localeCompare(b.created))
	.find((action) => action.childType === CONST.REPORT.TYPE.TASK && !isTaskCompleted(action)),
	};
	}

	if (report?.hasParentAccess === false && isReportManager(report)) {
	if (isOpenTaskReport(report, parentReportAction)) {
	return true;
	}

	if (isProcessingReport(report) && isExpenseReport(report)) {
	return true;

		((optionOrReport.hasOutstandingChildRequest === true && !hasStaleChildRequest) \|\| iouReportActionToApproveOrPay?.reportActionID) &&
		((optionOrReport.hasOutstandingChildRequest === true && !hasStaleChildRequest) \|\| iouReportActionToApproveOrPay?.reportActionID \|\| (isExpenseReportOption && actionBadge)) &&

Conversation

MelvinBot commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Apr 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Apr 19, 2026

Uh oh!

MelvinBot commented Apr 19, 2026

Uh oh!

aimane-chnaif Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Apr 19, 2026

Uh oh!

aimane-chnaif commented Apr 19, 2026

Uh oh!

MelvinBot commented Apr 19, 2026

Uh oh!

aimane-chnaif commented Apr 19, 2026

Uh oh!

aimane-chnaif commented Apr 19, 2026

Uh oh!

aimane-chnaif commented Apr 19, 2026

Uh oh!

MelvinBot commented Apr 19, 2026

MelvinBot commented Apr 19, 2026 •

edited

Loading

MelvinBot Apr 19, 2026 •

edited

Loading

aimane-chnaif Apr 19, 2026 •

edited

Loading