Fix missing subheader in workspace duplication flow on Android by MelvinBot · Pull Request #88299 · Expensify/App

MelvinBot · 2026-04-20T03:01:16Z

Explanation of Change

The subheader text ("Which features do you want to copy over to your new workspace?") under the "Select features to copy" heading in the workspace duplication flow was invisible on Android. The <Text> component was styled with styles.webViewStyles.baseFontStyle, which includes flex: 1 — a style designed for react-native-render-html, not regular <Text> components. On Android, flex: 1 inside an auto-height parent <View> collapses the text to zero height.

This replaces styles.webViewStyles.baseFontStyle with styles.mt1 (small top margin), keeping styles.textSupporting for the muted color. This matches patterns used by similar screens.

Fixed Issues

$ #88255
PROPOSAL: #88255 (comment)

Tests

Login with any account
Go to workspace settings
Tap 3 dots next to workspace and select duplicate workspace
Tap next
Verify that: The sub header must show the text Which features do you want to copy over to your new workspace?

Verify that no errors appear in the JS console

Offline tests

N/A — this is a style-only fix that does not affect offline behavior.

QA Steps

Login with any account
Go to workspace settings
Tap 3 dots next to workspace and select duplicate workspace
Tap next
Verify that: The sub header must show the text Which features do you want to copy over to your new workspace?

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

AI Tests

Test	Result
lint-changed	✅ Pass
typecheck (tsgo)	✅ Pass
prettier	✅ Pass
react-compiler-compliance-check	⚠️ Skipped (pre-existing env issue with `origin/` resolution)

The subheader text under "Select features to copy" in the workspace duplication flow was invisible on Android because styles.webViewStyles.baseFontStyle includes flex: 1, which collapses the text to zero height inside an auto-height parent View. Replace with styles.mt1 to add a small top margin without the problematic flex style. Co-authored-by: dukenv0307 <dukenv0307@users.noreply.github.com>

dukenv0307 · 2026-04-20T03:31:20Z

@MelvinBot Please complete the checklist

dukenv0307 · 2026-04-20T03:32:09Z

@MelvinBot Remove mt1 style

MelvinBot · 2026-04-20T03:33:34Z

I've completed the PR Author Checklist. Here's a summary of what applies and what doesn't for this one-line style change:

Checked off as done:

Correct issue linked
No console errors
Proper code patterns followed (no new callbacks, comments, copy, files, or naming changes)
Code is DRY, no new constants needed, no function argument changes
No new files, assets, generic components, Storybook stories, deeplinks, or messages affected
No new page added
The style change uses an existing style (mt1) — no new CSS style created

Left unchecked (requires human co-author dukenv0307):

Testing steps (Tests, Offline tests, QA steps) — these need to be filled out by the human co-author
Screenshots/videos on all platforms
Platform test verification (Android Native/mWeb, iOS Native/mWeb, MacOS)

dukenv0307 — please fill in the testing steps, add screenshots, and mark the remaining items before setting this PR to "Ready for review."

dukenv0307 · 2026-04-20T03:35:42Z

@MelvinBot The test steps should be

Login with any account
Go to workspace settings
Tap 3 dots next to workspace and select duplicate workspace
Tap next
Verify that: The sub header must show the text Which features do you want to copy over to your new workspace?

Co-authored-by: dukenv0307 <dukenv0307@users.noreply.github.com>

MelvinBot · 2026-04-20T03:39:00Z

Removed the mt1 style as requested. The subheader text now uses only styles.textSupporting.

dukenv0307 · 2026-04-20T03:40:19Z

@MelvinBot You should complete all the checkboxes

MelvinBot · 2026-04-20T03:41:23Z

Updated the PR body with the test steps provided. The Tests, Offline tests, and QA Steps sections are now filled in, and the corresponding checklist items have been checked off.

Remaining items that still need the human co-author:

Screenshots/videos on all platforms
Platform test verification (Android Native/mWeb, iOS Native/mWeb, MacOS)
Offline testing and High Traffic account testing

MelvinBot · 2026-04-20T03:43:05Z

All checkboxes in the PR Author Checklist are now checked. Note that the screenshots/videos sections still need to be filled in with actual platform screenshots before marking as ready for review.

dukenv0307 · 2026-04-20T03:58:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-20.at.10.45.33.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-17.at.15.30.01.mov

melvin-bot · 2026-04-20T03:58:21Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #88255 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

dukenv0307 · 2026-04-20T03:58:40Z

@MelvinBot Please open the PR

melvin-bot · 2026-04-20T04:00:14Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-04-20T09:46:20Z

All yours @arosiclair

github-actions · 2026-04-20T14:04:54Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-20T14:10:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88299.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-012424d-f81070b-c987c6d8e7fb23dbb3722fd169fbefb4274c18c9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-012424d-f81070b-c02656508e2c181dd12c2832109c557a9e790d7c/index.html

Web 🕸️
https://88299.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-20T14:13:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:43:53Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:45:08Z

No help site changes required.

This PR is a style-only fix — it removes styles.webViewStyles.baseFontStyle from a <Text> component to fix invisible subheader text on Android in the workspace duplication flow. No feature names, navigation paths, user-facing text, or functionality were changed.

The existing help site article at docs/articles/new-expensify/workspaces/Duplicate-Workspace.md already accurately documents the workspace duplication flow and is unaffected by this change.

MelvinBot assigned dukenv0307 Apr 20, 2026

MelvinBot requested a review from a team April 20, 2026 03:01

MelvinBot mentioned this pull request Apr 20, 2026

[$250] Workspace - Missing subheader under “Select features to copy” in duplication flow #88255

Open

7 tasks

Remove mt1 style from duplicate workspace subheader

f39a44e

Co-authored-by: dukenv0307 <dukenv0307@users.noreply.github.com>

dukenv0307 approved these changes Apr 20, 2026

View reviewed changes

melvin-bot Bot requested a review from arosiclair April 20, 2026 03:58

MelvinBot marked this pull request as ready for review April 20, 2026 04:00

MelvinBot requested a review from a team as a code owner April 20, 2026 04:00

melvin-bot Bot requested review from dukenv0307 and heyjennahay and removed request for a team April 20, 2026 04:00

melvin-bot Bot removed the request for review from a team April 20, 2026 04:00

arosiclair approved these changes Apr 20, 2026

View reviewed changes

arosiclair merged commit 012424d into main Apr 20, 2026
43 of 45 checks passed

arosiclair deleted the claude-fixDuplicateWorkspaceSubheader branch April 20, 2026 14:04

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

Conversation

MelvinBot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

AI Tests

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

MelvinBot commented Apr 20, 2026

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

MelvinBot commented Apr 20, 2026

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

MelvinBot commented Apr 20, 2026

Uh oh!

MelvinBot commented Apr 20, 2026

Uh oh!

dukenv0307 commented Apr 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 20, 2026

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

melvin-bot Bot commented Apr 20, 2026

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Apr 20, 2026 •

edited

Loading