Part 3: Remove Onyx.connect() for ONYXKEYS.COLLECTION.REPORT_ACTIONS #88312
Merged
Gonals merged 12 commits intoExpensify:mainfrom Apr 27, 2026
Merged
Part 3: Remove Onyx.connect() for ONYXKEYS.COLLECTION.REPORT_ACTIONS #88312Gonals merged 12 commits intoExpensify:mainfrom
Gonals merged 12 commits intoExpensify:mainfrom
Conversation
…PolicyData - Add reportActionsList to BuildPolicyDataOptions type - Pass reportActionsList through buildPolicyData to createPolicyExpenseChats instead of relying on deprecated module-scoped Onyx.connect() variable - Update all component callers to use useAllPolicyExpenseChatReportActions hook - Add test verifying reportActionsList flows through to createPolicyExpenseChats Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
melvin-bot
Bot
requested review from
flaviadefaria and
parasharrajat
and removed request for
a team and
flaviadefaria
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
a team and
Gonals
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06605d3f3d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
|
No new product considerations - removing my assignment and unsubscribing. |
# Conflicts: # src/components/SettlementButton/index.tsx # src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx # src/pages/iou/request/step/IOURequestStepUpgrade.tsx
…to useCallback deps Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nal ? Change reportActionsList from optional (?) to required with | undefined in BuildPolicyDataOptions. Pass undefined explicitly with TODO comments at all call sites not yet migrated to use useAllPolicyExpenseChatReportActions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
reportActionsList is only consumed inside the `if (adminParticipant?.login)` branch of buildPolicyData. Only IOURequestStepUpgrade passes adminParticipant, so only that caller needs reportActionsList (via useAllPolicyExpenseChatReportActions). Reverts the unnecessary reportActionsList: undefined from all other callers that never reach the code path where it's used. Makes the type optional (?) since most callers don't need it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3056d7bc78
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…l callers reportActionsList is only consumed inside createPolicyExpenseChats in the `if (oldChat)` branch, which requires an existing policy expense chat for the given policyID. buildPolicyData always uses a freshly generated policyID (via generatePolicyID()), so getPolicyExpenseChat() can never find an existing chat, and reportActionsList is never read. Additionally, most callers don't pass adminParticipant, so createPolicyExpenseChats is never even called from buildPolicyData. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Thanks for the review — both comments are valid. After analysis, Why
|
| Caller | Passes adminParticipant? |
policyID |
reportActionsList reachable? |
|---|---|---|---|
IOURequestStepUpgrade onUpgrade |
Yes | undefined → generatePolicyID() (fresh) |
No — fresh policyID means getPolicyExpenseChat() returns undefined, if (oldChat) branch never entered |
IOURequestStepUpgrade onWorkspaceConfirmationSubmit |
No | params.policyID (from generatePolicyID() in WorkspaceConfirmationForm) |
No — no adminParticipant, createPolicyExpenseChats never called |
| BaseOnboardingInterestedFeatures | No | generatePolicyID() (fresh) |
No |
| BaseOnboardingWorkspaceOptional | No | Not passed → generatePolicyID() (fresh) |
No |
| BaseOnboardingWorkspaceConfirmation | No | generatePolicyID() (fresh) |
No |
| WorkspaceConfirmationForTravelPage | No | params.policyID (from generatePolicyID()) |
No |
| useAutoCreateTrackWorkspace | No | generatePolicyID() (fresh) |
No |
| SettlementButton | No | Not passed → generatePolicyID() (fresh) |
No |
App.ts savePolicyDraftByNewWorkspace |
No | Always from generatePolicyID() |
No |
TrackExpense.ts buildPolicyData |
No | policy?.id (could be existing) |
No — no adminParticipant |
PayMoneyRequest.ts buildPolicyData |
No | payerPolicyID (existing) |
No — no adminParticipant |
Conclusion
-
Only one caller (
IOURequestStepUpgrade.onUpgrade) passesadminParticipant— but it usespolicyID: undefinedwhich defaults togeneratePolicyID(). A freshly generated policyID can never match an existing policy expense chat, sogetPolicyExpenseChat()always returnsundefinedand theif (oldChat)branch is never entered. -
All other callers don't pass
adminParticipant, socreatePolicyExpenseChatsis never called frombuildPolicyData.
I've removed reportActionsList from BuildPolicyDataOptions, reverted the hook from IOURequestStepUpgrade.tsx, and added an explanatory comment + TODO at the call site in buildPolicyData.
…t creation - Verify no memberData when adminParticipant is not provided - Verify optimistic expense chat report is generated when adminParticipant is provided - Verify each workspace gets a unique expense chat (fresh policyID guarantees new chat) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@parasharrajat Ready to review |
…easy callers) Part 1 of removing Onyx.connect() for ONYXKEYS.COLLECTION.REPORT_ACTIONS in buildAddMembersToWorkspaceOnyxData. Adds an optional reportActionsList param so UI callers pass the value from useAllPolicyExpenseChatReportActions() instead of the module-scoped deprecatedAllReportActions cache. Threads through the easy paths: - addMembersToWorkspace (BaseOnboardingWorkspaceInvite, WorkspaceInviteMessageComponent) - changeReportPolicyAndInviteSubmitter (ReportChangeWorkspacePage) shareTrackedExpense path is deferred to a follow-up PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # src/pages/OnboardingWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@parasharrajat All your |
DylanDylann
changed the title
parasharrajat
approved these changes
Apr 26, 2026
Member
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
26.04.2026_15.18.54_REC.mp4
26.04.2026_15.23.20_REC.mp4
🎀 👀 🎀 C+ reviewed
Gonals
approved these changes
Apr 27, 2026
Contributor
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.62-5 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
I reviewed the changes in this PR. It is a purely internal code refactoring that:
There are no UI changes, no new features, no renamed settings or labels, and no changes to user-facing behavior. This is entirely about deprecating an internal module-scoped Onyx connection. No changes are required to the help site files under |
Contributor
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR is part of deprecating the module-scoped
Onyx.connect()cachedeprecatedAllReportActionsinsrc/libs/actions/Policy/Policy.ts. ThedeprecatedAllReportActionsis read insidecreatePolicyExpenseChats(line 1578) when theif (oldChat)branch is entered. We want callers to supply areportActionsListexplicitly (from theuseAllPolicyExpenseChatReportActions()hook) instead of relying on the module-scoped fallback.This PR covers two distinct pieces of that work on the same branch:
1.
buildPolicyData—reportActionsListremoved as dead codeAfter per-caller analysis, every caller of
buildPolicyDataends up invokingcreatePolicyExpenseChatswith a freshpolicyID(fromgeneratePolicyID()), soReportUtils.getPolicyExpenseChat(cleanAccountID, policyID)always returnsundefinedand theif (oldChat)branch is never entered. ThereportActionsListargument was therefore dead code on this path and has been removed — see the investigation in this PR comment for the case-by-case table.2.
buildAddMembersToWorkspaceOnyxData—reportActionsListthreaded through the easy caller pathsUnlike
buildPolicyData,buildAddMembersToWorkspaceOnyxDataoperates on existing policies where an invitee may already have a policy expense chat, so theif (oldChat)branch is live code. This PR adds an optionalreportActionsList?: OnyxCollection<ReportActions>parameter and threads it through the two easy caller paths:addMembersToWorkspace→BaseOnboardingWorkspaceInvite.tsx,WorkspaceInviteMessageComponent.tsxchangeReportPolicyAndInviteSubmitter→ReportChangeWorkspacePage.tsx(already uses the hook)Deferred to follow-up PRs of #66578:
shareTrackedExpense(TrackExpense.ts) path — threading throughtrackExpense→MoneyRequest.ts/Duplicate.ts/handleFileRetry.tswould balloon this PR's diff.reportActionsList, a final cleanup PR will make it required and remove the?? deprecatedAllReportActionsfallback insidecreatePolicyExpenseChats. Each newreportActionsList?:declaration carries a// TODO: Remove optional (?)comment pointing at issue RemoveOnyx.connect()for the key:ONYXKEYS.COLLECTION.REPORT_ACTIONSinsrc/libs/actions/Policy/Policy.ts#66578 to make that followup explicit.Changes:
reportActionsListfromBuildPolicyDataOptionsand thebuildPolicyData→createPolicyExpenseChatshand-off (dead code)reportActionsList?: OnyxCollection<ReportActions>parameter tobuildAddMembersToWorkspaceOnyxDataandaddMembersToWorkspaceinsrc/libs/actions/Policy/Member.tsreportActionsList?: OnyxCollection<ReportActions>to the typed object param ofchangeReportPolicyAndInviteSubmitterinsrc/libs/actions/Report/index.tsBaseOnboardingWorkspaceInvite.tsx,WorkspaceInviteMessageComponent.tsx,ReportChangeWorkspacePage.tsx) to pass the result ofuseAllPolicyExpenseChatReportActions()tests/actions/PolicyMemberTest.tsthat verifiesaddMembersToWorkspaceuses the explicitreportActionsListparam (not the deprecated Onyx fallback) when unarchiving an existing expense reportbuildPolicyData→adminParticipantexpense chat creation path (covers the scenario wherereportActionsListwas removed)Fixed Issues
$ #66578
PROPOSAL:
Tests
Offline tests
N/A - This is a refactoring change that does not affect offline behavior.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A - Refactoring only, no UI changes.