BT - Migrate QBD Export Routes#88352
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba4c5c2500
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
66985a4 to
ba4c5c2
Compare
Screen.Recording.2026-05-02.at.22.58.25.movWhen I open it from the company card, the back navigation doesn’t work |
|
@huult This is fixed and ready for retest. web-bt-qbd-export.mov |
|
@mananjadhav Could you update the ESLint errors? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-07.at.09.50.22.mp4Android: mWeb ChromeScreen.Recording.2026-05-07.at.09.52.15.mp4iOS: HybridAppScreen.Recording.2026-05-07.at.09.54.59.mp4iOS: mWeb SafariScreen.Recording.2026-05-07.at.09.55.48.mp4MacOS: Chrome / SafariScreen.Recording.2026-05-07.at.09.46.33.mp4 |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.69-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a purely technical refactor that migrates QuickBooks Desktop export routes to use dynamic routes. It changes internal URL path definitions and navigation logic but does not alter any user-facing features, labels, settings, or functionality. The existing help site articles about QuickBooks Desktop configuration remain accurate. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀
|
Explanation of Change
Fixed Issues
$ #83839
PROPOSAL:
Tests
QuickBooks Desktop company card expense account (
workspaces/:policyID/accounting/quickbooks-desktop/export/qbd-company-card-expense-account)/qbd-company-card-expense-account(e.g.workspaces/<policyID>/accounting/quickbooks-desktop/export/qbd-company-card-expense-account)./qbd-company-card-expense-account)./qbd-company-card-expense-account.QuickBooks Desktop company card expense account select (
workspaces/:policyID/accounting/quickbooks-desktop/export/qbd-company-card-expense-account-select)/qbd-company-card-expense-account-select(e.g.workspaces/<policyID>/accounting/quickbooks-desktop/export/qbd-company-card-expense-account-select)./qbd-company-card-expense-accountand not keep/qbd-company-card-expense-account-select)./qbd-company-card-expense-account-select.Offline tests
Same as offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as QA tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-dr-qbd-export.mov
Android: mWeb Chrome
mweb-chrome-dr-qbd-export.mov
iOS: Native
ios-dr-qbd-export.mov
iOS: mWeb Safari
mweb-safari-dr-qbd-export.mov
MacOS: Chrome / Safari
web-dr-qbd-export.mov