Add useCardFeeds regression tests for empty linkedPolicyIDs by mountiny · Pull Request #88359 · Expensify/App

mountiny · 2026-04-20T21:01:29Z

Explanation of Change

PR #88136 (merged earlier today) fixed the useCardFeeds include predicate so domain feeds whose linkedPolicyIDs is [] or [''] no longer get silently dropped, falling back to preferredPolicy / domainID matching as intended. That PR didn't add coverage in useCardFeeds.test.ts, so this PR pins the corrected behavior with regression tests against the exact onyx shape that triggered the customer issue.

linkedPolicyIDs: [''] with matching preferredPolicy -> feed is included.
linkedPolicyIDs: [] with matching preferredPolicy -> feed is included.
linkedPolicyIDs: ['OTHER_POLICY'], current policyID not in the list -> feed is excluded (regression guard for non-empty linkedPolicyIDs semantics).
linkedPolicyIDs: ['OTHER_POLICY', policyID] -> feed is included (multi-policy linkage).

I verified locally that all 4 new tests fail when the predicate is reverted to the pre-#88136 short-circuit version, and pass against main.

No production code is changed.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/548636
PROPOSAL:

Tests

Run `npx jest tests/unit/hooks/useCardFeeds.test.ts` locally.
Verify all 7 tests pass (3 existing + 4 new).
(Optional) Revert the predicate in `src/hooks/useCardFeeds.tsx` to:
```ts
if (combinedCardFeed?.linkedPolicyIDs) {
return combinedCardFeed.linkedPolicyIDs.includes(policyID);
}
```
and confirm the two new `includes domain feeds when linkedPolicyIDs ...` tests fail.

Verify that no errors appear in the JS console

Offline tests

N/A - tests-only change.

QA Steps

N/A - tests-only change, no production code modified.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Pin the corrected behavior of the include predicate in useCardFeeds: domain feeds whose `linkedPolicyIDs` is `[]` or `['']` (a legacy/invalid shape persisted by older clients and by DomainAPI's default when `preferredPolicy` was empty) should still match via `preferredPolicy` rather than being silently dropped. The predicate fix itself shipped in PR #88136; this commit adds the regression coverage that PR did not. Made-with: Cursor

melvin-bot · 2026-04-20T21:01:36Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Made-with: Cursor

nkuoch · 2026-04-21T07:14:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Copilot

Pull request overview

Adds regression coverage to ensure useCardFeeds correctly includes/excludes domain feeds based on linkedPolicyIDs edge-cases (notably [] and ['']) and multi-policy linkage, without changing production code.

Changes:

Add 4 new unit tests covering linkedPolicyIDs: [''], linkedPolicyIDs: [], non-matching non-empty linkedPolicyIDs, and multi-entry linkedPolicyIDs including the current policy.
Group the new cases under a dedicated linkedPolicyIDs predicate filtering describe block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Address Copilot review feedback on PR #88359: gate the four new linkedPolicyIDs tests on `result.current[1].status === 'loaded'` (the ResultMetadata from useOnyx) before running the assertion, so that negative checks don't pass vacuously while Onyx is still loading. Verified locally that all 7 tests pass on main, and that reverting the predicate to its pre-#88136 form still correctly fails the `linkedPolicyIDs: ['']` and `linkedPolicyIDs: []` regression tests. Made-with: Cursor

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…eed helper Addresses Copilot's DRY suggestion on PR #88359 by extracting a single setupDomainFeed helper at the top of the linkedPolicyIDs predicate filtering describe block. Each of the four tests now reads as a single line of intent: the setup payload and the .toBe(true|false) expectation. Made-with: Cursor

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Addresses Copilot review comment on PR #88359 (#88359 (comment)): the four new tests previously matched feeds via key.includes(oauthFeed) and gated on result.current[1].status === 'loaded' (an Onyx implementation detail). Now compute the exact combined feed key with getCardFeedWithDomainID and put toHaveProperty([combinedFeedKey]) inside waitFor for the three positive cases, so the wait resolves on the actual expectation. The negative case keeps the loaded-status gate before asserting absence to avoid a vacuous pass while Onyx is still hydrating. Verified locally: - All 7 tests pass on main. - Reverting the predicate to its pre-#88136 form still fails the two linkedPolicyIDs: [''] / [] regression tests. Made-with: Cursor

OSBotify · 2026-04-21T11:44:14Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

IuliiaHerets · 2026-04-21T20:45:55Z

Hi @mountiny. Do we need QA this?

cc @nkuoch

mountiny requested a review from a team as a code owner April 20, 2026 21:01

melvin-bot Bot assigned mountiny Apr 20, 2026

melvin-bot Bot requested review from ChavdaSachin and removed request for a team April 20, 2026 21:01

mountiny removed the request for review from ChavdaSachin April 20, 2026 21:02

Remove unnecessary regression guard comment

5d7821b

Made-with: Cursor

nkuoch previously approved these changes Apr 21, 2026

View reviewed changes

nkuoch requested a review from Copilot April 21, 2026 07:14

Copilot started reviewing on behalf of nkuoch April 21, 2026 07:14 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread tests/unit/hooks/useCardFeeds.test.ts Outdated

Comment thread tests/unit/hooks/useCardFeeds.test.ts Outdated

mountiny dismissed nkuoch’s stale review via 9f7b894 April 21, 2026 07:59

nkuoch requested a review from Copilot April 21, 2026 08:04

Copilot started reviewing on behalf of nkuoch April 21, 2026 08:04 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread tests/unit/hooks/useCardFeeds.test.ts

nkuoch requested a review from Copilot April 21, 2026 08:45

Copilot started reviewing on behalf of nkuoch April 21, 2026 08:45 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread tests/unit/hooks/useCardFeeds.test.ts

nkuoch approved these changes Apr 21, 2026

View reviewed changes

nkuoch merged commit f082f75 into main Apr 21, 2026
34 checks passed

nkuoch deleted the vit-fix-domain-feed-predicate branch April 21, 2026 09:26

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add useCardFeeds regression tests for empty linkedPolicyIDs#88359

Add useCardFeeds regression tests for empty linkedPolicyIDs#88359
nkuoch merged 5 commits intomainfrom
vit-fix-domain-feed-predicate

mountiny commented Apr 20, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Apr 20, 2026

Uh oh!

nkuoch commented Apr 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

IuliiaHerets commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mountiny commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 20, 2026

Uh oh!

nkuoch commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

IuliiaHerets commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mountiny commented Apr 20, 2026 •

edited

Loading

nkuoch commented Apr 21, 2026 •

edited

Loading