decompose ReportActionsList: 1#88392
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…-actions-list-presentation
…-actions-list-presentation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a774a1d6c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Sorry for the ping @jayeshmangwani |
|
@adhorodyski I think we should create a folder to contain the ReportActionsList component and its child components. |
Definitely, let's do the folder split in a separate PR to keep the diff small here. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-29.at.23.27.54.movAndroid: mWeb ChromeScreen.Recording.2026-04-29.at.23.23.43.moviOS: HybridAppScreen.Recording.2026-04-29.at.23.24.31.moviOS: mWeb SafariScreen.Recording.2026-04-29.at.23.21.54.movMacOS: Chrome / SafariScreen.Recording.2026-04-29.at.23.14.32.mov |
|
The rest looks fine to me |
|
Thanks, addressing now |
|
@adhorodyski We got a minor failed lint |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.66-0 🚀
|
|
No help site changes are required for this PR. This is a pure internal code refactoring — it extracts two presentation components ( |
@DylanDylann @rlinoz
Explanation of Change
First PR of a multi-PR series decomposing
ReportActionsList.tsx(915 LOC). This PR extracts two presentation components (ShowPreviousMessagesButton,ReportActionsListHeader) with internal render gates (CLEAN-REACT-PATTERNS-2). Call-site behavior gates are preserved — this is pure code movement, zero user-visible change. Later PRs in the series will extract hooks and remove the preserved gates as part of compiler cleanup.Fixed Issues
$ #88320
PROPOSAL:
Tests
Both
ShowPreviousMessagesButton+ReportActionsListHeaderare only used in the Concierge side panel.Setup
ShowPreviousMessagesButtonReportActionsListHeaderConciergeThinkingMessagerenders at the bottom of the list (next to composer) when applicable.ListBoundaryLoaderrenders at the bottom (newer-direction loader). When loading newer chats fails, tap retry → reload triggers correctly.ConciergeThinkingMessagedoes not appear.Regression checks
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Part of a 12-PR series. Full plan: not public, internal.