[No QA] Docs updates for E/A#88181 Update search groupings and suggested search names

[MelvinBot]

Summary

• Updates help site articles to reflect renamed search groupings and suggested search labels from Update search groupings and suggested search names in LHN #88181
• Replaces old section names (To-do, Explore, Monthly accrual) with new ones (Expense reports, Accounting)
• Updates all suggested search name references: Submit → Drafts, Approve → Needs approval, Pay → Ready to pay, Export → Awaiting export, Unapproved cash → Cash accruals, Unapproved card → Card accruals, Statements → Card statements, Reconciliation → Bank reconciliation

Files changed

• docs/articles/new-expensify/reports-and-expenses/Using-Search-on-the-Reports-Page.md — Major rewrite to match new section structure
• docs/articles/new-expensify/reports-and-expenses/Unapproved-Spend.md — Updated navigation paths and view names
• docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md — Updated navigation path
• docs/articles/new-expensify/wallet-and-payments/Pay-Expenses.md — Updated navigation paths
• docs/articles/new-expensify/wallet-and-payments/Reimbursement-Payment-Methods.md — Updated navigation paths

Test plan

• Verify all renamed labels match the updated UI from Update search groupings and suggested search names in LHN #88181
• Verify navigation paths are accurate for both web and mobile
• Verify no remaining references to old terminology (To-do, Explore, Monthly accrual, Unapproved cash/card as section names)

[OSBotify]

A preview of your ExpensifyHelp changes have been deployed to https://6a70c8b8.helpdot.pages.dev ⚡️

Updated articles:

• articles/new-expensify/reports-and-expenses/Accounting-Search-Shortcuts
• articles/new-expensify/reports-and-expenses/Approve-Expenses
• articles/new-expensify/reports-and-expenses/Use-Search-Shortcuts

[trjExpensify]

@stephanieelliott Spend is on prod #88010

[stephanieelliott]

Jumping on this one now, will resolve the conflicts in Cursor since they are pretty complex.

[stephanieelliott]

@trjExpensify we need to rename the page Unapproved Spend to something else -- any ideas?

Typically we would rename it to match the label (so "Accounting"), but I feel like that's going to be confusing - this is page describes spend, rather than information about integrations.

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR updates four help articles to reflect renamed search groupings and suggested search labels (To-do becomes Expense reports, Explore is removed, Monthly accrual becomes Accounting, and shortcuts are renamed). The changes are well-scoped and the new Reconcile-Expenses-With-Accounting.md article is a solid replacement for the deleted Unapproved-Spend.md. However, there are a few governance violations that should be resolved before merge.

Scores Summary

• Readability: 8/10 - Changes are clear and scannable. Steps are well-structured and action-oriented. Minor awkward phrasing in the opening paragraph of the Search article ("Search shortcuts on the Spend page to apply..." is missing a verb).
• AI Readiness: 7/10 - YAML metadata is present on new/rewritten files with internalScope (good). However, there is a YAML syntax error in Using-Search-on-the-Spend-Page.md (trailing period after keywords array bracket), and one heading in the new article is noun-based rather than task-based.
• Style Compliance: 6/10 - Several issues: "Click More" appears in changed lines of Approve-Expenses.md (violates three dots menu rule); a cross-link is missing its leading slash; and there is a "Needs approvals" vs "Needs approval" inconsistency.

Key Findings

Must fix:

1. YAML syntax error (Using-Search-on-the-Spend-Page.md): keywords: [...]. has a trailing period after the closing bracket. This will break YAML parsing.
2. Cross-link missing leading slash (Using-Search-on-the-Spend-Page.md, line ~42): (articles/new-expensify/reports-and-expenses/Reconcile-Expenses-With-Accounting) should be (/articles/new-expensify/reports-and-expenses/Reconcile-Expenses-With-Accounting). Per governance, cross-links must use relative links with correct paths.
3. "Needs approvals" vs "Needs approval" (Approve-Expenses.md, line ~100): The reject-a-report section says Spend > Needs approvals (plural) while other references in the PR use "Needs approval" (singular). Only one can match the UI -- verify and make consistent.

Should fix:
4. Noun-based heading (Reconcile-Expenses-With-Accounting.md): ## What each Accounting view shows is a noun/topic heading, not task-based. Per HELP_AUTHORING_GUIDELINES.md Section 2, all ## headings must start with an action verb or question word. Suggested fix: ## What does each Accounting view show or ## What each Accounting view shows you.
5. "Click More" pattern (Approve-Expenses.md, lines ~73, 85, 98): Multiple changed lines use "Click More" or "Open the More dropdown". Per HELPSITE_NAMING_CONVENTIONS.md, this must be "Select the three dots (⋮)" -- never "Click More" or "More menu". Note: Some of these may be pre-existing in unchanged lines. Only the instances in added/modified lines need updating (lines ~98 "Click More" in the new reject-report description, and line ~119 "Open the More dropdown").
6. Incomplete opening sentence (Using-Search-on-the-Spend-Page.md, line ~8): "Search shortcuts on the Spend page to apply pre-built filters..." is missing a verb. Should read something like "Search shortcuts on the Spend page apply pre-built filters..." or "Use search shortcuts on the Spend page to apply pre-built filters..."
7. Typo (Using-Search-on-the-Spend-Page.md, line ~42): "reconciliaton" should be "reconciliation".

Positive aspects:

• Good use of internalScope in new YAML frontmatter, clearly defining audience and scope boundaries.
• The replacement of Unapproved-Spend.md with Reconcile-Expenses-With-Accounting.md improves clarity and better reflects the new UI structure.
• The rewrite of Using-Search-on-the-Spend-Page.md is significantly more concise and focused than the original, adhering to the single-workflow principle.
• FAQ sections are well-structured with question-word headings.
• Navigation instructions correctly use the unified format per governance.

Recommendations

1. Priority: Fix the YAML syntax error in keywords (remove trailing period).
2. Priority: Add the leading slash to the cross-link path for the Reconcile article.
3. Priority: Resolve the "Needs approval" vs "Needs approvals" inconsistency by checking the actual UI label.
4. Rephrase ## What each Accounting view shows to start with a question word (e.g., "What does each...").
5. Replace "Click More" and "Open the More dropdown" with "Select the three dots (⋮)" in all modified lines.
6. Fix the opening sentence fragment and the "reconciliaton" typo in the Search article.

Files Reviewed

• Approve-Expenses.md - Navigation paths updated correctly; "Needs approvals" inconsistency and "Click More" pattern need attention in changed lines.
• Reconcile-Expenses-With-Accounting.md (NEW) - Well-structured replacement article; one noun-based heading to fix.
• Using-Search-on-the-Spend-Page.md (REWRITE) - Much improved; YAML syntax error, missing slash in cross-link, sentence fragment, and typo need fixes.
• Unapproved-Spend.md (DELETED) - Clean removal, properly replaced by the new Reconcile article.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bbcc91e8f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[github-actions]

AI readiness (heading rule): Per HELP_AUTHORING_GUIDELINES.md Section 2, all ## headings must start with an action verb or question word (How, What, Where, Who, Why, When). "What each Accounting search shortcut shows you" does start with "What," but it reads more as a descriptive label than a user question. Consider rephrasing to a clearer question format:

## What does each Accounting search shortcut show you

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR replaces two older documentation articles with two well-structured new articles ("Accounting Search Shortcuts" and "Use Search Shortcuts") and updates navigation references in the existing "Approve Expenses" article to reflect UI changes (e.g., "Reports > Expenses" becomes "Spend > All expenses"). Deleted articles are properly redirected. Overall, this is a strong set of changes that aligns well with governance standards.

Scores Summary

• Readability: 9/10 - Clear, scannable content. Steps are concise and action-oriented. Both new articles introduce the feature, explain who can use it, how to use it, and what happens after. Minor inconsistency in the "What happens after" section of Accounting-Search-Shortcuts.md, which lists capabilities ("You can...") rather than describing system behavior or outcomes.
• AI Readiness: 9/10 - Both new articles include complete YAML metadata (title, description, keywords, internalScope). Headings are task-based and start with action verbs or question words. Heading hierarchy uses only # and ## as required. Feature names are included in headings.
• Style Compliance: 8/10 - UI elements are properly bolded. Navigation phrasing follows the unified pattern. However, there is an inconsistency in navigation wording between the new files and the modified file: new articles use "on the left on web, on the bottom on mobile" while Approve-Expenses.md changes retain "on the left on web, and at the bottom on mobile" (with "and at"). Both patterns appear in the diff, which creates inconsistency within this PR. Additionally, step 1 in Accounting-Search-Shortcuts.md is missing a comma after the closing parenthesis before "select."

Key Findings

• Both new articles follow the one-workflow-per-article principle effectively, with Accounting shortcuts scoped to Workspace Admins and general search shortcuts scoped to all members.
• Cross-links are well-placed: outside numbered steps, using descriptive anchor text ("Learn how to export expenses to a CSV," "learn how to use search operators"), and using relative paths. This fully complies with the cross-linking standards.
• The deleted articles (Unapproved-Spend.md and Using-Search-on-the-Spend-Page.md) had several governance violations (multiple # headings, noun-only headings like "Best Practices" and "Member Views and Access," missing internalScope). The replacements resolve all of these issues.
• Redirects are correctly added in redirects.csv for both deleted articles.
• The Approve-Expenses.md changes correctly update navigation paths to match the new UI terminology (Spend > All expenses, Spend > All reports, Spend > Needs approval) and add a helpful context sentence to the "How to reject a report" section.

Recommendations

• Standardize navigation phrasing across this PR. The new articles use "on the bottom on mobile" while Approve-Expenses.md uses "and at the bottom on mobile." Pick one pattern and apply it consistently. The governance example is "on the left on web, on the bottom on mobile" (without "and at"), so the new articles have the correct form.
• Add a comma after the navigation parenthetical in Accounting-Search-Shortcuts.md step 1. Currently reads: "...on the bottom on mobile) select Spend." Should be: "...on the bottom on mobile), select Spend." (The Use-Search-Shortcuts.md file has this comma correctly.)
• Consider revising the "What happens after" section in Accounting-Search-Shortcuts.md to describe outcomes or system behavior rather than listing user capabilities. Per the template, this section should explain what the system does after the task is completed.

Files Reviewed

• Accounting-Search-Shortcuts.md (NEW) - Strong article. Proper YAML, heading structure, and FAQ. Minor punctuation and "What happens after" framing issues noted above.
• Use-Search-Shortcuts.md (NEW) - Clean, well-structured article. Compliant with all governance rules. Good cross-linking to both the Accounting shortcuts article and search operators article.
• Approve-Expenses.md (MODIFIED) - Navigation paths correctly updated to match new UI. Added context sentence for the reject workflow is a helpful improvement.
• Unapproved-Spend.md (DELETED) - Properly redirected.
• Using-Search-on-the-Spend-Page.md (DELETED) - Properly redirected.
• redirects.csv (MODIFIED) - Two correct redirect entries added.

Note: This review covers only the proposed changes in the diff, not unchanged portions of files.

[melvin-bot]

@trjExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[github-actions]

Readability: Subject-verb disagreement. "The Accounting search shortcuts...bring together..." (plural) is followed by "It helps you identify..." (singular). Change "It helps" to "They help" to match the plural subject.

[github-actions]

Naming and style (navigation phrasing): Per HELPSITE_NAMING_CONVENTIONS.md, the standard unified navigation sentence is: "Click the navigation tabs (on the left on web, on the bottom on mobile)." This line uses "In the navigation tabs (on the left on web, on the bottom on mobile) select Spend" which deviates from the standard. Also, a comma is missing after the closing parenthesis before "select".

Suggested fix: "Click the navigation tabs (on the left on web, on the bottom on mobile), then select Spend."

[github-actions]

Naming and style (navigation phrasing): Per HELPSITE_NAMING_CONVENTIONS.md, the standard unified navigation sentence is: "Click the navigation tabs (on the left on web, on the bottom on mobile)." This line uses "In the navigation tabs (on the left on web, on the bottom on mobile), select Spend" which deviates from the standard.

Suggested fix: "Click the navigation tabs (on the left on web, on the bottom on mobile), then select Spend."

[github-actions]

Readability: The second paragraph ("Workspace Admins can use these shortcuts to validate totals, track liabilities, and ensure your expenses align...") switches from third person "Workspace Admins" to second person "your expenses." Consider using consistent second person throughout, e.g., "You can use these shortcuts to validate totals, track liabilities, and ensure expenses align with your accounting records before and after export." (The "Who can use" section already establishes the audience as Workspace Admins.)

[github-actions]

Cross-linking (link placement): Per HELP_AUTHORING_GUIDELINES.md Section 7, "Do not place links inside numbered step instructions. Do not interrupt procedural flow with inline links." This link appears immediately after the numbered steps and is part of the procedural section. This is borderline acceptable since it's after the steps rather than within them, but consider moving it to a separate paragraph with a clearer visual break from the steps.

[github-actions]

Structure / formatting: The bullet list items in this section have a leading space before the dash ( - You can...). While this renders correctly in most Markdown parsers, standard Markdown convention is to start list items without the leading space for consistency with the rest of the article (e.g., the bullet list under "What each Accounting search shortcut shows you" on line 43 has no leading space).

[github-actions]

Cross-linking (link placement): Per HELP_AUTHORING_GUIDELINES.md Section 7, links should be placed "After explanatory sentences" and "In conditional dependency statements," not in introductory paragraphs that precede the main content. This link to search operators in the intro could dilute the primary workflow focus. Consider moving it to the end of the article or to a "Related articles" section.

[github-actions]

Structure / formatting: The bullet list items here use a leading space before the dash ( - **Submitters:**...), but the list under "How to use search shortcuts" on line 36 does not. Use consistent list formatting throughout the article -- either all with or all without the leading space.

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR replaces two older articles (Unapproved-Spend.md and Using-Search-on-the-Spend-Page.md) with two well-structured new articles (Accounting-Search-Shortcuts.md and Use-Search-Shortcuts.md), updates navigation references in Approve-Expenses.md to match the current UI (e.g., Reports to Spend, Expenses to All expenses), and adds proper redirects. The new articles are a significant quality improvement over their predecessors, following governance standards closely with correct heading hierarchy, complete metadata, and clear procedural steps.

Scores Summary

• Readability: 9/10 - Both new articles are clear, scannable, and well-organized with concise steps and logical flow. The bullet-list descriptions in Accounting-Search-Shortcuts.md are especially effective for quickly understanding each shortcut. Minor nit: the intro paragraph in Accounting-Search-Shortcuts.md switches between "it helps" (singular) and the plural subject "shortcuts."
• AI Readiness: 9/10 - Strong YAML metadata with realistic keywords, good internalScope definitions, task-based headings throughout, and proper heading hierarchy (single # title, ## sections, # FAQ). Both new articles include "How to" headings with the feature name as required.
• Style Compliance: 9/10 - UI elements are properly bolded, navigation instructions use the correct unified sentence pattern, and cross-links use descriptive anchor text with relative paths. The Approve-Expenses.md changes correctly update UI labels to match current navigation (Spend > All expenses, Spend > All reports, Spend > Needs approval).

Key Findings

Positive aspects:

• Excellent adherence to the one-workflow-per-article principle -- the old Using-Search-on-the-Spend-Page.md mixed multiple concerns (To-do vs. Explore, member views, best practices) which are now cleanly separated
• Both new articles follow the template structure faithfully: Who can use, How to, What happens after, FAQ
• Cross-links are well-placed (after explanatory text, never inside numbered steps) with descriptive anchor text
• Redirects are correctly added for both deleted articles
• The internalScope fields clearly define audience and boundaries, which is excellent for retrieval scoping

Items to consider (minor):

• Accounting-Search-Shortcuts.md, line 10: "It helps you identify..." -- the subject is "shortcuts" (plural), so this should read "They help you identify..." for grammatical agreement
• Accounting-Search-Shortcuts.md, line 28: Missing comma after the navigation parenthetical -- should be "...on the bottom on mobile), select Spend" to match the punctuation pattern used in Use-Search-Shortcuts.md line 31
• Use-Search-Shortcuts.md: The title "Use Search Shortcuts" is slightly less discoverable than "How to Use Search Shortcuts" -- though the current form is acceptable per governance rules since the # heading matches the YAML title

Observation (not scored, outside diff scope):

• Approve-Expenses.md contains several references to "Click More" and "Open the More dropdown" in unchanged lines (lines 75, 87, 103, 121). These may violate the Three Dots Menu Rule if the UI element is actually the three dots menu (which should be written as "Select the three dots (⋮)"). This is pre-existing and outside the scope of this PR's changes, but worth noting for a future cleanup pass.

Recommendations

1. Fix the subject-verb agreement in Accounting-Search-Shortcuts.md intro paragraph ("It helps" to "They help")
2. Add the missing comma after the navigation parenthetical in Accounting-Search-Shortcuts.md step 1 to maintain consistency with the other new article
3. Consider a follow-up PR to audit the "Click More" references in Approve-Expenses.md against the Three Dots Menu Rule

Files Reviewed

• docs/articles/new-expensify/reports-and-expenses/Accounting-Search-Shortcuts.md (NEW) -- Well-structured article covering accounting search shortcuts with complete metadata, proper heading hierarchy, and clear procedural steps
• docs/articles/new-expensify/reports-and-expenses/Use-Search-Shortcuts.md (NEW) -- Clean, role-aware article on search shortcuts with good cross-linking to both the Accounting shortcuts article and search operators
• docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md (MODIFIED) -- Navigation references correctly updated to match current UI labels
• docs/articles/new-expensify/reports-and-expenses/Unapproved-Spend.md (DELETED) -- Appropriately replaced by Accounting-Search-Shortcuts.md
• docs/articles/new-expensify/reports-and-expenses/Using-Search-on-the-Spend-Page.md (DELETED) -- Appropriately replaced by Use-Search-Shortcuts.md
• docs/redirects.csv (MODIFIED) -- Correctly maps both deleted articles to their replacements

This review assessed only the proposed changes in the PR diff, per HelpDot governance files.

[stephanieelliott]

@MelvinBot why was this PR reviewed multiple times by github-actions? There is supposed to be just one review, done at the time when the PR is submitted.

[MelvinBot]

The "PR Reviews with Claude Code" workflow runs on every push to the PR branch, not just the initial submission. Each run posts new review comments as github-actions[bot], and previous comments are not dismissed or cleaned up.

This PR had many pushes (15 commits across Apr 23–24), and the workflow ran at least 5 times, producing 38 total review comments in batches that correlate with each push:

Time (UTC)	Review comments	Likely trigger commit
Apr 23, 22:38	7	bbcc91e8 (22:34)
Apr 23, 23:32	8	da1f6676 (23:27)
Apr 24, 18:51	1	5f898ece (20:27)
Apr 24, 20:33–20:52	22	d6533584 + subsequent pushes

This is expected behavior for any PR with multiple pushes — the workflow re-reviews on each synchronize event. If the intent is a single review at submission time only, the workflow trigger would need to be changed from synchronize to only opened / ready_for_review.

[OSBotify]

🚀 Deployed to staging by https://github.com/trjExpensify in version: 9.3.62-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[OSBotify]

🚀 Deployed to staging by https://github.com/trjExpensify in version: 9.3.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS