Skip to content

[Home Page] Add Locked VBA (Verified Bank Account) widget to Time Sensitive#88429

Merged
mountiny merged 26 commits intoExpensify:mainfrom
software-mansion-labs:@adamgrzybowski/time-sensitive-locked-VBA
May 4, 2026
Merged

[Home Page] Add Locked VBA (Verified Bank Account) widget to Time Sensitive#88429
mountiny merged 26 commits intoExpensify:mainfrom
software-mansion-labs:@adamgrzybowski/time-sensitive-locked-VBA

Conversation

@adamgrzybowski
Copy link
Copy Markdown
Contributor

@adamgrzybowski adamgrzybowski commented Apr 21, 2026

Explanation of Change

  • Added a new Time Sensitive widget that detects locked workspace and personal bank accounts and surfaces a clear "Fix" call to action.
  • Wired the Fix action to the InitiateBankAccountUnlock flow so users are guided to Concierge for manual unlock assistance instead of dead-ending in settings.
  • Added UI and copy support for the locked-account state, including localized strings and a lock-themed widget treatment that matches the danger context.
  • Added coverage for the new locked bank account detection/rendering path in the Time Sensitive section to reduce regression risk.

Fixed Issues

$ #83939
PROPOSAL:

Tests

Offline tests

QA Steps

Note (expected behavior): After re-login, only the default workspace's bank account data is loaded automatically. As a result, the Locked VBA widget will only appear for the user's default workspace immediately after re-login. For non-default workspaces, the widget will appear once that workspace's data is loaded (e.g., after navigating to it). This matches existing behavior agreed upon in similar prior cases and is not a regression.

  1. In staging, sign in as a workspace admin with a workspace bank account in LOCKED state and open the Home page. Verify a Time Sensitive card appears with the locked business bank account messaging and a danger-styled Fix CTA.
  2. Tap/click Fix on the workspace locked account widget. Verify the unlock flow is initiated and you are routed to Concierge chat where the unlock request context is visible.
  3. In staging, sign in as a user with a personal bank account in LOCKED state and open the Home page. Verify a Time Sensitive card appears with the personal locked bank account messaging and Wallet subtitle.
  4. Tap/click Fix on the personal locked account widget. Verify Concierge navigation occurs and no dead-end navigation to settings happens.
  5. Verify the widget is not shown for users without locked bank accounts, and existing Time Sensitive widgets still render in expected order.
  6. Verify no errors appear in the JS console while loading the Home page and while pressing Fix.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Pending - screenshots/videos will be added before merge.

Android: mWeb Chrome

Pending - screenshots/videos will be added before merge.

iOS: Native

Pending - screenshots/videos will be added before merge.

iOS: mWeb Safari

Pending - screenshots/videos will be added before merge.

MacOS: Chrome / Safari
Screen.Recording.2026-04-21.at.15.03.20.mov

Pending - screenshots/videos will be added before merge.

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 21, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@adamgrzybowski
Copy link
Copy Markdown
Contributor Author

@mountiny 🦜 🙏

@adamgrzybowski adamgrzybowski marked this pull request as ready for review April 21, 2026 13:29
@adamgrzybowski adamgrzybowski requested review from a team as code owners April 21, 2026 13:29
@melvin-bot melvin-bot Bot requested review from JmillsExpensify, ZhenjaHorbach and dubielzyk-expensify and removed request for a team April 21, 2026 13:29
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 21, 2026

@dubielzyk-expensify @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c06d290a2e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/home/TimeSensitiveSection/hooks/useTimeSensitiveLockedBankAccount.ts Outdated
Comment thread src/pages/home/TimeSensitiveSection/index.tsx Outdated
@shawnborton
Copy link
Copy Markdown
Contributor

Screenshots look good to me.

@mountiny
Copy link
Copy Markdown
Contributor

@codex review

@mountiny
Copy link
Copy Markdown
Contributor

@MelvinBot Review please

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pages/home/TimeSensitiveSection/hooks/useTimeSensitiveLockedBankAccount.ts Outdated
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @mountiny on adding unit tests for the new hook. The code is looking good- my only other question is if the necessary data is all available from app start @adamgrzybowski

@adamgrzybowski adamgrzybowski changed the title Add Locked VBA (Verified Bank Account) widget to Time Sensitive [Home Page] Add Locked VBA (Verified Bank Account) widget to Time Sensitive Apr 27, 2026
@ZhenjaHorbach
Copy link
Copy Markdown
Contributor

ZhenjaHorbach commented Apr 27, 2026

Agree with @mountiny on adding unit tests for the new hook. The code is looking good- my only other question is if the necessary data is all available from app start @adamgrzybowski

There might be an issue with non-default workspaces: after re-login we don't load this data, so Locked VBA widgets won't show for them — the Locked VBA widget is always loaded only for the default workspace after re-login. But as I recall, we had a similar case before and agreed it was fine.

@adamgrzybowski
Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach I think all change requests should be resolved

@grgia
Copy link
Copy Markdown
Contributor

grgia commented Apr 28, 2026

There might be an issue with non-default workspaces: after re-login we don't load this data, so Locked VBA widgets won't show for them — the Locked VBA widget is always loaded only for the default workspace after re-login. But as I recall, we had a similar case before and agreed it was fine.

@adamgrzybowski cc @ZhenjaHorbach

Let's mention this case as expected in QA steps so a blocker isn't opened

@ZhenjaHorbach
Copy link
Copy Markdown
Contributor

@grgia
I suppose we are done here

@JmillsExpensify
Copy link
Copy Markdown
Contributor

Yes, I think we're ready to merge.

grgia
grgia previously approved these changes Apr 30, 2026
@grgia grgia requested a review from mountiny April 30, 2026 09:14
@grgia
Copy link
Copy Markdown
Contributor

grgia commented Apr 30, 2026

@adamgrzybowski could you merge main for tests to pass? also we're blocked on @mountiny's review

@adamgrzybowski
Copy link
Copy Markdown
Contributor Author

@grgia fixed lint issues

Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will merge this as Georgia is ooo

@mountiny mountiny merged commit 49a404b into Expensify:main May 4, 2026
36 checks passed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 4, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented May 4, 2026

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.66-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot
Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR and yes, help site updates are needed.

The PR adds a new Time-sensitive widget on Home for locked bank accounts (both business and personal) with a Fix CTA. Two help site articles needed updates:

  1. Expensify Home Overview — Added locked bank accounts to the list of Time-sensitive alert types
  2. Unlock a Business Bank Account — Added mention of the Home Time-sensitive widget with the Fix button as another place users can see and act on the locked state

Draft PR created: #89494

⚠️ I was unable to add the PR to GitHub project 196 due to token permission restrictions. Please add it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants