[Home Page] Add Locked VBA (Verified Bank Account) widget to Time Sensitive#88429
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@mountiny 🦜 🙏 |
|
@dubielzyk-expensify @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c06d290a2e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Screenshots look good to me. |
|
@codex review |
|
@MelvinBot Review please |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
grgia
left a comment
There was a problem hiding this comment.
Agree with @mountiny on adding unit tests for the new hook. The code is looking good- my only other question is if the necessary data is all available from app start @adamgrzybowski
There might be an issue with non-default workspaces: after re-login we don't load this data, so Locked VBA widgets won't show for them — the Locked VBA widget is always loaded only for the default workspace after re-login. But as I recall, we had a similar case before and agreed it was fine. |
|
@ZhenjaHorbach I think all change requests should be resolved |
@adamgrzybowski cc @ZhenjaHorbach Let's mention this case as expected in QA steps so a blocker isn't opened |
|
@grgia |
|
Yes, I think we're ready to merge. |
|
@adamgrzybowski could you merge main for tests to pass? also we're blocked on @mountiny's review |
|
@grgia fixed lint issues |
mountiny
left a comment
There was a problem hiding this comment.
Thanks, I will merge this as Georgia is ooo
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.66-0 🚀
|
|
I reviewed the changes in this PR and yes, help site updates are needed. The PR adds a new Time-sensitive widget on Home for locked bank accounts (both business and personal) with a Fix CTA. Two help site articles needed updates:
Draft PR created: #89494
|
Explanation of Change
InitiateBankAccountUnlockflow so users are guided to Concierge for manual unlock assistance instead of dead-ending in settings.Fixed Issues
$ #83939
PROPOSAL:
Tests
Offline tests
QA Steps
Note (expected behavior): After re-login, only the default workspace's bank account data is loaded automatically. As a result, the Locked VBA widget will only appear for the user's default workspace immediately after re-login. For non-default workspaces, the widget will appear once that workspace's data is loaded (e.g., after navigating to it). This matches existing behavior agreed upon in similar prior cases and is not a regression.
LOCKEDstate and open the Home page. Verify a Time Sensitive card appears with the locked business bank account messaging and a danger-styledFixCTA.Fixon the workspace locked account widget. Verify the unlock flow is initiated and you are routed to Concierge chat where the unlock request context is visible.LOCKEDstate and open the Home page. Verify a Time Sensitive card appears with the personal locked bank account messaging andWalletsubtitle.Fixon the personal locked account widget. Verify Concierge navigation occurs and no dead-end navigation to settings happens.Fix.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Pending - screenshots/videos will be added before merge.
Android: mWeb Chrome
Pending - screenshots/videos will be added before merge.
iOS: Native
Pending - screenshots/videos will be added before merge.
iOS: mWeb Safari
Pending - screenshots/videos will be added before merge.
MacOS: Chrome / Safari
Screen.Recording.2026-04-21.at.15.03.20.mov
Pending - screenshots/videos will be added before merge.