Skip to content

[NoQA] Deprecate 'Send Reassure Performance Tests to Graphite' workflow#88461

Merged
mjasikowski merged 1 commit intomainfrom
vit-deprecate-reassure-graphite-workflow
Apr 21, 2026
Merged

[NoQA] Deprecate 'Send Reassure Performance Tests to Graphite' workflow#88461
mjasikowski merged 1 commit intomainfrom
vit-deprecate-reassure-graphite-workflow

Conversation

@mountiny
Copy link
Copy Markdown
Contributor

@mountiny mountiny commented Apr 21, 2026 •
edited
Loading

Explanation of Change

Removes the Send Reassure Performance Tests to Graphite workflow (.github/workflows/sendReassurePerfData.yml) and the getGraphiteString GitHub Action that only exists to support it.

This workflow triggers on every push to main, spins up a Blacksmith runner, runs npx reassure --baseline, and pipes a Graphite line-protocol string to stats.expensify.com:3003 via nc. It runs hundreds of times a week (see the workflow's run history).

Deprecating it because:

  • Performance regressions are already gated at PR time by reassurePerformanceTests.yml, which compares the PR branch against main and fails on deviation — that's the signal that actually drives decisions.
  • The Graphite dashboards fed by the post-merge numbers are not actively used and have no owner or alerting tied to them.
  • Running it on every merge to main is a real and ongoing CI cost for no tangible benefit.

Changes in this PR:

  • Delete .github/workflows/sendReassurePerfData.yml.
  • Delete .github/actions/javascript/getGraphiteString/ (action manifest, source, and compiled bundle) — this Action has no other callers.
  • Remove the getGraphiteString entry from .github/scripts/buildActions.sh so npm run gh-actions-build stays green.

No production code, no app-visible change, no developer-facing tooling change.

Fixed Issues

$ #88460
PROPOSAL: N/A (CI-only cleanup)

Tests

  1. Check out this branch.
  2. Run .github/scripts/buildActions.sh (or npm run gh-actions-build) and verify it completes successfully with no reference to getGraphiteString.
  3. Run grep -R "getGraphiteString\|sendReassurePerfData" .github and verify there are no remaining references.
  4. Open the GitHub Actions tab on this PR's branch and verify that Send Reassure Performance Tests to Graphite no longer appears in the workflow list, while Reassure Performance Tests continues to run on the PR as usual.
  • Verify that no errors appear in the JS console

Offline tests

N/A — CI-only change, no runtime behaviour.

QA Steps

[No QA] — CI-only change, no runtime or user-facing behaviour is affected. The Reassure Performance Tests PR workflow continues to guard performance regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mountiny
Deprecate Send Reassure Performance Tests to Graphite workflow
a4f8ca5 
The workflow ran on every merge to main and pushed Reassure baseline
numbers to stats.expensify.com for Graphite ingestion. Perf regressions
are already caught by the Reassure Performance Tests workflow that runs
on every PR, and the Graphite dashboards fed by this job are not used,
so this is pure CI cost.

- Delete .github/workflows/sendReassurePerfData.yml
- Delete the getGraphiteString GH Action, which is only used here
- Drop the getGraphiteString entry from buildActions.sh

Made-with: Cursor
@mountiny mountiny requested a review from a team as a code owner April 21, 2026 17:17
@melvin-bot melvin-bot Bot requested review from hungvu193 and removed request for a team April 21, 2026 17:17
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 21, 2026

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny requested review from mjasikowski and removed request for hungvu193 April 21, 2026 17:27
@mjasikowski mjasikowski merged commit 67a0cc0 into main Apr 21, 2026
37 of 40 checks passed
@mjasikowski mjasikowski deleted the vit-deprecate-reassure-graphite-workflow branch April 21, 2026 19:34
@mjasikowski mjasikowski changed the title Deprecate 'Send Reassure Performance Tests to Graphite' workflow [NoQA] Deprecate 'Send Reassure Performance Tests to Graphite' workflow Apr 21, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 21, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Apr 23, 2026
Open
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 23, 2026

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.62-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjasikowski mjasikowski mjasikowski approved these changes

Assignees

@mountiny mountiny

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mountiny @OSBotify @mjasikowski