Fix category tax value not syncing on expense creation by MelvinBot · Pull Request #88477 · Expensify/App

MelvinBot · 2026-04-21T20:34:14Z

Explanation of Change

When selecting a category with a default tax rate, getCategoryTaxCodeAndAmount computes and sets taxCode and taxAmount but never sets taxValue. This creates a mismatch where taxCode points to the correct rate (e.g. 5%) but taxValue retains its stale value (e.g. "0%").

This causes:

The tax field displays "0%" instead of the category's assigned rate
hasTaxRateWithMatchingValue returns false (stale taxValue vs actual rate)
TaxController/confirmation list resets tax to policy default
"Tax no longer valid" error on submit

Fix: Return categoryTaxValue from getCategoryTaxCodeAndAmount and use setMoneyRequestTaxRateValues to set taxCode, taxValue, and taxAmount atomically. Also apply the same fix in getUpdatedTransaction for the edit-expense flow.

Fixed Issues

$ #86473
PROPOSAL: #86473 (comment)

Tests

Precondition: A control workspace with Rules and Taxes enabled with additional non-default tax rate

Open categories, click the Advertising push row, set the Default tax rate to a non-default tax rate from the workspace
Navigate to the workspace chat, start creating a scan expense, upload a receipt
Click the category push row on the confirmation page, select Advertising
Verify the tax rate linked with the category is set
Click "Create expense"
Verify that "Tax no longer valid" error is not shown and the expense can be created

Offline tests

N/A — this change only affects how tax values are set when selecting a category. No new offline-specific behavior is introduced.

QA Steps

Precondition: A control workspace with Rules and Taxes enabled with additional non-default tax rate

Open categories, click the Advertising push row, set the Default tax rate to a non-default tax rate from the workspace
Navigate to the workspace chat, start creating a scan expense, upload a receipt
Click the category push row on the confirmation page, select Advertising
Verify the tax rate linked with the category is set
Click "Create expense"
Verify that "Tax no longer valid" error is not shown and the expense can be created

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

When selecting a category with a default tax rate, getCategoryTaxCodeAndAmount updates taxCode and taxAmount but not taxValue. This mismatch causes the tax field to display "0%" and triggers "Tax no longer valid" on submit. Return categoryTaxValue from getCategoryTaxCodeAndAmount and use setMoneyRequestTaxRateValues to set all three fields atomically. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

FitseTLT · 2026-04-27T15:46:51Z

@MelvinBot merge main

…ValueSync Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-04-27T15:55:17Z

Merged main into this branch and pushed. ✅

FitseTLT · 2026-04-27T16:08:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

2026-04-28.16-40-23.mp4

iOS: HybridApp

2026-04-28.17-03-15.mp4

iOS: mWeb Safari

2026-04-28.16-38-38.mp4

MacOS: Chrome / Safari

2026-04-28.16-26-14.mp4

FitseTLT · 2026-04-27T16:09:07Z

@MelvinBot make it ready for review

MelvinBot · 2026-04-27T16:10:28Z

PR is now marked as ready for review.

melvin-bot · 2026-04-27T16:10:33Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2026-04-27T16:32:22Z

    }

-    return {categoryTaxCode, categoryTaxAmount};
+    return {categoryTaxCode, categoryTaxAmount, categoryTaxValue: categoryTaxPercentage};


Now that we added categoryTaxValue on the return of getCategoryTaxCodeAndAmount I think we should change its name @MelvinBot

Renamed to getCategoryTaxDetails across all call sites (TransactionUtils, IOU, and tests).

FitseTLT · 2026-04-27T16:51:55Z

    if (categoryTaxCode && categoryTaxAmount !== undefined) {
-        setMoneyRequestTaxRate(transactionID, categoryTaxCode);
-        setMoneyRequestTaxAmount(transactionID, categoryTaxAmount);
+        setMoneyRequestTaxRateValues(transactionID, {taxCode: categoryTaxCode, taxAmount: categoryTaxAmount, taxValue: categoryTaxValue ?? null});


U can replace the default value of null with checking for the existence of the value. @MelvinBot

Updated to use an existence check: taxValue: categoryTaxValue ? categoryTaxValue : null. A conditional spread wasn't possible here because the TaxRateValues type requires taxValue to always be present.

Nope what I meant is you can add a check categoryTaxValue in the if to avoid giving default null
@MelvinBot

Done — added categoryTaxValue to the if condition so we no longer need the ?? null fallback.

FitseTLT · 2026-04-27T17:08:34Z

        if (categoryTaxCode && categoryTaxAmount !== undefined) {
            updatedTransaction.taxCode = categoryTaxCode;
            updatedTransaction.taxAmount = categoryTaxAmount;
+            if (categoryTaxValue) {


take this condition above @MelvinBot

Moved the if (categoryTaxValue) block above the if (categoryTaxCode && categoryTaxAmount !== undefined) block so taxValue is set independently.

…tence check for taxValue, move taxValue condition above Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

melvin-bot · 2026-04-27T17:23:13Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-04-27T17:28:09Z

Fixed the failing ESLint check: replaced categoryTaxValue ? categoryTaxValue : null with categoryTaxValue ?? null to resolve the no-unneeded-ternary error in src/libs/actions/IOU/index.ts:910.

FitseTLT · 2026-04-27T19:09:03Z

        updatedTransaction.category = transactionChanges.category;
-        const {categoryTaxCode, categoryTaxAmount} = getCategoryTaxCodeAndAmount(transactionChanges.category, transaction, policy);
+        const {categoryTaxCode, categoryTaxAmount, categoryTaxValue} = getCategoryTaxDetails(transactionChanges.category, transaction, policy);
+        if (categoryTaxValue) {


u should take the assignment in the below if @MelvinBot

Done — moved the taxValue assignment into the existing if (categoryTaxCode && categoryTaxAmount !== undefined) block and added categoryTaxValue to the condition.

FitseTLT · 2026-04-27T19:23:58Z

@MelvinBot updated tests

Precondition
A control workspace with Rules and Taxes enabled with additional non-default tax rate

Open categories, click the Advertising push row, set the Default tax rate to a non-default tax rate from the workspace
Navigate to the workspace chat, start creating a scan expense, upload a receipt
Click the category push row on the conformation page, select Advertising
Verify the tax rate linked with the category is set
Click "Create expense"
Verify that "Tax no longer valid" error is not shown and the expense can be created

MelvinBot · 2026-04-28T16:39:09Z

Merged main into this branch and pushed. ✅

joekaufmanexpensify

Fix makes sense to me!

FitseTLT · 2026-04-30T13:48:33Z

@MelvinBot merge latest main

…ValueSync Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-04-30T14:00:08Z

Merged latest main into this branch (b612b6c).

codecov · 2026-04-30T14:10:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/index.ts	`80.43% <100.00%> (+0.07%)`	⬆️
src/libs/TransactionUtils/index.ts	`87.50% <75.00%> (+0.07%)`	⬆️
... and 24 files with indirect coverage changes

FitseTLT · 2026-04-30T14:12:52Z

@MelvinBot #88477 (comment)

Cover the new categoryTaxValue return property in all existing getCategoryTaxDetails and getUpdatedTransaction test cases to address the Codecov coverage gap. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-04-30T14:19:49Z

Added categoryTaxValue assertions to all getCategoryTaxDetails and getUpdatedTransaction test cases to address the Codecov coverage gap on src/libs/TransactionUtils/index.ts. All 265 tests pass.

FitseTLT · 2026-04-30T16:43:29Z

@MelvinBot complete your checklist

MelvinBot · 2026-04-30T16:45:49Z

Completed the PR Author Checklist. Items left unchecked require manual verification (platform testing, screenshots, offline testing, high-traffic account testing, console errors).

melvin-bot · 2026-04-30T16:53:04Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #86473 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

FitseTLT · 2026-04-30T17:00:37Z

@Gonals while testing this pr I found a couple of BE bugs some of them might make this pr look it caused a regression because they are surfaced by it but in my opinion this pr can be merged as the behavior is not worse than main and then the BE fix can be made. U might find bc-contributors or you fix it. As you like. 👍

BUGS:

Precondition:
A control workspace with Rules and Taxes enabled with additional non-default tax rate
Set Advertising category default tax to the non-default tax rate

Create a receipt expense
Change the category between Advertising

The tax rate should update to the linked rate when category is changed to Advertising but now it is changed to the default tax rate of the workspace instead.

Create a manual expense with some non-default tax rate set
Change the category to other category that doesn't have default tax rate set on rules

The tax rate will change to 0 % with tax violation.

Also a question if this is a bug: when you create a receipt expense selecting a category that has linked tax rate in rules Tax was modified violation occurs is it expected or bug.

Gonals · 2026-05-01T07:42:26Z

@Gonals while testing this pr I found a couple of BE bugs some of them might make this pr look it caused a regression because they are surfaced by it but in my opinion this pr can be merged as the behavior is not worse than main and then the BE fix can be made. U might find bc-contributors or you fix it. As you like. 👍

BUGS:

Precondition: A control workspace with Rules and Taxes enabled with additional non-default tax rate Set Advertising category default tax to the non-default tax rate

Create a receipt expense

Change the category between Advertising

The tax rate should update to the linked rate when category is changed to Advertising but now it is changed to the default tax rate of the workspace instead.

Create a manual expense with some non-default tax rate set

Change the category to other category that doesn't have default tax rate set on rules

The tax rate will change to 0 % with tax violation.

Also a question if this is a bug: when you create a receipt expense selecting a category that has linked tax rate in rules Tax was modified violation occurs is it expected or bug.

Can you report these bugs on Slack?

FitseTLT · 2026-05-01T14:52:08Z

pinged bc team https://expensify.slack.com/archives/C02NK2DQWUX/p1777647111013589

github-actions · 2026-05-01T15:21:30Z

🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-01T15:25:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88477.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-536d1dd-cf2e452-8e0fdf4194792d26d7b82c3ba4095c2120b24c56/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-536d1dd-cf2e452-5fca1a3d1d8ecb5a4e4356c79f508794fa66eb44/index.html

Web 🕸️
https://88477.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-01T15:29:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-04T13:27:11Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-04T13:28:24Z

No help site changes required.

This PR is an internal bug fix that corrects how taxValue is set when selecting a category with a default tax rate. The changes (renaming getCategoryTaxCodeAndAmount → getCategoryTaxDetails, atomic tax value updates, and unit test updates) are purely in internal transaction/IOU logic.

No user-facing behavior, terminology, settings, or workflows changed — the category default tax rate feature already existed and is already working as documented. This fix just resolves a sync issue between internal tax fields (taxCode, taxAmount, taxValue).

nlemma · 2026-05-04T17:17:44Z

Deploy Blocker #89541 was identified to be related to this PR.

MelvinBot assigned FitseTLT Apr 21, 2026

MelvinBot requested a review from a team April 21, 2026 20:34

MelvinBot mentioned this pull request Apr 21, 2026

[$250] Expenses - Tax-0% is shown in Tax field when creating scan expense with category with assigned tax rate #86473

Open

7 tasks

Merge remote-tracking branch 'origin/main' into claude-fixCategoryTax…

f1596bc

…ValueSync Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot marked this pull request as ready for review April 27, 2026 16:10

MelvinBot requested a review from a team as a code owner April 27, 2026 16:10

melvin-bot Bot requested review from a team, FitseTLT and joekaufmanexpensify and removed request for a team April 27, 2026 16:10

melvin-bot Bot requested review from JmillsExpensify and removed request for a team April 27, 2026 16:10

FitseTLT reviewed Apr 27, 2026

View reviewed changes

Rename getCategoryTaxCodeAndAmount to getCategoryTaxDetails, use exis…

426f00b

…tence check for taxValue, move taxValue condition above Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner April 27, 2026 17:23

melvin-bot Bot requested review from FitseTLT and removed request for a team April 27, 2026 17:23

Fix no-unneeded-ternary ESLint error in IOU/index.ts

19f1097

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

FitseTLT reviewed Apr 27, 2026

View reviewed changes

joekaufmanexpensify previously approved these changes Apr 28, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into claude-fixCategoryTax…

b612b6c

…ValueSync Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

Add categoryTaxValue assertions to getCategoryTaxDetails tests

0281443

Cover the new categoryTaxValue return property in all existing getCategoryTaxDetails and getUpdatedTransaction test cases to address the Codecov coverage gap. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot dismissed joekaufmanexpensify’s stale review via 0281443 April 30, 2026 14:19

FitseTLT approved these changes Apr 30, 2026

View reviewed changes

melvin-bot Bot requested a review from Gonals April 30, 2026 16:53

FitseTLT approved these changes Apr 30, 2026

View reviewed changes

Gonals approved these changes May 1, 2026

View reviewed changes

Gonals merged commit 536d1dd into main May 1, 2026
45 of 47 checks passed

Gonals deleted the claude-fixCategoryTaxValueSync branch May 1, 2026 15:20

OSBotify mentioned this pull request May 4, 2026

Deploy Checklist: New Expensify 2026-05-04 #89508

Open

75 tasks

applause-bot Bot mentioned this pull request May 4, 2026

Expenses - "Tax rate was modified" error is displayed after creating scan expense #89541

Open

7 tasks

Conversation

MelvinBot commented Apr 21, 2026 • edited by AndrewGable Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

FitseTLT commented Apr 27, 2026

Uh oh!

MelvinBot commented Apr 27, 2026

Uh oh!

FitseTLT commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT commented Apr 27, 2026

Uh oh!

MelvinBot commented Apr 27, 2026

Uh oh!

melvin-bot Bot commented Apr 27, 2026

Uh oh!

FitseTLT Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 27, 2026

Uh oh!

MelvinBot commented Apr 27, 2026

Uh oh!

FitseTLT Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Apr 27, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Apr 30, 2026

Uh oh!

MelvinBot commented Apr 30, 2026

Uh oh!

codecov Bot commented Apr 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

FitseTLT commented Apr 30, 2026

MelvinBot commented Apr 21, 2026 •

edited by AndrewGable

Loading

FitseTLT commented Apr 27, 2026 •

edited

Loading

FitseTLT Apr 27, 2026 •

edited

Loading

FitseTLT Apr 27, 2026 •

edited

Loading

FitseTLT Apr 27, 2026 •

edited

Loading

FitseTLT Apr 27, 2026 •

edited

Loading

codecov Bot commented Apr 30, 2026 •

edited by github-actions Bot

Loading

FitseTLT commented Apr 30, 2026 •

edited

Loading