[NoQA] Implement Gusto connection flow by ShridharGoel · Pull Request #88479 · Expensify/App

ShridharGoel · 2026-04-21T20:40:38Z

Explanation of Change

This PR adds the shared Gusto connection actions. It adds actions to start the Gusto connect flow, run a manual sync, update the approval mode, and update the final approver.

Fixed Issues

$ #87010
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-04-24.at.2.43.23.AM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-24.at.2.08.25.AM.mov

melvin-bot · 2026-04-21T20:45:04Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-21T20:54:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ConnectToGustoFlow/index.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/connections/Gusto.ts	`0.00% <0.00%> (ø)`
src/pages/workspace/hr/WorkspaceHRPage.tsx	`0.00% <0.00%> (ø)`
src/components/ConnectToGustoFlow/index.native.tsx	`0.00% <0.00%> (ø)`
... and 35 files with indirect coverage changes

trjExpensify · 2026-04-22T21:46:15Z

@shubham1206agra what's your ETA on reviewing this?

shubham1206agra · 2026-04-23T09:57:45Z

@ShridharGoel Let's add these functions whenever they are required as we are in middle of knip review and these files might be deleted accidentally.

github-actions · 2026-04-23T18:39:48Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00bf2718c3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ShridharGoel · 2026-04-23T21:35:30Z

@shubham1206agra Updated

github-actions · 2026-04-25T15:52:27Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

shubham1206agra · 2026-04-26T11:45:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-04-26.at.5.08.08.PM.mov

Screen.Recording.2026-04-26.at.5.14.32.PM.mov

ShridharGoel · 2026-04-28T22:05:45Z

@heyjennahay Can you have a look ? That would enable us to move further with the feature.

github-actions · 2026-04-28T22:55:20Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-28T22:59:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88479.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e489519-7486324-39044c4e210d5c43ae5a494411b8747e654c9099/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e489519-7486324-c9f8cada02b21c89cb6e392b404bd838185a9320/index.html

Web 🕸️
https://88479.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-28T23:03:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2026-04-29T21:43:43Z

+    const [isWebViewOpen, setIsWebViewOpen] = useState(true);
+    const [session] = useOnyx(ONYXKEYS.SESSION);
+
+    const renderLoading = useCallback(


Just FYI - this component compiles with React Compiler just fine (any new component that doesn't compile will cause a CI error). So we should not use useCallback - it's redundant and can cause more harm than good. At this point no new components should use useCallback, useMemo, or React.memo

@ShridharGoel, can you make a follow-up fixing this, please?

Yes, will do

OSBotify · 2026-04-30T23:06:19Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.65-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

melvin-bot Bot assigned ShridharGoel Apr 21, 2026

ShridharGoel changed the title ~~Add Gusto connection actions~~ [NoQA] Add Gusto connection actions Apr 21, 2026

ShridharGoel marked this pull request as ready for review April 21, 2026 20:44

ShridharGoel requested review from a team as code owners April 21, 2026 20:44

melvin-bot Bot requested review from heyjennahay and shubham1206agra and removed request for a team April 21, 2026 20:45

melvin-bot Bot removed the request for review from a team April 21, 2026 20:45

ShridharGoel requested review from a team and stephanieelliott as code owners April 23, 2026 18:39

ShridharGoel marked this pull request as draft April 23, 2026 18:42

Wire Gusto connect action

c1059f0

ShridharGoel force-pushed the gusto1.6 branch from 4694abe to c1059f0 Compare April 23, 2026 18:53

Fix Gusto connect import

00bf271

ShridharGoel changed the title ~~[NoQA] Add Gusto connection actions~~ [NoQA] Implement Gusto connection flow Apr 23, 2026

ShridharGoel marked this pull request as ready for review April 23, 2026 20:39

ShridharGoel added 2 commits April 24, 2026 02:18

Add Gusto setup flow

c008c24

Rename active Gusto flow key

2360b4c

chatgpt-codex-connector Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread src/libs/actions/connections/Gusto.ts Outdated

ShridharGoel added 5 commits April 24, 2026 02:25

Match Gusto flow key pattern

fa3da45

Align Gusto setup flow with patterns

d5366db

Fix Gusto flow lint issues

0905366

Fix Gusto flow compiler compliance

208e525

Format Gusto HR page

fba8411

stephanieelliott removed their request for review April 24, 2026 04:54

This comment has been minimized.

Sign in to view

ShridharGoel mentioned this pull request Apr 25, 2026

Add Gusto connected actions to HR page #88789

Open

52 tasks

shubham1206agra approved these changes Apr 26, 2026

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon April 26, 2026 11:46

mjasikowski self-requested a review April 28, 2026 17:55

mjasikowski approved these changes Apr 28, 2026

View reviewed changes

yuwenmemon approved these changes Apr 28, 2026

View reviewed changes

yuwenmemon merged commit e489519 into Expensify:main Apr 28, 2026
43 checks passed

roryabraham reviewed Apr 29, 2026

View reviewed changes

OSBotify mentioned this pull request Apr 30, 2026

Deploy Checklist: New Expensify 2026-04-30 #89315

Open

Conversation

ShridharGoel commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Apr 22, 2026

Uh oh!

shubham1206agra commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ShridharGoel commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 25, 2026

Uh oh!

This comment has been minimized.

shubham1206agra commented Apr 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented Apr 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

roryabraham Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

yuwenmemon Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ShridharGoel commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited by github-actions Bot

Loading