[Payment due @daledah] [No QA] Fix React Compiler compliance in WorkspaceCompanyCardDetailsPage by roryabraham · Pull Request #88485 · Expensify/App

roryabraham · 2026-04-21T22:11:27Z

Explanation of Change

WorkspaceCompanyCardDetailsPage.tsx was failing React Compiler with 14 "Cannot access refs during render" errors. This PR fixes that, removes manual memoization, and cleans up the component a bit (grouping like items together).

Fixed Issues

(partial) #68765
PROPOSAL: N/A

Tests

Open any workspace with company cards and assign a card.
Navigate to that card's detail page (Settings > Workspaces > [workspace] > Company cards > [card]).
Verify the page renders: cardholder, card number, card name, (optional export), last updated, transaction start date, view transactions, update card, unassign card.
Tap Unassign card → confirm the modal → verify the confirm flow dispatches and the app navigates back without flashing <NotFoundPage />.
Deep-link to a card that doesn't exist for the current user — verify <NotFoundPage /> is shown.
Verify no errors appear in the JS console.

Verify that no errors appear in the JS console

Offline tests

Go offline.
Open the company card detail page.
Verify the page renders from cached Onyx data and the Update card button is disabled (disabled={isOffline || card?.isLoadingLastUpdated}).
Return online — verify behavior is unchanged.

QA Steps

[No QA]

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

… drop useMemo Convert isUnassigningRef to a boolean useState so the early-return guard no longer reads a ref during render, drop the lone useMemo for lastScrape, and regroup the body into the canonical section order. Made-with: Cursor

Made-with: Cursor

melvin-bot · 2026-04-21T22:11:35Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

codecov · 2026-04-21T22:20:42Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...e/companyCards/WorkspaceCompanyCardDetailsPage.tsx	`0.00% <0.00%> (ø)`
... and 15 files with indirect coverage changes

…details

roryabraham · 2026-04-22T00:10:49Z

failing iOS remote build is unrelated, fixed in #88492

…details

roryabraham · 2026-04-22T00:32:58Z

@trjExpensify no product review needed

roryabraham · 2026-04-22T00:33:04Z

Going to source a C+ volunteer: https://expensify.slack.com/archives/C02NK2DQWUX/p1776817996221759

melvin-bot · 2026-04-22T00:33:11Z

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2026-04-22T01:00:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android-mweb.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web-resize.mp4

melvin-bot · 2026-04-22T03:29:23Z

🎯 @daledah, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

github-actions · 2026-04-22T13:00:57Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-04-22T13:04:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-22T13:16:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88485.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6858d23-d98911d-4ea0dc5968b99ed7c3a0c0df972913b7d9658832/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6858d23-d98911d-0bdb55a2bded477b57a7de062bbcb4e064211c3b/index.html

Web 🕸️
https://88485.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-23T20:21:13Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.62-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

roryabraham added 2 commits April 21, 2026 15:10

chore: lower eslint --max-warnings to 292

6103b26

Made-with: Cursor

melvin-bot Bot assigned roryabraham Apr 21, 2026

Merge remote-tracking branch 'origin/main' into rory-rc-company-card-…

01dc46f

…details

Merge remote-tracking branch 'origin/main' into rory-rc-company-card-…

d73d73f

…details

roryabraham marked this pull request as ready for review April 22, 2026 00:32

roryabraham requested review from a team as code owners April 22, 2026 00:32

melvin-bot Bot requested review from trjExpensify and removed request for a team April 22, 2026 00:32

roryabraham removed the request for review from trjExpensify April 22, 2026 00:32

melvin-bot Bot requested review from Valforte and removed request for a team April 22, 2026 00:33

roryabraham requested a review from daledah April 22, 2026 00:37

daledah approved these changes Apr 22, 2026

View reviewed changes

melvin-bot Bot changed the title ~~[No QA] Fix React Compiler compliance in WorkspaceCompanyCardDetailsPage~~ [Payment due @daledah] [No QA] Fix React Compiler compliance in WorkspaceCompanyCardDetailsPage Apr 22, 2026

Valforte approved these changes Apr 22, 2026

View reviewed changes

Valforte merged commit 6858d23 into main Apr 22, 2026
52 checks passed

Valforte deleted the rory-rc-company-card-details branch April 22, 2026 12:55

roryabraham mentioned this pull request Apr 23, 2026

[Tracking] Use React Compiler to enforce the Rules of React #68765

Open

OSBotify mentioned this pull request Apr 23, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Payment due @daledah] [No QA] Fix React Compiler compliance in WorkspaceCompanyCardDetailsPage#88485

[Payment due @daledah] [No QA] Fix React Compiler compliance in WorkspaceCompanyCardDetailsPage#88485
Valforte merged 4 commits intomainfrom
rory-rc-company-card-details

roryabraham commented Apr 21, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 •

edited by github-actions Bot

Loading

Uh oh!

roryabraham commented Apr 22, 2026

Uh oh!

roryabraham commented Apr 22, 2026

Uh oh!

roryabraham commented Apr 22, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

daledah commented Apr 22, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

OSBotify commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

roryabraham commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

roryabraham commented Apr 22, 2026

Uh oh!

roryabraham commented Apr 22, 2026

Uh oh!

roryabraham commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

daledah commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

OSBotify commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roryabraham commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited by github-actions Bot

Loading

roryabraham commented Apr 22, 2026 •

edited

Loading

daledah commented Apr 22, 2026 •

edited

Loading