Create iOS RN artifacts workflow#88523
Draft
mateuuszzzzz wants to merge 6 commits into
Draft
Conversation
Contributor
|
|
Contributor
Author
|
WIP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds a CI workflow for building and publishing React Native iOS prebuilt artifacts (XCFramework plus dSYMs) to GitHub Packages Maven, with separate matrix branches for Standalone and HybridApp. The pipeline runs on a fan in shape (verify then build slice then compose then publish), building Debug and Release variants for both
iosandios-simulatorin parallel and combining them into a universal XCFramework.Alongside the new iOS workflow, the existing Android artifacts workflow has been aligned with the same conventions. The previously duplicated
verifyPatchesjob has been extracted into a reusable workflow (verifyReactNativePatches.yml) consumed by both platforms. Two composite actions were introduced to deduplicate steps:fetchReactNativePrebuild(pulls prebuild scripts from upstreamfacebook/react-native) anddetermineNewPatchedRNVersion(wrapsgetNewPatchedRNVersion.sh).Gradle utility files used for patched artifacts moved from
gradleUtils/toscripts/artifacts-utils/android/with helpers consolidated intoExpensiUtils.gradle. The patch hashing script gained a--hermes-v1flag and a newresolve-hermes-flag.shhelper (living in.github/scripts/since it is CI only) picks up the right value fromgradle.propertiesorPodfiledepending on platform and build type.Fixed Issues
$ #86437
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13925
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari