[NO QA] Restrict InteractionManager and TransitionTracker usage with 'no-restricted-imports' eslint rule by collectioneur · Pull Request #88525 · Expensify/App

collectioneur · 2026-04-22T11:22:47Z

Explanation of Change

Add ESLint no-restricted-imports rules to prevent direct usage of InteractionManager (from react-native) and TransitionTracker (internal primitive). Existing usages across ~125 files are grandfathered with eslint-disable-next-line comments. This enforces that new code uses higher-level APIs (Navigation afterTransition/waitForTransition, KeyboardUtils, etc.) instead.

Fixed Issues

$ #83072

Tests

Temporarily remove an // eslint-disable-next-line no-restricted-imports comment from any file importing InteractionManager or TransitionTracker, then run ESLint on that file - verify a lint error is reported with the appropriate guidance message

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA needed - this is a lint-only change with no runtime impact.

Verify that no errors appear in the JS console

PR Author Checklist

…acker

melvin-bot · 2026-04-22T11:22:54Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2026-04-22T11:35:52Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-04-22T15:59:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-22T16:00:04Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #83072 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

dukenv0307 · 2026-04-22T16:00:16Z

LGTM

grgia · 2026-04-23T14:47:43Z

@collectioneur would you merge main?

collectioneur · 2026-04-23T15:27:31Z

@grgia Sure, merging now 😄

grgia

Tests failing 🙇

collectioneur · 2026-04-23T17:21:51Z

Merged main one more time, it looks like the tests are failing on main too 🙂

grgia

Woop, thanks!

grgia · 2026-04-27T10:26:23Z

@collectioneur agh conflicts still, ping me when mergable 🙏

collectioneur · 2026-04-27T11:27:08Z

@grgia conflicts resolved 😄

codecov · 2026-04-27T14:48:55Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AddUnreportedExpenseFooter.tsx	`0.00% <ø> (ø)`
src/components/AutoSubmitModal.tsx	`0.00% <ø> (ø)`
src/components/AvatarCropModal/AvatarCropModal.tsx	`1.96% <ø> (ø)`
...components/ContactPermissionModal/index.native.tsx	`0.00% <ø> (ø)`
src/components/DatePicker/index.tsx	`0.00% <ø> (ø)`
src/components/FeatureTrainingModal.tsx	`92.55% <ø> (ø)`
src/components/Form/FormProvider.tsx	`61.57% <ø> (ø)`
src/components/Form/FormWrapper.tsx	`83.33% <ø> (ø)`
src/components/Lottie/index.tsx	`70.17% <ø> (ø)`
src/components/Modal/ReanimatedModal/index.tsx	`52.17% <ø> (ø)`
... and 113 more
... and 8 files with indirect coverage changes

collectioneur · 2026-04-27T15:04:52Z

@grgia I’m OOO from tomorrow until Monday. If any main conflicts happen to come up while I'm away, @mrejdak will take care of merging them 🙂

grgia · 2026-04-28T14:53:06Z

@mrejdak msgd in slack, would you merge main

…ftover change

mrejdak · 2026-04-28T16:50:15Z

@grgia Merged!

github-actions · 2026-04-29T07:35:48Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-04-29T07:45:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-29T07:59:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88525.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c71784d-7486324-39044c4e210d5c43ae5a494411b8747e654c9099/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c71784d-7486324-c9f8cada02b21c89cb6e392b404bd838185a9320/index.html

Web 🕸️
https://88525.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…on tests Both useGettingStartedItems.test.ts and GettingStartedSectionTest.tsx asserted state immediately after renderHook / render returned, before the hook's Onyx subscriptions had fired their post-mount callbacks. The first render reflected initial empty Onyx state; the assertion ran against THAT, then the hook re-rendered milliseconds later with the hydrated values. In CI's parallel-worker environment the timing window made this fail deterministically on certain shards. Fix: add `await waitForBatchedUpdates()` after every renderHook / renderGettingStartedSection call. Same pattern the test files already use after Onyx setup; just extending it to post-render so the hook's own subscriptions also settle before the assertion. Confirmed flaky from inception: the test files were added in Expensify#88525 (merged ~24h ago) and immediately started failing on multiple unrelated branches (Expensify#89146 / fix/83781 / feat/84877 / wildan/88503 / Rory-RemoveUnnecessaryESLintDisable). Tracked in Expensify#89240. No production source changes — test-only patch. 76 lines added across the two files (one waitForBatchedUpdates call per renderHook / renderGettingStartedSection site).

OSBotify · 2026-04-30T23:06:22Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.65-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-30T23:08:16Z

No help site changes required.

This PR adds ESLint lint rules to restrict direct usage of InteractionManager and TransitionTracker, with existing usages grandfathered via eslint-disable-next-line comments. It is purely an internal developer tooling change with no runtime or user-facing impact, so no updates to docs/articles are needed.

add no-restricted-imports rule on InteractionManager and TransitionTr…

a205014

…acker

melvin-bot Bot assigned collectioneur Apr 22, 2026

collectioneur changed the title ~~add no-restricted-imports rule on InteractionManager and TransitionTr…~~ Restrict InteractionManager and TransitionTracker usage with 'no-restricted-imports' eslint rule Apr 22, 2026

collectioneur changed the title ~~Restrict InteractionManager and TransitionTracker usage with 'no-restricted-imports' eslint rule~~ [NO QA] Restrict InteractionManager and TransitionTracker usage with 'no-restricted-imports' eslint rule Apr 22, 2026

war-in approved these changes Apr 22, 2026

View reviewed changes

collectioneur marked this pull request as ready for review April 22, 2026 11:35

collectioneur requested review from a team as code owners April 22, 2026 11:35

melvin-bot Bot requested review from dukenv0307 and heyjennahay and removed request for a team April 22, 2026 11:35

melvin-bot Bot removed the request for review from a team April 22, 2026 11:35

Merge branch 'main' into collectioneur/transition-tracker-eslint

7fc3126

dukenv0307 approved these changes Apr 22, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia April 22, 2026 16:00

dukenv0307 mentioned this pull request Apr 22, 2026

Restrict InteractionManager and TransitionTracker usage with 'no-restricted-imports' eslint rule #83072

Open

grgia previously approved these changes Apr 23, 2026

View reviewed changes

Merge branch 'main' into collectioneur/transition-tracker-eslint

e82c728

collectioneur dismissed grgia’s stale review via e82c728 April 23, 2026 15:36

collectioneur requested a review from grgia April 23, 2026 16:05

grgia reviewed Apr 23, 2026

View reviewed changes

Merge branch 'main' into collectioneur/transition-tracker-eslint

2d70b5a

grgia previously approved these changes Apr 27, 2026

View reviewed changes

Merge branch 'main' into collectioneur/transition-tracker-eslint

639c707

collectioneur dismissed grgia’s stale review via 639c707 April 27, 2026 11:26

Merge branch 'main' into collectioneur/transition-tracker-eslint

8347c23

mrejdak added 3 commits April 28, 2026 17:43

Merge branch 'main' into collectioneur/transition-tracker-eslint

6cd3ec3

Merge branch 'main' into collectioneur/transition-tracker-eslint - le…

3e7180b

…ftover change

Merge branch 'main' into collectioneur/transition-tracker-eslint

82852f7

grgia approved these changes Apr 29, 2026

View reviewed changes

grgia merged commit c71784d into Expensify:main Apr 29, 2026
34 checks passed

OSBotify mentioned this pull request Apr 30, 2026

Deploy Checklist: New Expensify 2026-04-30 #89315

Open

Conversation

collectioneur commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

dukenv0307 commented Apr 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

dukenv0307 commented Apr 22, 2026

Uh oh!

grgia commented Apr 23, 2026

Uh oh!

collectioneur commented Apr 23, 2026

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

collectioneur commented Apr 23, 2026

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Apr 27, 2026

Uh oh!

collectioneur commented Apr 27, 2026

Uh oh!

codecov Bot commented Apr 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

collectioneur commented Apr 27, 2026

Uh oh!

grgia commented Apr 28, 2026

Uh oh!

mrejdak commented Apr 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

OSBotify commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

MelvinBot commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

collectioneur commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 27, 2026 •

edited by github-actions Bot

Loading