Update search input height on narrow to be the same as in wide by bernhardoj · Pull Request #88526 · Expensify/App

bernhardoj · 2026-04-22T11:31:11Z

Explanation of Change

Fixed Issues

$ #84876
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

For mobile screen only

Go to Spend
Verify the input height is the same as on the web (32px)
Press the input
Verify it expands to the normal size

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-04-22T11:31:18Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-22T11:31:23Z

@JS00001 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-04-22T11:31:37Z

Change requested by @shawnborton to make the input height the same in narrow and wide version.

shawnborton · 2026-04-22T11:35:07Z

cc @Expensify/design and specifically JDUB - after seeing this, dang, I wonder if it feels too short for mobile devices?

shawnborton · 2026-04-22T11:37:05Z

Let's wait to merge until we get further confirmation from Design team.

shawnborton · 2026-04-22T11:44:49Z

Looks like we actually had 44px tall in Figma, maybe we go with that?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22ad9c3fe3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

bernhardoj · 2026-04-22T11:55:06Z

Updated to 44

github-actions · 2026-04-22T11:58:17Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2026-04-22T12:08:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/styles/index.ts	`46.04% <ø> (ø)`
src/styles/variables.ts	`100.00% <ø> (ø)`
.../Search/SearchPageNarrow/StaticSearchPageInput.tsx	`0.00% <0.00%> (ø)`
... and 121 files with indirect coverage changes

shawnborton · 2026-04-22T13:11:50Z

Tested and that feels pretty solid to me! Again, let's have the Design homies weigh in but I think this could work well.

dannymcclain · 2026-04-22T13:34:22Z

That feels like a pretty solid size to me. Can we update the focused state so that the input doesn't jump in height though?

CleanShot.2026-04-22.at.08.32.59.mp4

shawnborton · 2026-04-22T13:45:41Z

Oh that's a good shout, I would be a fan of that personally but that might be a bigger change since that touches the router?

dannymcclain · 2026-04-22T13:50:27Z

that might be a bigger change since that touches the router?

Oh right - I didn't think about that haha. Fine to not mess with it here if it's too much scope.

bernhardoj · 2026-04-22T14:17:06Z

It's easy to keep the height the same (44px) between the expanded and non-expanded state.

web.mp4

But do we want to update all the inputs' height to 44px?

web.2.mp4

shawnborton · 2026-04-22T14:40:45Z

I think in the case of web, it would be ideal if the router had the same size input that we're using there. Basically the idea is to not have any size jumping on each platform.

dannymcclain · 2026-04-22T14:51:25Z

I'm good with that Shawn. Though it bothers me less on desktop since you see the whole router popover takeover thingy—feels less weird on desktop to me, but I'm still down with what you've suggested.

shawnborton · 2026-04-22T14:58:26Z

I feel the exact same way 🤝 happy to solve mobile first and then follow up with web later.

bernhardoj · 2026-04-22T14:59:50Z

Updated

github-actions · 2026-04-22T15:13:11Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-22T15:18:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88526.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-19b9162-d98911d-959025a88fc20238a1d7098c98da1ca318a7b651/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-19b9162-d98911d-1b433a66f3115adf1accbee1924dbffeb9b72ed1/index.html

Web 🕸️
https://88526.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2026-04-22T15:35:51Z

Nice, this feels great to me 👍

joekaufmanexpensify

Good for product

aimane-chnaif · 2026-04-23T13:40:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

ios-landscape.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

aimane-chnaif · 2026-04-23T14:06:00Z

I am not seeing any visual change before and after this branch. Is this expected?

ios.mov

bernhardoj · 2026-04-23T14:08:00Z

@aimane-chnaif try to inspect the element and see if the height is 44px

aimane-chnaif · 2026-04-23T14:13:23Z

Oh yes I see it now. 52px vs 44px

aimane-chnaif · 2026-04-23T14:19:19Z

+    minimalTopBarOffset: -112,
+    minimalTopBarWithFiltersOffset: -156,
    searchHeaderDefaultOffset: 0,
-    searchListContentMarginTop: 126,
-    searchListContentWithFiltersMarginTop: 170,
+    searchListContentMarginTop: 112,
+    searchListContentWithFiltersMarginTop: 156,


Why 14px difference here while height only reduced 8px?

Indeed this causes regression

Screen.Recording.2026-04-23.at.3.35.40.pm.mov

Nice catch. This was recalculated when using the 32px.

Yes, it's 20px difference, but there are actions bar with 40px height + 16px padding = 56px, and the previous height is 70px (52px + 2px (input border) + 16px)

Just curious: why absolute position styling in the first implementation? If relative, no need to recalculate these values when input container height changes.

I think to achieve this effect, where the top part shows when scrolling top.

mw.mp4

MelvinBot · 2026-04-23T15:01:07Z

Code Review

The changes look correct and well-scoped. A few observations:

What's good:

The 8px offset adjustments (126→118, 170→162) correctly match the height reduction (52→44)
Both static (StaticSearchPageInput.tsx) and interactive (SearchPageInputNarrow.tsx) narrow inputs share the same searchPageInputNarrowTouchableWrapper style, keeping them in sync
All CI checks are passing

Minor note:

The height 44 is hardcoded, but the wide variant (searchPageInputWideTouchableWrapper) also hardcodes its height at 32, so this is consistent with existing patterns in the file. The automated bot suggestion to extract a shared variable doesn't apply here since the wide (32px) and narrow (44px) heights are intentionally different.

No blocking issues found.

JS00001 · 2026-04-23T15:07:08Z

@bernhardoj perf tests are failing

aimane-chnaif · 2026-04-23T15:11:18Z

Might be flaky. Can you please re-run that workflow?

chatgpt-codex-connector · 2026-04-23T15:22:17Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

update search input height on narrow to be the same as in wide

22ad9c3

bernhardoj requested review from a team as code owners April 22, 2026 11:31

melvin-bot Bot assigned bernhardoj Apr 22, 2026

melvin-bot Bot requested review from a team, aimane-chnaif and joekaufmanexpensify and removed request for a team April 22, 2026 11:31

melvin-bot Bot requested review from JS00001 and removed request for a team April 22, 2026 11:31

JS00001 previously approved these changes Apr 22, 2026

View reviewed changes

github-actions Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread src/styles/index.ts Outdated

github-actions Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread src/components/Search/SearchPageHeader/SearchPageInputNarrow.tsx Outdated

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread src/styles/index.ts Outdated

update height to 44

9d3fe0f

bernhardoj dismissed JS00001’s stale review via 9d3fe0f April 22, 2026 11:54

This comment has been minimized.

Sign in to view

prettier

af3452c

keep the height the same

19b9162

joekaufmanexpensify previously approved these changes Apr 22, 2026

View reviewed changes

aimane-chnaif reviewed Apr 23, 2026

View reviewed changes

update offset

b1146b0

bernhardoj dismissed joekaufmanexpensify’s stale review via b1146b0 April 23, 2026 14:38

aimane-chnaif approved these changes Apr 23, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 April 23, 2026 14:56

JS00001 approved these changes Apr 23, 2026

View reviewed changes

Conversation

bernhardoj commented Apr 22, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

melvin-bot Bot commented Apr 22, 2026

Uh oh!

bernhardoj commented Apr 22, 2026

Uh oh!

Uh oh!

Uh oh!

shawnborton commented Apr 22, 2026

Uh oh!

shawnborton commented Apr 22, 2026

Uh oh!

shawnborton commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

bernhardoj commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

This comment has been minimized.

codecov Bot commented Apr 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shawnborton commented Apr 22, 2026

Uh oh!

dannymcclain commented Apr 22, 2026

Uh oh!

shawnborton commented Apr 22, 2026

Uh oh!

dannymcclain commented Apr 22, 2026

Uh oh!

bernhardoj commented Apr 22, 2026

Uh oh!

shawnborton commented Apr 22, 2026

Uh oh!

dannymcclain commented Apr 22, 2026

Uh oh!

shawnborton commented Apr 22, 2026

Uh oh!

bernhardoj commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

shawnborton commented Apr 22, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Apr 23, 2026

Uh oh!

bernhardoj commented Apr 23, 2026

Uh oh!

aimane-chnaif commented Apr 23, 2026

Uh oh!

aimane-chnaif Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 22, 2026 •

edited by github-actions Bot

Loading

aimane-chnaif commented Apr 23, 2026 •

edited

Loading