Navigate to Home instead of Inbox in goBackToHome by MelvinBot · Pull Request #88563 · Expensify/App

MelvinBot · 2026-04-23T03:17:20Z

Explanation of Change

goBackToHome() navigated to ROUTES.INBOX instead of ROUTES.HOME, so the "Go back to home page" button on not-found screens took users to Inbox rather than Home. This updates both goBack() calls in goBackToHome() to use ROUTES.HOME, aligning the function's behavior with its name and the button text.

Also removes the now-redundant workaround in NotFoundPage.tsx that bypassed goBackToHome() for the generic error screen by directly calling Navigation.goBack(ROUTES.HOME).

Fixed Issues

$ #88443
PROPOSAL: #88443 (comment)

Tests

Navigate to https://staging.new.expensify.com/a/hello
Press 'Go back to home page'
Verify you are redirected to the Home page

Offline tests

QA Steps

Navigate to https://staging.new.expensify.com/a/hello
Press 'Go back to home page'
Verify you are redirected to the Home page

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

goBackToHome() was navigating to ROUTES.INBOX despite its name and the "Go back to home page" button text. Update it to use ROUTES.HOME. Remove the now-redundant workaround in NotFoundPage that bypassed goBackToHome() for the generic error screen. Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>

codecov · 2026-04-23T03:28:04Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Navigation/Navigation.ts	`49.22% <0.00%> (ø)`
... and 8 files with indirect coverage changes

bernhardoj · 2026-04-23T03:37:25Z

@MelvinBot let's not touch the NotFoundPage file

Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>

MelvinBot · 2026-04-23T03:39:33Z

Reverted the NotFoundPage.tsx changes — the file is now back to its state on main. The PR now only modifies Navigation.ts.

bernhardoj · 2026-04-23T03:45:50Z

@MelvinBot mark this PR as ready

MelvinBot · 2026-04-23T03:49:14Z

I'm unable to mark this PR as ready for review due to permission restrictions in my current environment. You can mark it ready yourself by running:

gh pr ready 88563 --repo Expensify/App

Or by clicking "Ready for review" on the PR page.

bernhardoj · 2026-04-24T14:58:42Z

@MelvinBot please update the test step to

Navigate to https://staging.new.expensify.com/a/hello
Press 'Go back to home page'
Verify you are redirected to the Home page

bernhardoj · 2026-04-25T02:36:02Z

@MelvinBot please update the test step to

Navigate to https://staging.new.expensify.com/a/hello
Press 'Go back to home page'
Verify you are redirected to the Home page

MelvinBot · 2026-04-25T02:37:54Z

Updated the Tests and QA Steps sections with the provided test steps.

bernhardoj · 2026-04-25T03:49:15Z

@MelvinBot please complete the checklist

MelvinBot · 2026-04-25T03:51:56Z

Completed the PR Author Checklist. Most conditional items (new files, new CSS, new assets, UI changes, etc.) are checked off as N/A since this PR only changes route constants in Navigation.ts.

bernhardoj · 2026-04-27T03:20:05Z

@MelvinBot mark this PR as ready

MelvinBot · 2026-04-27T03:21:22Z

Done — PR is now marked as ready for review.

melvin-bot · 2026-04-27T03:21:24Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-04-27T06:34:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-04-27T12:09:38Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #88443 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

github-actions · 2026-04-27T15:39:13Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-04-27T15:43:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-27T15:43:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88563.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bf16a4a-8db5ec6-b513022f080b460ac022c388a255656d0f77c885/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bf16a4a-8db5ec6-1c576fcbc4d22c1b052ac73bd039c8d37baefd60/index.html

Web 🕸️
https://88563.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-28T00:17:08Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.62-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T00:19:06Z

No help site changes are required for this PR.

This PR fixes an internal navigation bug where goBackToHome() routed to Inbox instead of Home. I searched all articles under docs/articles/ and found no documentation that references the "Go back to home page" button on not-found/error pages or the goBackToHome navigation behavior. The fix is purely internal and doesn't affect any documented user flows.

OSBotify · 2026-04-28T01:04:49Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.63-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-04-28T01:06:56Z

No help site changes are required for this PR.

The change is purely internal navigation logic — swapping ROUTES.INBOX → ROUTES.HOME in goBackToHome(). No help articles under App/docs/articles reference the "Go back to home page" button, not-found screens, or the navigation behavior being modified here.

OSBotify · 2026-04-28T01:42:25Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T01:43:36Z

No help site changes are required for this PR.

The change is a purely internal navigation bug fix — it updates goBackToHome() in Navigation.ts to use ROUTES.HOME instead of ROUTES.INBOX. No help site articles under docs/articles/ reference the "Go back to home page" button, not-found page behavior, or the goBackToHome navigation flow.

MelvinBot assigned bernhardoj Apr 23, 2026

MelvinBot requested a review from a team April 23, 2026 03:17

MelvinBot mentioned this pull request Apr 23, 2026

[$250] Chat - Go back to home deeplink opens inbox #88443

Open

7 tasks

Revert NotFoundPage changes per reviewer feedback

c5102ee

Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>

MelvinBot marked this pull request as ready for review April 27, 2026 03:21

MelvinBot requested a review from a team as a code owner April 27, 2026 03:21

melvin-bot Bot requested review from JmillsExpensify and bernhardoj and removed request for a team and JmillsExpensify April 27, 2026 03:21

melvin-bot Bot removed the request for review from a team April 27, 2026 03:21

bernhardoj approved these changes Apr 27, 2026

View reviewed changes

melvin-bot Bot requested a review from puneetlath April 27, 2026 12:09

puneetlath approved these changes Apr 27, 2026

View reviewed changes

puneetlath merged commit bf16a4a into main Apr 27, 2026
50 of 52 checks passed

puneetlath deleted the claude-goBackToHomeNavigatesToHome branch April 27, 2026 15:34

OSBotify mentioned this pull request Apr 28, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

arosiclair mentioned this pull request Apr 29, 2026

PR checklist #89226

Open

Conversation

MelvinBot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj commented Apr 23, 2026

Uh oh!

MelvinBot commented Apr 23, 2026

Uh oh!

bernhardoj commented Apr 23, 2026

Uh oh!

MelvinBot commented Apr 23, 2026

Uh oh!

bernhardoj commented Apr 24, 2026

Uh oh!

bernhardoj commented Apr 25, 2026

Uh oh!

MelvinBot commented Apr 25, 2026

Uh oh!

bernhardoj commented Apr 25, 2026

Uh oh!

MelvinBot commented Apr 25, 2026

Uh oh!

bernhardoj commented Apr 27, 2026

Uh oh!

MelvinBot commented Apr 27, 2026

Uh oh!

melvin-bot Bot commented Apr 27, 2026

Uh oh!

bernhardoj commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 27, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

OSBotify commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Apr 23, 2026 •

edited

Loading

codecov Bot commented Apr 23, 2026 •

edited by github-actions Bot

Loading

bernhardoj commented Apr 27, 2026 •

edited

Loading