Skip to content

[CP Staging] Fix QA guide avatar disappearing when reopening admins room#88571

Merged
mountiny merged 4 commits into
mainfrom
claude-fixQaGuideAvatarDisappearing
Apr 23, 2026
Merged

[CP Staging] Fix QA guide avatar disappearing when reopening admins room#88571
mountiny merged 4 commits into
mainfrom
claude-fixQaGuideAvatarDisappearing

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented Apr 23, 2026

Explanation of Change

When navigating to the #admins room with a linkedReportActionID (from actionTargetReportActionID in SidebarLinks), useFlashListScrollKey slices the data array on the initial render to position the linked action at the visual bottom. FlashList then passes index values relative to this sliced displayedData, but renderItem uses those indices against the full sortedVisibleReportActions array for the displayAsGroup computation. This index mismatch causes isConsecutiveActionMadeByPreviousActor to compare the wrong adjacent actions, returning true incorrectly and hiding the QA guide's avatar/name.

This fix resolves the mismatch by looking up the action's real index in sortedVisibleReportActions (via indexOf) instead of relying on the FlashList-provided index.

Fixed Issues

$ #88544
PROPOSAL: #88544 (comment)

Tests

Case 1: Deep-link to a specific message

  1. Open a chat and click on a link that deep-links to a specific message in the #admins room (or any report with a linkedReportActionID)
  2. Verify the QA guide's avatar and name are displayed correctly on their messages
  3. Verify that displayAsGroup correctly groups consecutive messages from the same actor
  4. Verify that no errors appear in the JS console

Case 2: Navigate back from task detail (reproducible in production)

  1. Create a new Gmail account without +
  2. Complete onboarding
  3. Create a workspace
  4. Go to #admins room
  5. Click "Take a test drive" task item to go to task detail page
  6. Click #admins parent navigation in header
  7. Verify the QA guide's avatar and name are displayed correctly on their messages

Offline tests

This change only affects how list indices are resolved for displayAsGroup computation. Offline behavior is unchanged — the same sortedVisibleReportActions array is used regardless of network state.

QA Steps

Case 1: Deep-link to a specific message

  1. Navigate to a report via a deep link that targets a specific report action (e.g., clicking a link to a message in the #admins room)
  2. Verify the avatar and sender name appear correctly on messages — particularly the first message from a different sender should show their avatar/name
  3. Scroll through the chat to verify message grouping looks correct throughout
  4. Verify that no errors appear in the JS console

Case 2: Navigate back from task detail (reproducible in production)

  1. Create a new Gmail account without +
  2. Complete onboarding
  3. Create a workspace
  4. Go to #admins room
  5. Click "Take a test drive" task item to go to task detail page
  6. Click #admins parent navigation in header
  7. Verify the avatar and sender name appear correctly on messages

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Use the action's actual index in sortedVisibleReportActions for
displayAsGroup computation instead of the FlashList-provided index,
which may be offset when useFlashListScrollKey slices the data array
for deep-link scroll positioning.

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
// Use the action's actual index in sortedVisibleReportActions rather than the FlashList-provided index,
// because useFlashListScrollKey may slice the data for deep-link scroll positioning, making the
// FlashList index offset from the full array and causing wrong displayAsGroup computation.
const actionIndex = sortedVisibleReportActions.indexOf(reportAction);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot In favor of this line, no need to pass index anymore here:

{renderItem({
item: action,
index: sortedVisibleReportActions.indexOf(action),
} as ListRenderItemInfo<OnyxTypes.ReportAction>)}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Since renderItem now computes the real index via indexOf internally, the duplicate indexOf call in renderTopReportActions was redundant. Removed it — now just using the map index as the parameter (it only serves as a fallback). Fixed in f20ecda.

Since renderItem now computes the real index via indexOf internally,
the call site in renderTopReportActions no longer needs to compute it.

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
@aimane-chnaif
Copy link
Copy Markdown
Contributor

@MelvinBot add Tests/QA Steps, check off all items in author checklist

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Updated the PR body: added Tests/QA steps and checked off all author checklist items. Since this is a logic-only change in ReportActionsList.tsx (no new files, UI, copy, assets, or CSS), the conditional checklist items (new files, CSS, assets, UI, etc.) are checked as N/A.

@aimane-chnaif
Copy link
Copy Markdown
Contributor

aimane-chnaif commented Apr 23, 2026

@MelvinBot add this test case as Case 2 in Tests/QA Steps, as this is reproducible in production.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Added the production repro steps as Case 2 in both the Tests and QA Steps sections of the PR body.

@aimane-chnaif
Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
mchrome.mov
iOS: HybridApp
ios.mov
iOS: mWeb Safari
msafari.mov
MacOS: Chrome / Safari
web.mov

@aimane-chnaif
Copy link
Copy Markdown
Contributor

@MelvinBot mark as ready for review

@MelvinBot
Copy link
Copy Markdown
Contributor Author

I'm unable to mark this PR as ready for review due to environment permission restrictions. Please click the Ready for review button on the PR page to convert it from draft.

@aimane-chnaif
Copy link
Copy Markdown
Contributor

@MelvinBot mark as ready for review

@MelvinBot MelvinBot marked this pull request as ready for review April 23, 2026 08:55
@MelvinBot MelvinBot requested a review from a team as a code owner April 23, 2026 08:55
@MelvinBot
Copy link
Copy Markdown
Contributor Author

✅ PR marked as ready for review.

@melvin-bot melvin-bot Bot requested review from FitseTLT and heyjennahay and removed request for a team April 23, 2026 08:55
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 23, 2026

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f20ecdaac6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +706 to +707
const actionIndex = sortedVisibleReportActions.indexOf(reportAction);
const safeIndex = actionIndex >= 0 ? actionIndex : index;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove linear lookup from the item render hot path

Computing actionIndex via sortedVisibleReportActions.indexOf(reportAction) inside renderItem makes each row render O(n) in the total action count, so list updates become O(visibleRows × totalRows). In large chats/high-traffic accounts this runs on every scroll/render cycle and can introduce noticeable UI jank compared to the previous O(1) per-item path. Please precompute an index map (e.g., by reportActionID) once per data change or otherwise avoid a full-array scan in the per-item renderer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — replaced the indexOf call with a precomputed Map<reportActionID, index> via useMemo, so index lookup in renderItem is now O(1). Fixed in b9d902d.

Avoids O(n) array scan per rendered row by precomputing a
reportActionID-to-index Map once per data change.

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team as a code owner April 23, 2026 09:19
@melvin-bot melvin-bot Bot requested a review from dmkt9 April 23, 2026 09:19
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 23, 2026

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team April 23, 2026 09:19
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Code Review

The fix is correct and well-structured. A few notes:

What's good:

  • Using a useMemo'd Map<string, number> for O(1) index lookups instead of indexOf (O(n) per render item) — good perf choice for a list that can be large
  • Defensive fallback ?? index handles the (unlikely) case where an action isn't in the map
  • actionIndexMap correctly included in the useCallback dependency array
  • The renderTopReportActions simplification (using .map() index) is clean since renderItem now handles the real index lookup internally

No issues found. The fix correctly addresses the root cause: FlashList indices are relative to sliced displayedData from useFlashListScrollKey, but displayAsGroup needs indices into the full sortedVisibleReportActions array.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9d902d46a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 865 to 867
item: action,
index: sortedVisibleReportActions.indexOf(action),
index,
} as ListRenderItemInfo<OnyxTypes.ReportAction>)}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve global action index in static preview

renderTopReportActions() now passes the preview-local index instead of the action’s index in sortedVisibleReportActions, but this value is forwarded as index to ReportActionsListItemRenderer and ultimately used by ReportActionItemMessageEdit (e.g., deleteDraft treats index === 0 as a special “latest message” case when scrolling). In StaticReportActionsPreview (shown while shouldScrollToEndAfterLayout is true), the sliced/reversed preview indices do not match global list indices, so dismissing/saving a draft can scroll to the wrong item or skip the expected scroll behavior.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cceddfb

{renderItem({
item: action,
index: sortedVisibleReportActions.indexOf(action),
index,
Copy link
Copy Markdown
Contributor

@aimane-chnaif aimane-chnaif Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. @MelvinBot revert this change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted — renderTopReportActions now passes the global index via actionIndexMap instead of the preview-local map index. Fixed in cceddfb.

The preview-local map index doesn't match the global list index,
which can cause wrong scroll behavior for draft dismiss/save.
Use actionIndexMap to pass the correct global index.

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Code Review (updated)

The fix is correct. The current diff uses a useMemo'd Map<string, number> for O(1) index lookups, which is a good improvement over the earlier indexOf approach (O(n) per render item).

Summary of changes:

  • actionIndexMap (useMemo) maps reportActionID → index in the full sortedVisibleReportActions array
  • renderItem resolves the real index via the map with ?? index fallback
  • renderTopReportActions uses the same map, avoiding the redundant indexOf call
  • All dependency arrays are correctly updated

No issues found. The fix correctly addresses the root cause: FlashList indices are relative to sliced displayedData from useFlashListScrollKey, but displayAsGroup needs indices into the full sortedVisibleReportActions array.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/inbox/report/ReportActionsList.tsx 77.70% <88.88%> (+0.18%) ⬆️
... and 20 files with indirect coverage changes

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@aimane-chnaif
Copy link
Copy Markdown
Contributor

Ready for final approval and merge 🎉

@mountiny mountiny changed the title Fix QA guide avatar disappearing when reopening admins room [CP Staging] Fix QA guide avatar disappearing when reopening admins room Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mountiny mountiny merged commit c27efa4 into main Apr 23, 2026
40 checks passed
@mountiny mountiny deleted the claude-fixQaGuideAvatarDisappearing branch April 23, 2026 12:29
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Apr 23, 2026
…pearing

[CP Staging] Fix QA guide avatar disappearing when reopening admins room

(cherry picked from commit c27efa4)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 23, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor Author

No help site changes are required for this PR.

This is an internal rendering bug fix — it corrects how displayAsGroup is computed when FlashList's data is sliced for deep-link scroll positioning. No user-facing features, workflows, settings, or terminology are affected.

@IuliiaHerets
Copy link
Copy Markdown

CP is passed by the QA team, comment

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.62-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot
Copy link
Copy Markdown
Contributor Author

No help site changes are required for this PR.

This is a bug fix that corrects an internal rendering index mismatch in ReportActionsList.tsx — it ensures displayAsGroup uses the correct index from sortedVisibleReportActions instead of the FlashList-provided index (which can be offset when useFlashListScrollKey slices data for deep-link scroll positioning). It doesn't change any user-facing features, settings, workflows, or terminology documented in the help site.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants