Bump @sentry/webpack-plugin and googleapis with lockfile update#88590
Bump @sentry/webpack-plugin and googleapis with lockfile update#88590MonilBhavsar merged 2 commits intomainfrom
Conversation
Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5b9477861
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@mjasikowski could you please add checklist and add QA steps to check google maps and may be sentry too? |
|
@MonilBhavsar the updated libraries are dev dependencies. There's nothing QA can test here. I've added some steps for internal QA but IMHO CI passing should be enough. |
|
Looks like googleapis is used for publishing apps to play store through actions, and sentry for monitoring. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.62-5 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀
|

Summary
@sentry/webpack-pluginfrom4.6.0to5.2.0googleapisfrom^144.0.0to^152.0.0package-lock.jsonto matchThis is a redo of PR #88587 which only updated
package.jsonbut not the lockfile.QA steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.