Skip to content

[Performance] Drop dead NETWORK dependency from visibleReportActions derivation#88592

Merged
rlinoz merged 2 commits intoExpensify:mainfrom
callstack-internal:perf/research-redundancies
Apr 24, 2026
Merged

[Performance] Drop dead NETWORK dependency from visibleReportActions derivation#88592
rlinoz merged 2 commits intoExpensify:mainfrom
callstack-internal:perf/research-redundancies

Conversation

@adhorodyski
Copy link
Copy Markdown
Contributor

@adhorodyski adhorodyski commented Apr 23, 2026 •
edited
Loading

Explanation of Change

Headline (warm LHN → empty chat, 4 trials each):

  • OnyxDerivedCompute_visibleReportActions spans: 1 → 0 per warm nav
  • Removes a full cross-report recompute (~14 reports × ~100 actions) and broadcast to ReportActionsList subscribers, fired on every API call that writes timeSkew (e.g. AuthenticatePusher, which fires on every report open).

src/libs/actions/OnyxDerived/configs/visibleReportActions.ts declared ONYXKEYS.NETWORK as a dependency. The inline comment said "NETWORK is needed to recompute when online/offline status changes (for DELETE action visibility)". That made sense when isOffline lived in the Onyx NETWORK key.

After commit 7f67d3528f8 ("Make isOffline synchronous via NetworkState module-level state", March 2026), isOffline was moved into a transient in-memory module (src/libs/NetworkState.ts) and is no longer persisted to Onyx. The remaining Onyx NETWORK key only holds debug flags (shouldForceOffline, shouldSimulatePoorConnection, shouldFailAllRequests) and timeSkew.

timeSkew is written by src/libs/HttpUtils.ts:86 on every API response matching addSkewList — including AuthenticatePusher, which fires on every report open. Each such write triggered a full cross-report recompute of visibleReportActions. But the compute function (shouldReportActionBeVisible at src/libs/ReportActionsUtils.ts:1221-1325) doesn't read isOffline anywhere — the DELETE-visibility logic it was originally gating on no longer lives there. The dep was vestigial.

Fix: drop ONYXKEYS.NETWORK from dependencies, remove the networkUpdates variable and the || networkUpdates gate, update the stale comment.

Fixed Issues

$
PROPOSAL:

Tests

  1. Open the app on a narrow layout (mobile or narrow browser window)
  2. Warm up by visiting several reports via LHN so their data is in cache
  3. Return to Inbox
  4. Click any recently-visited report from LHN
  5. Verify the report opens normally, chat/attachments render, no visible regressions
  6. Repeat on a wide layout
  • Verify that no errors appear in the JS console

Offline tests

  1. Open the app online, visit a report so it's cached
  2. Toggle offline (DevTools / airplane mode)
  3. Tap the same report in LHN
  4. Verify the report opens from cache, offline indicator shows, and visible report actions render correctly (including any deleted actions per the existing offline semantics)
  5. Toggle back online and verify normal behavior resumes

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

No UI change; see the span-count delta above.

Android: mWeb Chrome

No UI change; see the span-count delta above.

iOS: Native

No UI change; see the span-count delta above.

iOS: mWeb Safari

No UI change; see the span-count delta above.

MacOS: Chrome / Safari

No UI change; see the span-count delta above.

@rlinoz rlinoz mentioned this pull request Apr 23, 2026
Open
@adhorodyski adhorodyski marked this pull request as ready for review April 23, 2026 13:59
@adhorodyski adhorodyski requested review from a team as code owners April 23, 2026 13:59
@melvin-bot melvin-bot Bot requested review from a team, dukenv0307 and heyjennahay and removed request for a team April 23, 2026 13:59
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 23, 2026

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from rlinoz and sobitneupane and removed request for a team April 23, 2026 13:59
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 23, 2026

@sobitneupane @rlinoz One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rlinoz rlinoz removed the request for review from sobitneupane April 23, 2026 14:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Sign in to view
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d703026c66

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/OnyxDerived/configs/reportAttributes.ts
@adhorodyski @claude
Drop NETWORK dep from visibleReportActions derivation
06b9cdc 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@adhorodyski adhorodyski force-pushed the perf/research-redundancies branch from d703026 to 06b9cdc Compare April 23, 2026 14:40
@adhorodyski adhorodyski changed the title [Performance] Drop dead Onyx dependencies from reportAttributes and visibleReportActions derivations [Performance] Drop dead NETWORK dependency from visibleReportActions derivation Apr 23, 2026
adhorodyski
adhorodyski commented Apr 23, 2026
View reviewed changes
Comment thread src/libs/actions/OnyxDerived/configs/visibleReportActions.ts
// Session change = user changed, need full recompute due to whisper targeting
// Network change = online/offline status changed, need full recompute for DELETE action visibility
if (sessionUpdates || networkUpdates) {
if (sessionUpdates) {
Copy link
Copy Markdown
Contributor Author

@adhorodyski adhorodyski Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only store debug flags there as offline/online status is a completely transient piece of state

@rlinoz rlinoz removed the request for review from dukenv0307 April 23, 2026 14:45
@rlinoz
Copy link
Copy Markdown
Contributor

rlinoz commented Apr 23, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@dukenv0307
Copy link
Copy Markdown
Contributor

dukenv0307 commented Apr 23, 2026

@rlinoz Do we need C+ on this PR? I see you've assigned me in #88595

@adhorodyski adhorodyski mentioned this pull request Apr 23, 2026
Open
52 tasks
@rlinoz
Copy link
Copy Markdown
Contributor

rlinoz commented Apr 23, 2026

Hey sorry @dukenv0307 we did need, and then we reverted the change that I was worried about here. No need anymore, thanks

@adhorodyski
Copy link
Copy Markdown
Contributor Author

adhorodyski commented Apr 24, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 24, 2026

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@rlinoz rlinoz merged commit 408dda2 into Expensify:main Apr 24, 2026
31 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88592.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-408dda2-4bd953c-f76040d5c17f573289abd0dabf902254cd98cf44/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-408dda2-4bd953c-cf1354dd031962d71fdfca0426d546d626418ed6/index.html
Android iOS
Web 🕸️
https://88592.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 24, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@adhorodyski adhorodyski mentioned this pull request Apr 24, 2026
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@rlinoz rlinoz rlinoz approved these changes

@heyjennahay heyjennahay Awaiting requested review from heyjennahay

Assignees

@adhorodyski adhorodyski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adhorodyski @rlinoz @dukenv0307 @OSBotify