[WIP] - Add QBD Travel Invoicing ventopr and payable account selector

[brunovjk]

Explanation of Change

Adds the Travel Invoicing configuration section to the QuickBooks Desktop accounting integration settings page, mirroring the existing QuickBooks Online behavior. This PR exposes only the Travel payable account selector for QuickBooks Desktop.

Fixed Issues

$ #88271
PROPOSAL:

Tests

Preconditions

• Workspace has QuickBooks Desktop accounting integration enabled
• Travel Invoicing beta and the feature should both be enabled (Central Invoicing ON)

1. Verify section visibility

1. Navigate to the workspace QuickBooks Desktop accounting integration settings page.
2. Click Export.
3. Case A: Travel Invoicing disabled
   • Verify the Export travel invoice expenses as section is not shown.
4. Case B: Travel Invoicing enabled
   • Verify the Export travel invoice expenses as section is shown.

2. Verify configuration page contents

1. Click Export travel invoice expenses as.
2. Verify a page opens showing exactly this row:
   • Travel payable account

3. Verify travel payable account selector

1. Click Travel payable account.
2. Verify a searchable picker (SelectionList) opens and shows available QuickBooks Desktop accounts.
3. Select a different payable account.
4. Verify you return to the previous page and Travel payable account shows the selected account.
5. Navigate back to the Export page.
6. Verify the Export travel invoice expenses as row reflects the updated configuration.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline.
2. Open Export > Export travel invoice expenses as.
3. Change Travel payable account.
4. Verify the new value is applied optimistically and a pending/offline state is shown.
5. Go back online.
6. Verify the pending state disappears and the selected value remains.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	92.30% <ø> (ø)
src/ROUTES.ts	17.47% <ø> (ø)
src/SCREENS.ts	100.00% <ø> (ø)
src/libs/API/types.ts	100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	76.92% <ø> (ø)
src/libs/actions/connections/QuickbooksDesktop.ts	12.72% <100.00%> (+12.72%)	⬆️
...common/TravelInvoicingPayableAccountSelectPage.tsx	0.00% <0.00%> (ø)
...ounting/common/TravelInvoicingVendorSelectPage.tsx	0.00% <0.00%> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx	6.70% <0.00%> (-0.02%)	⬇️
... and 3 more
... and 18 files with indirect coverage changes

[allgandalf]

@brunovjk dropping a coordination note from the IS side at https://github.com/Expensify/Integration-Server/pull/8922.

For the QBD Travel payable account picker, source the dropdown from the same QBD synced accounts list that the IS exporter's getExportToAccountID validates against. Otherwise we'd hit the Bank Accounts vs Credit Cards mismatch ishpaul flagged on Sage.

For the Travel vendor picker, same idea, source from the QBD synced vendors list the IS exporter's getOrCreateVendor reads from.

ping if anything's unclear!

[melvin-bot]

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[brunovjk]

@inimaga I don't think we need your review here, @rlinoz and @allgandalf are going to.

Cc: @blimpich

[blimpich]

@allgandalf curious for your review on this

[brunovjk]

@blimpich I addressed the QBD travel vendor feedback by removing the QBD travel vendor selector/route/config row/constant/setter and keeping only the payable account flow.

For the payable account setter, I kept the existing UpdateManyPolicyConnectionConfigs command per the follow-up here. I can update it to UpdateQuickbooksDesktopTravelInvoicingPayableAccount once the corresponding Web PR is merged/available in prod.

[allgandalf]

@allgandalf curious for your review on this

on it nowww

[allgandalf]

planning on the review once this gets settled :

https://expensify.slack.com/archives/C05S5EV2JTX/p1778780594576509

[blimpich]

We're blocked here till rightworks lets us back into the test env 😢

[brunovjk]

I'm a bit busy today, but I can respond to comments by the end of the day. Thanks.

[rlinoz]

Hey @brunovjk is this WIP or ready for review?

[rlinoz]

I think we are only missing the new command

[blimpich]

Please update the PR title and body description to not include "vendor" anymore too 🙂

[brunovjk]

Implemented the update to use the dedicated command. I also updated the PR description and tests accordingly. Please let me know if I've missed anything.

Hey @brunovjk is this WIP or ready for review?

@rlinoz This PR should be ready for review, but I’m currently unable to fully test it because we’re blocked from connecting to the QBD test environment until Rightworks restores access.

cc: @blimpich