[No QA] Update country list for ECUK#88626
Conversation
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR updates the UK and EU Expensify Card article to reflect a revised country eligibility list (reduced from 20 to 13 countries) and changes the regional terminology from "EU" to "EEA" in the country list sentence. The PR also includes widespread trailing whitespace cleanup. The substantive content change is narrow and factual -- a country list update discussed internally. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review performed against governance files: docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. Assessment covers only the proposed changes in the diff. |
|
|
||
| 1. Have a GBP or EUR bank account connected. To connect one, [Enable Global Reimbursement](https://help.expensify.com/articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement). | ||
| 1. Have a GBP or EUR bank account connected. To connect one, [Enable Global Reimbursement](https://help.expensify.com/articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement). | ||
| 2. Complete the **[Know Your Customer (KYC)](https://launch-workflow.trulioo.com/68223577c5dae52a6ec9347f)** and **[Know Your Business (KYB)](https://launch-workflow.trulioo.com/681a7cc4e65d2e48f19de9c3)** forms. |
There was a problem hiding this comment.
Cross-linking violation (full URL): Per HELP_AUTHORING_GUIDELINES.md Section 7, "Use relative links only. Do not use full URLs." Replace https://help.expensify.com/articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement with a relative path like /articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement.
Additionally, per Section 7 link formatting rules: "Do not place links inside numbered step instructions. Do not interrupt procedural flow with inline links." Consider moving this link outside the numbered step (e.g., as a note before or after the steps).
| - Slovenia | ||
| - Spain | ||
| - Sweden | ||
| Companies registered in the following 13 UK and EEA countries can enable the Expensify Card for their Workspaces: |
There was a problem hiding this comment.
Consistency issue: This line now says "UK and EEA countries" but the section heading above (line 32) still reads "Check Which Countries Can Enable the Expensify Card in the UK and EU". The heading and body text should use consistent terminology. Consider updating the heading to match ("UK and EEA") or aligning both to the same term.
|
A preview of your ExpensifyHelp changes have been deployed to https://c38b13dc.helpdot.pages.dev ⚡️ Updated articles: |
|
Thanks! |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.62-5 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Update country list for ECUK to final list
Fixed Issues
N/A, discussed here cc @joekaufmanexpensify
Tests
N/A
Offline tests
N/A
QA Steps
N/A
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari