Skip to content

[No QA] Update country list for ECUK#88626

Merged
carlosmiceli merged 4 commits intomainfrom
update-country-list
Apr 23, 2026
Merged

[No QA] Update country list for ECUK#88626
carlosmiceli merged 4 commits intomainfrom
update-country-list

Conversation

@rafecolton
Copy link
Copy Markdown
Member

@rafecolton rafecolton commented Apr 23, 2026

Explanation of Change

Update country list for ECUK to final list

Fixed Issues

N/A, discussed here cc @joekaufmanexpensify

Tests

N/A

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@rafecolton rafecolton self-assigned this Apr 23, 2026
@rafecolton rafecolton requested a review from a team as a code owner April 23, 2026 18:57
@melvin-bot melvin-bot Bot requested a review from carlosmiceli April 23, 2026 18:57
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 23, 2026

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team April 23, 2026 18:57
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the UK and EU Expensify Card article to reflect a revised country eligibility list (reduced from 20 to 13 countries) and changes the regional terminology from "EU" to "EEA" in the country list sentence. The PR also includes widespread trailing whitespace cleanup. The substantive content change is narrow and factual -- a country list update discussed internally.

Scores Summary

  • Readability: 9/10 - The changed lines are clear and scannable. The country list remains a clean bulleted list. The sentence "Companies registered in the following 13 UK and EEA countries can enable the Expensify Card for their Workspaces:" reads naturally. Minor note: the word "However," was removed from the beginning of this sentence, which slightly improves flow.
  • AI Readiness: 8/10 - The changes do not introduce or modify headings, YAML metadata, or structural elements, so AI readiness is largely unchanged. The factual accuracy of the country list improves retrieval quality. No issues introduced by the diff. The existing article (outside the diff scope) has some heading concerns like ## 1. How to enable... with a numeral prefix, but that is pre-existing and not part of this PR.
  • Style Compliance: 9/10 - The change from "Workspace" (singular) to "Workspaces" (plural) in "enable the Expensify Card for their Workspaces" is a reasonable correction for the context (multiple workspaces across different companies). Terminology is consistent with naming conventions. No prohibited language introduced.

Key Findings

  • The country list reduction from 20 to 13 is the core substantive change. Seven countries were removed: Estonia, Greece, Liechtenstein, Malta, Romania, Slovakia, and Slovenia.
  • The regional label changed from "EU" to "EEA" in the country list sentence, which is more precise since the list includes non-EU members. However, the article title and all other references still say "UK and EU" -- this creates a minor inconsistency within the article. The heading above this section still reads "Check Which Countries Can Enable the Expensify Card in the UK and EU" while the body text now says "UK and EEA countries."
  • Trailing whitespace was cleaned up across many lines, which is good hygiene.
  • The cross-link in the pre-requisites section uses a full URL (https://help.expensify.com/articles/...) rather than a relative link. Per HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting): "Use relative links only. Do not use full URLs." This is pre-existing but worth noting since the line was touched (trailing whitespace removed on the adjacent line).

Recommendations

  1. Consider the EU vs. EEA inconsistency: The body text now says "UK and EEA countries" but the article title, H1, and multiple headings still reference "UK and EU." If "EEA" is the correct term, consider updating the title and headings for consistency -- or if "UK and EU" is the preferred branding, revert the body text to match. This is a minor point but could cause confusion for both readers and AI retrieval.
  2. No blocking issues: The country list update itself is clean and well-formatted. This PR is ready to merge from a documentation quality standpoint.

Files Reviewed

  • docs/Hidden/UK-and-EU-Expensify-Card.md - Country list updated from 20 to 13, trailing whitespace cleaned up, "EU" changed to "EEA" in one sentence. No structural or formatting regressions introduced.

Review performed against governance files: docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. Assessment covers only the proposed changes in the diff.


1. Have a GBP or EUR bank account connected. To connect one, [Enable Global Reimbursement](https://help.expensify.com/articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement).
1. Have a GBP or EUR bank account connected. To connect one, [Enable Global Reimbursement](https://help.expensify.com/articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement).
2. Complete the **[Know Your Customer (KYC)](https://launch-workflow.trulioo.com/68223577c5dae52a6ec9347f)** and **[Know Your Business (KYB)](https://launch-workflow.trulioo.com/681a7cc4e65d2e48f19de9c3)** forms.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-linking violation (full URL): Per HELP_AUTHORING_GUIDELINES.md Section 7, "Use relative links only. Do not use full URLs." Replace https://help.expensify.com/articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement with a relative path like /articles/new-expensify/wallet-and-payments/Enable-Global-Reimbursement.

Additionally, per Section 7 link formatting rules: "Do not place links inside numbered step instructions. Do not interrupt procedural flow with inline links." Consider moving this link outside the numbered step (e.g., as a note before or after the steps).

Comment thread docs/Hidden/UK-and-EU-Expensify-Card.md Outdated
- Slovenia
- Spain
- Sweden
Companies registered in the following 13 UK and EEA countries can enable the Expensify Card for their Workspaces:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency issue: This line now says "UK and EEA countries" but the section heading above (line 32) still reads "Check Which Countries Can Enable the Expensify Card in the UK and EU". The heading and body text should use consistent terminology. Consider updating the heading to match ("UK and EEA") or aligning both to the same term.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 23, 2026

A preview of your ExpensifyHelp changes have been deployed to https://c38b13dc.helpdot.pages.dev ⚡️

Updated articles:

Copy link
Copy Markdown
Contributor

@jamesdeanexpensify jamesdeanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@carlosmiceli carlosmiceli merged commit 8575311 into main Apr 23, 2026
23 checks passed
@carlosmiceli carlosmiceli deleted the update-country-list branch April 23, 2026 20:27
@joekaufmanexpensify
Copy link
Copy Markdown
Contributor

Thanks!

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.62-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@arosiclair arosiclair mentioned this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants