[CP Stag] Fix date filter is cut off by bernhardoj · Pull Request #88704 · Expensify/App

bernhardoj · 2026-04-24T11:45:19Z

Explanation of Change

Fixed Issues

$ #88051
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

A.

Open Spend and apply a date filter
Press the date filter chip
Choose Custom date or Custom range
Verify the date picker isn't cut off

B.
Prerequisite: have a workspace with a date type report field

Open Spend and apply a date type report field
Press the report field chip and choose the date type field
Choose Custom date or Custom range
Verify the date picker isn't cut off

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

ewb.mp4

melvin-bot · 2026-04-24T11:45:26Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-24T11:53:35Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../Search/SearchPageHeader/DatePickerFilterPopup.tsx	`0.00% <ø> (ø)`
...ts/Search/SearchPageHeader/useSearchFiltersBar.tsx	`32.60% <ø> (ø)`
...onents/Search/FilterDropdowns/ReportFieldPopup.tsx	`0.00% <0.00%> (ø)`
...s/Search/FilterDropdowns/DateSelectPopup/index.tsx	`0.00% <0.00%> (ø)`
src/libs/SearchUIUtils.ts	`63.80% <0.00%> (-0.12%)`	⬇️
... and 9 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c323d8019

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aimane-chnaif · 2026-04-24T12:23:56Z

Good catch!

aimane-chnaif · 2026-04-24T12:44:02Z


    return (
-        <View style={[styles.pv4, styles.gap2, styles.getPopoverMaxHeight(windowHeight, isInLandscapeMode)]}>
+        <View style={[styles.pv4, styles.gap2]}>


Please also add test case for this

aimane-chnaif · 2026-04-24T13:51:39Z

            closeOverlay={closeOverlay}
            setPopoverWidth={setPopoverWidth}
            presets={getDatePresets(filterKey, true)}
-            style={[styles.getPopoverMaxHeight(windowHeight, isInLandscapeMode)]}


I think we still need max height and make it scrollable instead.

On resized window:

I added back the max height style that was removed in https://github.com/Expensify/App/pull/88191/changes#diff-83cb90c4b04d8b728f53bc1ee7a2400a965b1148a1f4645cec08033cee26d83f, but instead of only applying it when date range modifier is selected, we now apply it to all cases, and also change the View to ScrollView in large screen to make it scrollable.

Note: DateSelectPopup is also used for date-type report field and the max height doesn't work fine

But I think it's fine, no real user will resize their window to be that small. In #88428, the report field date will follow the same max-height as the report field list and other popups.

aimane-chnaif · 2026-04-27T08:27:43Z

Screen.Recording.2026-04-27.at.9.26.01.am.mov

2 issues here: (tested on iOS)

aimane-chnaif · 2026-04-27T08:29:58Z

No spacing in landscape mode

bernhardoj · 2026-04-27T10:35:16Z

Ok, I think I need to fix the report field date max height then. Fixde.

For the second issue, it's unrelated, and happens on the normal date filter too.

aimane-chnaif · 2026-04-27T10:56:03Z

No spacing in landscape mode

Is this also fixed?

bernhardoj · 2026-04-27T11:00:45Z

Yes (the 2nd issue I mean is the extra row of the date picker)

aimane-chnaif · 2026-04-27T11:02:27Z

Please merge main

bernhardoj · 2026-04-27T11:08:02Z

Done

aimane-chnaif · 2026-04-27T12:13:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

ios-landscape.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

aimane-chnaif · 2026-04-27T12:14:24Z

        closeOverlay();
    }, [clearSelection, closeOverlay, onChange, selectedDateModifier]);

+    const maxPopupHeight = Math.round(windowHeight * 0.875);


As a follow-up or any other next PR, define this value in CONST

OSBotify · 2026-04-27T13:15:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

luacmartins · 2026-04-27T14:15:29Z

Should we CP this? It seems like the issue is on staging

aimane-chnaif · 2026-04-27T14:16:25Z

Should we CP this? It seems like the issue is on staging

yes CP please

Fix date filter is cut off (cherry picked from commit 32475e8) (cherry-picked to staging by arosiclair)

OSBotify · 2026-04-28T00:17:23Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.62-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T00:18:34Z

No help site changes required.

This PR is a UI bug fix that prevents date filter popups from being cut off in the Search screen. The changes are limited to internal component layout (adding maxHeight constraints, wrapping content in ScrollView, threading props). No user-facing features, terminology, navigation paths, or workflows were added or changed.

OSBotify · 2026-04-28T01:05:04Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.63-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-04-28T01:43:38Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.3.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

fix date filter is cut off

7c323d8

bernhardoj requested review from a team as code owners April 24, 2026 11:45

melvin-bot Bot assigned bernhardoj Apr 24, 2026

melvin-bot Bot requested review from aimane-chnaif and heyjennahay and removed request for a team April 24, 2026 11:45

melvin-bot Bot removed the request for review from a team April 24, 2026 11:45

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread src/components/Search/SearchPageHeader/DatePickerFilterPopup.tsx

Comment thread src/components/Search/FilterDropdowns/ReportFieldPopup.tsx Outdated

aimane-chnaif reviewed Apr 24, 2026

View reviewed changes

expand popover when selecting date range

1b66486

aimane-chnaif reviewed Apr 24, 2026

View reviewed changes

set max height

fcb59eb

bernhardoj mentioned this pull request Apr 27, 2026

Web - Spend - Apply, Reset button are truncated and not visible in filter pill options #88844

Closed

7 tasks

bernhardoj mentioned this pull request Apr 27, 2026

[Due for payment 2026-04-30] [Search Filter Revamp] Release #1 Update the filter bar to use the searchbar position & add the buttons for filtering/saving the search. #84876

Open

bernhardoj added 2 commits April 27, 2026 18:34

fix content cut off

db7f6a3

fix filter chip is missing when range modifier is applied

9303f23

Merge branch 'main' into fix/date-filter-cut-off

1b87ab2

aimane-chnaif reviewed Apr 27, 2026

View reviewed changes

aimane-chnaif approved these changes Apr 27, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 April 27, 2026 12:14

JS00001 approved these changes Apr 27, 2026

View reviewed changes

JS00001 merged commit 32475e8 into Expensify:main Apr 27, 2026
43 checks passed

luacmartins changed the title ~~Fix date filter is cut off~~ [CP Stag] Fix date filter is cut off Apr 27, 2026

OSBotify pushed a commit that referenced this pull request Apr 27, 2026

Merge pull request #88704 from bernhardoj/fix/date-filter-cut-off

a4b2cdd

Fix date filter is cut off (cherry picked from commit 32475e8) (cherry-picked to staging by arosiclair)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 27, 2026

OSBotify mentioned this pull request Apr 27, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Open

arosiclair mentioned this pull request Apr 29, 2026

PR checklist #89226

Open

Conversation

bernhardoj commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 24, 2026

Uh oh!

codecov Bot commented Apr 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

aimane-chnaif commented Apr 24, 2026

Uh oh!

aimane-chnaif Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Apr 27, 2026

Uh oh!

aimane-chnaif commented Apr 27, 2026

Uh oh!

bernhardoj commented Apr 27, 2026

Uh oh!

aimane-chnaif commented Apr 27, 2026

Uh oh!

bernhardoj commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Apr 27, 2026

Uh oh!

bernhardoj commented Apr 27, 2026

Uh oh!

aimane-chnaif commented Apr 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 27, 2026

Uh oh!

luacmartins commented Apr 27, 2026

Uh oh!

aimane-chnaif commented Apr 27, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

bernhardoj commented Apr 24, 2026 •

edited

Loading

codecov Bot commented Apr 24, 2026 •

edited by github-actions Bot

Loading

bernhardoj commented Apr 27, 2026 •

edited

Loading