[Domain Control] [Release 4] Add `Restrict expense workspace creation/removal` Toggle to DomainGroupDetailsPage by jakubstec · Pull Request #88710 · Expensify/App

jakubstec · 2026-04-24T12:32:15Z

Explanation of Change

Add Restrict expense workspace creation/removal setting for Domain Security Group RHP.

Fixed Issues

$ #80133
PROPOSAL:

Tests

Preconditions:

User is a domain admin
User has at least one security group in his domain

Navigate to /domains/<domainAccountID>/groups
Open any security group
Set Restrict expense workspace creation/removal to true
Verify that it has been correctly changed and visible in security group list

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

iOS: Native

MacOS: Chrome / Safari

Screen.Recording.2026-04-24.at.14.34.02.mov

Screen.Recording.2026-04-24.at.14.33.21.mov

…tails-page' into jakubstec/domains/security-group-details-page-group-permissions3

melvin-bot · 2026-04-24T12:32:21Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

jakubstec · 2026-04-24T12:35:04Z

@codex review

codecov · 2026-04-24T12:42:18Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/Expensify.tsx	`87.50% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
...etAwareScrollView/useActionSheetKeyboardSpacing.ts	`0.00% <ø> (ø)`
src/components/AddPlaidBankAccount.tsx	`0.00% <ø> (ø)`
src/components/AddressForm.tsx	`98.36% <100.00%> (+0.36%)`	⬆️
src/components/AddressSearch/index.tsx	`45.85% <ø> (+1.89%)`	⬆️
src/components/ApproverSelectionList.tsx	`92.50% <ø> (+1.32%)`	⬆️
...rc/components/Attachments/AttachmentView/index.tsx	`52.54% <ø> (-2.91%)`	⬇️
... and 204 more
... and 2806 files with indirect coverage changes

melvin-bot · 2026-04-24T12:43:32Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67f3e9dca6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-24T12:52:56Z

+                    if (!group?.name) {
+                        return;
+                    }


Allow toggling when group name is empty

The toggle handler currently returns early when group?.name is falsy, but name is optional in the security-group model and other UI paths already handle missing names (?? ''). In that state, the new permission toggle appears but never persists, so admins cannot update enableRestrictedPolicyCreation for unnamed groups; this guard should only block when the group itself is missing.

Useful? React with 👍 / 👎.

…fallback on failuredata rollback updatedomainsecuritygroup

situchan · 2026-04-29T08:45:32Z

Please merge main

…urity-group-details-page-group-permissions3

jakubstec · 2026-04-29T11:16:11Z

@situchan done

situchan · 2026-04-29T13:13:27Z

Please fix conflict

…urity-group-details-page-group-permissions3

jakubstec · 2026-04-30T09:04:27Z

@situchan done!

situchan · 2026-04-30T11:27:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

web-failure.mov

MelvinBot · 2026-04-30T11:39:14Z

Code Review

Overall the PR looks solid — the new toggle follows the same patterns as DefaultGroupToggle, types are properly extended, and optimistic/error/pending handling is correct. One issue:

Translation key naming convention: The new keys RestrictExpenseWorkspaceCreation and RestrictExpenseWorkspaceCreationDescription use PascalCase, but every other key in the domain.groups section uses camelCase (title, memberCount, defaultGroup, makeDefault, neverMind, permissions). These should be restrictExpenseWorkspaceCreation and restrictExpenseWorkspaceCreationDescription for consistency.

Everything else looks good:

Toggle component structure matches DefaultGroupToggle.tsx
Type additions in DomainErrors.ts and DomainPendingActions.ts are consistent with existing patterns
The ?? null fallback and Partial<DomainSecurityGroup> type narrowing in Domain.ts make sense for the new boolean field (which may be undefined on existing groups, unlike name which is always a string)

chatgpt-codex-connector · 2026-04-30T11:44:49Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny · 2026-05-04T12:14:28Z

+            RestrictExpenseWorkspaceCreation: 'Erstellen/Entfernen von Ausgaben-Workspaces einschränken',
+            RestrictExpenseWorkspaceCreationDescription:


Suggested change

RestrictExpenseWorkspaceCreation: 'Erstellen/Entfernen von Ausgaben-Workspaces einschränken',

RestrictExpenseWorkspaceCreationDescription:

restrictExpenseWorkspaceCreation: 'Erstellen/Entfernen von Ausgaben-Workspaces einschränken',

restrictExpenseWorkspaceCreationDescription:

mountiny · 2026-05-04T12:14:44Z

+    domainAccountID: number;
+    groupID: string;
+};


…details-page-group-permissions3 # Conflicts: # src/languages/de.ts # src/languages/en.ts # src/languages/es.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/nl.ts # src/languages/pl.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts # src/libs/actions/Domain.ts # src/pages/domain/Groups/DomainGroupDetailsPage.tsx # src/types/onyx/DomainErrors.ts

…missions3' of github.com:software-mansion-labs/expensify-app-fork into jakubstec/domains/security-group-details-page-group-permissions3

mountiny

The ESlint check was fixed here #89518 not going to block on this

mountiny

The ESlint check was fixed here #89518 not going to block on this

melvin-bot · 2026-05-04T16:09:15Z

@ looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

…ec/domains/security-group-details-page-group-permissions3 [Domain Control] [Release 4] Add `Restrict expense workspace creation/removal` Toggle to DomainGroupDetailsPage

mountiny · 2026-05-04T16:17:59Z

Explained above

jakubstec added 4 commits March 16, 2026 16:19

feat: add Restrict expense workspace creation/removal toggle

7f03a84

fix: change es.ts translation

68548ee

Merge remote-tracking branch 'origin/war-in/domains/security-group-de…

1a3c894

…tails-page' into jakubstec/domains/security-group-details-page-group-permissions3

resolve merge conflict

67f3e9d

melvin-bot Bot assigned jakubstec Apr 24, 2026

jakubstec marked this pull request as ready for review April 24, 2026 12:43

jakubstec requested review from a team as code owners April 24, 2026 12:43

melvin-bot Bot requested review from JmillsExpensify and situchan and removed request for a team April 24, 2026 12:43

melvin-bot Bot removed the request for review from a team April 24, 2026 12:43

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

fix: change guard to block when group itself is missing, add nullish …

55d54ff

…fallback on failuredata rollback updatedomainsecuritygroup

Merge remote-tracking branch 'origin/main' into jakubstec/domains/sec…

d7fa1d2

…urity-group-details-page-group-permissions3

Merge remote-tracking branch 'origin/main' into jakubstec/domains/sec…

d83c60c

…urity-group-details-page-group-permissions3

situchan approved these changes Apr 30, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny April 30, 2026 11:32

mountiny requested changes May 4, 2026

View reviewed changes

war-in and others added 4 commits May 4, 2026 17:08

fix: prettier

0a77f46

Merge branch 'jakubstec/domains/security-group-details-page-group-per…

8c52b1e

…missions3' of github.com:software-mansion-labs/expensify-app-fork into jakubstec/domains/security-group-details-page-group-permissions3

apply review changes

adac9a4

mountiny approved these changes May 4, 2026

View reviewed changes

francoisl closed this pull request by merging all changes into Expensify:main in bdce78b May 4, 2026

melvin-bot Bot added the Emergency label May 4, 2026

mountiny removed the Emergency label May 4, 2026

OSBotify mentioned this pull request May 5, 2026

Deploy Checklist: New Expensify 2026-05-05 #89627

Open

87 tasks

		RestrictExpenseWorkspaceCreation: 'Erstellen/Entfernen von Ausgaben-Workspaces einschränken',
		RestrictExpenseWorkspaceCreationDescription:

Conversation

jakubstec commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 24, 2026

Uh oh!

jakubstec commented Apr 24, 2026

Uh oh!

codecov Bot commented Apr 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Apr 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

jakubstec Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

situchan commented Apr 29, 2026

Uh oh!

jakubstec commented Apr 29, 2026

Uh oh!

situchan commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakubstec commented Apr 30, 2026

Uh oh!

situchan commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 30, 2026

Code Review

Uh oh!

chatgpt-codex-connector Bot commented Apr 30, 2026

Uh oh!

mountiny May 4, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny May 4, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 4, 2026

Uh oh!

mountiny commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jakubstec commented Apr 24, 2026 •

edited

Loading

codecov Bot commented Apr 24, 2026 •

edited by github-actions Bot

Loading

situchan commented Apr 29, 2026 •

edited

Loading

situchan commented Apr 30, 2026 •

edited

Loading